From 8604de559719f314eafb7981e8eab57d24d7b6c4 Mon Sep 17 00:00:00 2001 From: Oliver Gierke Date: Tue, 4 Sep 2012 10:02:32 +0200 Subject: [PATCH] DATACMNS-223 - Added logging to ResourceReaderRepositoryPopulator. Logging the read resources in INFO level, the individual elements persisted in DEBUG. Polished JavaDoc. --- .../repository/init/ResourceReaderRepositoryPopulator.java | 7 +++++-- .../init/JacksonResourceReaderIntegrationTests.java | 2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/spring-data-commons-core/src/main/java/org/springframework/data/repository/init/ResourceReaderRepositoryPopulator.java b/spring-data-commons-core/src/main/java/org/springframework/data/repository/init/ResourceReaderRepositoryPopulator.java index 04285ef1f..4ccdc019e 100644 --- a/spring-data-commons-core/src/main/java/org/springframework/data/repository/init/ResourceReaderRepositoryPopulator.java +++ b/spring-data-commons-core/src/main/java/org/springframework/data/repository/init/ResourceReaderRepositoryPopulator.java @@ -30,8 +30,7 @@ import org.springframework.data.repository.support.Repositories; import org.springframework.util.Assert; /** - * A {@link RepositoryPopulator} using a {@link ResourceReader} to read objects from the configured {@link Resource} - * s. + * A {@link RepositoryPopulator} using a {@link ResourceReader} to read objects from the configured {@link Resource}s. * * @author Oliver Gierke * @since 1.4 @@ -100,6 +99,8 @@ public class ResourceReaderRepositoryPopulator implements RepositoryPopulator { for (Resource resource : resources) { + LOG.info(String.format("Reading resource: %s", resource)); + Object result = readObjectFrom(resource); if (result instanceof Collection) { @@ -137,7 +138,9 @@ public class ResourceReaderRepositoryPopulator implements RepositoryPopulator { * @param repositories must not be {@literal null}. */ private void persist(Object object, Repositories repositories) { + CrudRepository repository = repositories.getRepositoryFor(object.getClass()); + LOG.debug(String.format("Persisting %s using repository %s", object, repository)); repository.save(object); } } diff --git a/spring-data-commons-core/src/test/java/org/springframework/data/repository/init/JacksonResourceReaderIntegrationTests.java b/spring-data-commons-core/src/test/java/org/springframework/data/repository/init/JacksonResourceReaderIntegrationTests.java index 55c36c183..01f34ac64 100644 --- a/spring-data-commons-core/src/test/java/org/springframework/data/repository/init/JacksonResourceReaderIntegrationTests.java +++ b/spring-data-commons-core/src/test/java/org/springframework/data/repository/init/JacksonResourceReaderIntegrationTests.java @@ -24,6 +24,8 @@ import org.junit.Test; import org.springframework.core.io.ClassPathResource; /** + * Integration tests for {@link JacksonResourceReader}. + * * @author Oliver Gierke */ public class JacksonResourceReaderIntegrationTests {