From 93dbc26969faa45037edff04d1d36987d9c9515c Mon Sep 17 00:00:00 2001 From: Oliver Gierke Date: Fri, 14 Nov 2014 12:49:24 +0100 Subject: [PATCH] DATACMNS-589 - Polishing. Made DefaultCrudMethods public to support better testing. Components that are based on CrudMethods can be tested easier if DefaultCrudMethods is public, so that an instance can easily be set up by using a DefaultRepositoryMetadata instance. Polished JavaDoc and copyright headers. --- .../data/repository/core/support/DefaultCrudMethods.java | 2 +- .../data/repository/invoker/CrudRepositoryInvoker.java | 1 + .../repository/invoker/DefaultRepositoryInvokerFactory.java | 1 + .../repository/invoker/PagingAndSortingRepositoryInvoker.java | 3 ++- .../data/repository/invoker/ReflectionRepositoryInvoker.java | 1 + .../repository/invoker/RepositoryInvocationInformation.java | 1 + .../data/repository/invoker/RepositoryInvoker.java | 1 + .../data/repository/invoker/RepositoryInvokerFactory.java | 3 ++- 8 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/springframework/data/repository/core/support/DefaultCrudMethods.java b/src/main/java/org/springframework/data/repository/core/support/DefaultCrudMethods.java index 83fd9ed48..0220d1fbb 100644 --- a/src/main/java/org/springframework/data/repository/core/support/DefaultCrudMethods.java +++ b/src/main/java/org/springframework/data/repository/core/support/DefaultCrudMethods.java @@ -39,7 +39,7 @@ import org.springframework.util.Assert; * @author Thomas Darimont * @since 1.6 */ -class DefaultCrudMethods implements CrudMethods { +public class DefaultCrudMethods implements CrudMethods { private static final String FIND_ONE = "findOne"; private static final String SAVE = "save"; diff --git a/src/main/java/org/springframework/data/repository/invoker/CrudRepositoryInvoker.java b/src/main/java/org/springframework/data/repository/invoker/CrudRepositoryInvoker.java index 7bb5adaaa..ab5ec4b50 100644 --- a/src/main/java/org/springframework/data/repository/invoker/CrudRepositoryInvoker.java +++ b/src/main/java/org/springframework/data/repository/invoker/CrudRepositoryInvoker.java @@ -31,6 +31,7 @@ import org.springframework.data.repository.core.RepositoryMetadata; * to avoid reflection overhead introduced by the base class if we know we work with a {@link CrudRepository}. * * @author Oliver Gierke + * @since 1.10 */ class CrudRepositoryInvoker extends ReflectionRepositoryInvoker { diff --git a/src/main/java/org/springframework/data/repository/invoker/DefaultRepositoryInvokerFactory.java b/src/main/java/org/springframework/data/repository/invoker/DefaultRepositoryInvokerFactory.java index ed36d8ab3..13db53f8a 100644 --- a/src/main/java/org/springframework/data/repository/invoker/DefaultRepositoryInvokerFactory.java +++ b/src/main/java/org/springframework/data/repository/invoker/DefaultRepositoryInvokerFactory.java @@ -34,6 +34,7 @@ import org.springframework.util.Assert; * invocations over reflection ones. * * @author Oliver Gierke + * @since 1.10 */ public class DefaultRepositoryInvokerFactory implements RepositoryInvokerFactory { diff --git a/src/main/java/org/springframework/data/repository/invoker/PagingAndSortingRepositoryInvoker.java b/src/main/java/org/springframework/data/repository/invoker/PagingAndSortingRepositoryInvoker.java index aee4e16bc..33d27e05b 100644 --- a/src/main/java/org/springframework/data/repository/invoker/PagingAndSortingRepositoryInvoker.java +++ b/src/main/java/org/springframework/data/repository/invoker/PagingAndSortingRepositoryInvoker.java @@ -1,5 +1,5 @@ /* - * Copyright 2013 the original author or authors. + * Copyright 2013-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -31,6 +31,7 @@ import org.springframework.data.repository.core.RepositoryMetadata; * avoid reflection overhead introduced by the superclass. * * @author Oliver Gierke + * @since 1.10 */ class PagingAndSortingRepositoryInvoker extends CrudRepositoryInvoker { diff --git a/src/main/java/org/springframework/data/repository/invoker/ReflectionRepositoryInvoker.java b/src/main/java/org/springframework/data/repository/invoker/ReflectionRepositoryInvoker.java index fd04f908a..8fafdf27c 100644 --- a/src/main/java/org/springframework/data/repository/invoker/ReflectionRepositoryInvoker.java +++ b/src/main/java/org/springframework/data/repository/invoker/ReflectionRepositoryInvoker.java @@ -40,6 +40,7 @@ import org.springframework.util.StringUtils; * Base {@link RepositoryInvoker} using reflection to invoke methods on Spring Data Repositories. * * @author Oliver Gierke + * @since 1.10 */ class ReflectionRepositoryInvoker implements RepositoryInvoker { diff --git a/src/main/java/org/springframework/data/repository/invoker/RepositoryInvocationInformation.java b/src/main/java/org/springframework/data/repository/invoker/RepositoryInvocationInformation.java index eace19b06..ad47023a5 100644 --- a/src/main/java/org/springframework/data/repository/invoker/RepositoryInvocationInformation.java +++ b/src/main/java/org/springframework/data/repository/invoker/RepositoryInvocationInformation.java @@ -19,6 +19,7 @@ package org.springframework.data.repository.invoker; * Meta-information about the methods a repository exposes. * * @author Oliver Gierke + * @since 1.10 */ public interface RepositoryInvocationInformation { diff --git a/src/main/java/org/springframework/data/repository/invoker/RepositoryInvoker.java b/src/main/java/org/springframework/data/repository/invoker/RepositoryInvoker.java index fecdfc8c1..b0cd63c58 100644 --- a/src/main/java/org/springframework/data/repository/invoker/RepositoryInvoker.java +++ b/src/main/java/org/springframework/data/repository/invoker/RepositoryInvoker.java @@ -30,6 +30,7 @@ import org.springframework.data.repository.PagingAndSortingRepository; * {@link RepositoryInvocationInformation}. * * @author Oliver Gierke + * @since 1.10 */ public interface RepositoryInvoker extends RepositoryInvocationInformation { diff --git a/src/main/java/org/springframework/data/repository/invoker/RepositoryInvokerFactory.java b/src/main/java/org/springframework/data/repository/invoker/RepositoryInvokerFactory.java index 3b1719fed..a3ae666fa 100644 --- a/src/main/java/org/springframework/data/repository/invoker/RepositoryInvokerFactory.java +++ b/src/main/java/org/springframework/data/repository/invoker/RepositoryInvokerFactory.java @@ -1,5 +1,5 @@ /* - * Copyright 2013 the original author or authors. + * Copyright 2013-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,6 +20,7 @@ package org.springframework.data.repository.invoker; * type. * * @author Oliver Gierke + * @since 1.10 */ public interface RepositoryInvokerFactory {