From 9d9f230ed4675dd52974be180f85f2ed61151a0b Mon Sep 17 00:00:00 2001 From: Ruben Dijkstra Date: Fri, 14 Aug 2015 14:43:20 +0200 Subject: [PATCH] DATACMNS-753 - Added test case to see parsing of Sort is not considering defaults for empty parameter. Related ticket: DATACMNS-408. Original pull request: #138. --- ...ortHandlerMethodArgumentResolverUnitTests.java | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/test/java/org/springframework/data/web/SortHandlerMethodArgumentResolverUnitTests.java b/src/test/java/org/springframework/data/web/SortHandlerMethodArgumentResolverUnitTests.java index 7699bcf26..d818c73f7 100644 --- a/src/test/java/org/springframework/data/web/SortHandlerMethodArgumentResolverUnitTests.java +++ b/src/test/java/org/springframework/data/web/SortHandlerMethodArgumentResolverUnitTests.java @@ -149,6 +149,21 @@ public class SortHandlerMethodArgumentResolverUnitTests extends SortDefaultUnitT assertThat(resolveSort(request, PARAMETER), is(nullValue())); } + /** + * + * @see DATACMNS-753 + * see also DATACMNS-408 + */ + @Test + public void doesNotReturnNullWhenAnnotatedWithSortDefault() throws Exception { + + MockHttpServletRequest request = new MockHttpServletRequest(); + request.addParameter("sort", ""); //valid input + + assertNotNull(resolveSort(request, getParameterOfMethod("simpleDefault"))); + assertNotNull(resolveSort(request, getParameterOfMethod("containeredDefault"))); + } + /** * @see DATACMNS-408 */