From b5727d4bf292702c8ac35b8556e45c5fac82fbe6 Mon Sep 17 00:00:00 2001
From: Michael Hunger <github@jexp.de>
Date: Sun, 23 Feb 2014 02:01:09 +0100
Subject: [PATCH] DATACMNS-447 - Soften too strict strickt-check in
 MappingContext.

Previously we directly threw a MappingException in MappingContext.getPersistentEntity(TypeInformation) when the MappingContext was in strict mode and we were given a TypeInformation for which we didn't have a PersistentEntity already.

We now first check whether we should actually create a PersistentEntity for the given TypeInformation if no PersistentEntity is available, before throwing a  MappingException - if we should not then we simply return null (e.g. for simple types like Integer or Double).

Original pull requests: #66, #71.
---
 .../mapping/context/AbstractMappingContext.java     | 10 ++++++----
 .../context/AbstractMappingContextUnitTests.java    | 13 ++++++++++++-
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java b/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
index 3e7bfaf28..ae8cbef2c 100644
--- a/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
+++ b/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
@@ -61,6 +61,8 @@ import org.springframework.util.ReflectionUtils.FieldFilter;
  * @param P the concrete {@link PersistentProperty} type the {@link MappingContext} implementation creates
  * @author Jon Brisbin
  * @author Oliver Gierke
+ * @author Michael Hunger
+ * @author Thomas Darimont
  */
 public abstract class AbstractMappingContext<E extends MutablePersistentEntity<?, P>, P extends PersistentProperty<P>>
 		implements MappingContext<E, P>, ApplicationEventPublisherAware, InitializingBean {
@@ -168,14 +170,14 @@ public abstract class AbstractMappingContext<E extends MutablePersistentEntity<?
 			read.unlock();
 		}
 
-		if (strict) {
-			throw new MappingException("Unknown persistent entity " + type);
-		}
-
 		if (!shouldCreatePersistentEntityFor(type)) {
 			return null;
 		}
 
+		if (strict) {
+			throw new MappingException("Unknown persistent entity " + type);
+		}
+
 		return addPersistentEntity(type);
 	}
 
diff --git a/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java b/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
index 755ed8f55..a1fba1f11 100644
--- a/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
+++ b/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2012 the original author or authors.
+ * Copyright 2011-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -42,6 +42,7 @@ import org.springframework.data.util.TypeInformation;
  * Unit test for {@link AbstractMappingContext}.
  * 
  * @author Oliver Gierke
+ * @author Thomas Darimont
  */
 public class AbstractMappingContextUnitTests {
 
@@ -213,6 +214,16 @@ public class AbstractMappingContextUnitTests {
 		}
 	}
 
+	/**
+	 * @see DATACMNS-447
+	 */
+	@Test
+	public void shouldReturnNullForSimpleTypesIfInStrictIsEnabled() {
+
+		context.setStrict(true);
+		assertThat(context.getPersistentEntity(Integer.class), is(nullValue()));
+	}
+
 	class Person {
 		String name;
 	}