Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-1453 - Polishing.

Browse Source 
Renamed test methods and made use of AssertJ assertions to verify exceptions being thrown.

Original pull request: #328.
This commit is contained in:
Oliver Drotbohm
2018-12-20 15:53:20 +01:00
parent 789099f6b9
commit bb44322b3a
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/test/java/org/springframework/data/auditing/config/AuditingBeanDefinitionRegistrarSupportUnitTests.java
View File

@@ -14,6 +14,8 @@
*/ */
package org.springframework.data.auditing.config; package org.springframework.data.auditing.config;
import static org.assertj.core.api.Assertions.*;
import static org.mockito.ArgumentMatchers.*;
import static org.mockito.Mockito.*; import static org.mockito.Mockito.*;
import java.lang.annotation.Annotation; import java.lang.annotation.Annotation;
@@ -51,21 +53,23 @@ public class AuditingBeanDefinitionRegistrarSupportUnitTests {
verify(registry, times(1)).registerBeanDefinition(anyString(), any(BeanDefinition.class)); verify(registry, times(1)).registerBeanDefinition(anyString(), any(BeanDefinition.class));
} }
@Test(expected = IllegalArgumentException.class) // DATACMNS-1453 @Test // DATACMNS-1453
public void testNullMetadataInput() { public void rejectsNullAnnotationMetadata() {
AuditingBeanDefinitionRegistrarSupport registrar = new DummyAuditingBeanDefinitionRegistrarSupport(); AuditingBeanDefinitionRegistrarSupport registrar = new DummyAuditingBeanDefinitionRegistrarSupport();
registrar.registerBeanDefinitions(null, registry); assertThatExceptionOfType(IllegalArgumentException.class) //
.isThrownBy(() -> registrar.registerBeanDefinitions(null, registry));
} }
@Test(expected = IllegalArgumentException.class) // DATACMNS-1453 @Test // DATACMNS-1453
public void testNullRegistryInput() { public void rejectsNullRegistry() {
AuditingBeanDefinitionRegistrarSupport registrar = new DummyAuditingBeanDefinitionRegistrarSupport(); AuditingBeanDefinitionRegistrarSupport registrar = new DummyAuditingBeanDefinitionRegistrarSupport();
AnnotationMetadata metadata = new StandardAnnotationMetadata(SampleConfig.class); AnnotationMetadata metadata = new StandardAnnotationMetadata(SampleConfig.class);
registrar.registerBeanDefinitions(metadata, null); assertThatExceptionOfType(IllegalArgumentException.class) //
.isThrownBy(() -> registrar.registerBeanDefinitions(metadata, null));
} }
static class SampleConfig {} static class SampleConfig {}