DATACMNS-150 - Fixed potential ClassCastException in DomainClassConverter and -PropertyEditorRegistrar.
Introduced Repositories value object to easily access repository instances and EntityInformation objects registered in an ApplicationContext.
This commit is contained in:
@@ -16,8 +16,7 @@
|
||||
package org.springframework.data.repository.support;
|
||||
|
||||
import static org.hamcrest.Matchers.*;
|
||||
import static org.mockito.Matchers.argThat;
|
||||
import static org.mockito.Matchers.eq;
|
||||
import static org.mockito.Matchers.*;
|
||||
import static org.mockito.Mockito.*;
|
||||
|
||||
import java.io.Serializable;
|
||||
@@ -101,7 +100,7 @@ public class DomainClassPropertyEditorRegistrarUnitTests {
|
||||
private <T> Map<String, T> getBeanAsMap(T bean) {
|
||||
|
||||
Map<String, T> beanMap = new HashMap<String, T>();
|
||||
beanMap.put(bean.getClass().getName(), bean);
|
||||
beanMap.put(bean.toString(), bean);
|
||||
return beanMap;
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,153 @@
|
||||
/*
|
||||
* Copyright 2012 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except
|
||||
import org.springframework.data.repository.core.support.DefaultRepositoryMetadata;
|
||||
in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
package org.springframework.data.repository.support;
|
||||
|
||||
import static org.hamcrest.CoreMatchers.*;
|
||||
import static org.junit.Assert.*;
|
||||
import static org.mockito.Mockito.*;
|
||||
|
||||
import java.io.Serializable;
|
||||
import java.util.HashMap;
|
||||
import java.util.Map;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.runners.MockitoJUnitRunner;
|
||||
import org.springframework.context.ApplicationContext;
|
||||
import org.springframework.data.repository.CrudRepository;
|
||||
import org.springframework.data.repository.Repository;
|
||||
import org.springframework.data.repository.core.EntityInformation;
|
||||
import org.springframework.data.repository.core.RepositoryMetadata;
|
||||
import org.springframework.data.repository.core.support.DefaultRepositoryMetadata;
|
||||
import org.springframework.data.repository.core.support.RepositoryFactoryInformation;
|
||||
|
||||
/**
|
||||
* Unit tests for {@link Repositories}.
|
||||
*
|
||||
* @author Oliver Gierke
|
||||
*/
|
||||
@RunWith(MockitoJUnitRunner.class)
|
||||
public class RepositoriesUnitTests {
|
||||
|
||||
@Mock
|
||||
PersonRepository personRepository;
|
||||
@Mock
|
||||
AddressRepository addressRepository;
|
||||
@Mock
|
||||
ApplicationContext context;
|
||||
|
||||
@Before
|
||||
@SuppressWarnings({ "unchecked", "rawtypes" })
|
||||
public void setUp() {
|
||||
|
||||
Map factoryInformations = getBeanAsMap(new SampleRepoFactoryInformation<Address, Long>(AddressRepository.class),
|
||||
new SampleRepoFactoryInformation<Person, Long>(PersonRepository.class));
|
||||
Map<String, PersonRepository> personRepositories = getBeanAsMap(personRepository);
|
||||
Map<String, AddressRepository> addressRepositories = getBeanAsMap(addressRepository);
|
||||
|
||||
when(context.getBeansOfType(RepositoryFactoryInformation.class)).thenReturn(factoryInformations);
|
||||
when(context.getBeansOfType(PersonRepository.class)).thenReturn(personRepositories);
|
||||
when(context.getBeansOfType(AddressRepository.class)).thenReturn(addressRepositories);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void considersCrudRepositoriesOnly() {
|
||||
|
||||
Repositories repositories = new Repositories(context);
|
||||
|
||||
assertThat(repositories.hasRepositoryFor(Person.class), is(true));
|
||||
assertThat(repositories.hasRepositoryFor(Address.class), is(false));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void doesNotFindInformationForNonManagedDomainClass() {
|
||||
Repositories repositories = new Repositories(context);
|
||||
assertThat(repositories.hasRepositoryFor(String.class), is(false));
|
||||
assertThat(repositories.getRepositoryFor(String.class), is(nullValue()));
|
||||
}
|
||||
|
||||
@Test(expected = IllegalArgumentException.class)
|
||||
public void rejectsNullBeanFactory() {
|
||||
new Repositories(null);
|
||||
}
|
||||
|
||||
class Person {
|
||||
|
||||
}
|
||||
|
||||
class Address {
|
||||
|
||||
}
|
||||
|
||||
interface PersonRepository extends CrudRepository<Person, Long> {
|
||||
|
||||
}
|
||||
|
||||
interface AddressRepository extends Repository<Address, Long> {
|
||||
|
||||
}
|
||||
|
||||
static class SampleRepoFactoryInformation<T, S extends Serializable> implements RepositoryFactoryInformation<T, S> {
|
||||
|
||||
private final RepositoryMetadata repositoryMetadata;
|
||||
|
||||
public SampleRepoFactoryInformation(Class<?> repositoryInterface) {
|
||||
this.repositoryMetadata = new DefaultRepositoryMetadata(repositoryInterface);
|
||||
}
|
||||
|
||||
@SuppressWarnings({ "unchecked" })
|
||||
public EntityInformation<T, S> getEntityInformation() {
|
||||
|
||||
return new EntityInformation<T, S>() {
|
||||
|
||||
public Class<T> getJavaType() {
|
||||
return (Class<T>) repositoryMetadata.getDomainClass();
|
||||
}
|
||||
|
||||
public boolean isNew(T entity) {
|
||||
return false;
|
||||
}
|
||||
|
||||
public S getId(T entity) {
|
||||
return null;
|
||||
}
|
||||
|
||||
public Class<S> getIdType() {
|
||||
return (Class<S>) repositoryMetadata.getIdClass();
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
@SuppressWarnings("unchecked")
|
||||
public Class<? extends Repository<T, S>> getRepositoryInterface() {
|
||||
return (Class<? extends Repository<T, S>>) repositoryMetadata.getRepositoryInterface();
|
||||
}
|
||||
}
|
||||
|
||||
private static <T> Map<String, T> getBeanAsMap(T... beans) {
|
||||
|
||||
Map<String, T> beanMap = new HashMap<String, T>();
|
||||
|
||||
for (T bean : beans) {
|
||||
beanMap.put(bean.toString(), bean);
|
||||
}
|
||||
return beanMap;
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user