Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-1583 - Introduced QPageRequest.of(…) factory methods.

Browse Source 
These methods are introduced for consistency with PageRequest. Constructors have been deprecated fro removal in 2.2.
This commit is contained in:
Oliver Drotbohm
2019-09-25 13:58:39 +02:00
parent 725d88811c
commit d1d5fa085d
2 changed files with 50 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/java/org/springframework/data/querydsl/QPageRequestUnitTests.java
View File

@@ -31,14 +31,14 @@ public class QPageRequestUnitTests extends AbstractPageRequestUnitTests {
*/
@Override
public AbstractPageRequest newPageRequest(int page, int size) {
return new QPageRequest(page, size);
return QPageRequest.of(page, size);
}
@Test
public void constructsQPageRequestWithOrderSpecifiers() {
QUser user = QUser.user;
QPageRequest pageRequest = new QPageRequest(0, 10, user.firstname.asc());
QPageRequest pageRequest = QPageRequest.of(0, 10, user.firstname.asc());
assertThat(pageRequest.getSort()).isEqualTo(QSort.by(user.firstname.asc()));
}
@@ -47,7 +47,7 @@ public class QPageRequestUnitTests extends AbstractPageRequestUnitTests {
public void constructsQPageRequestWithQSort() {
QUser user = QUser.user;
QPageRequest pageRequest = new QPageRequest(0, 10, QSort.by(user.firstname.asc()));
QPageRequest pageRequest = QPageRequest.of(0, 10, QSort.by(user.firstname.asc()));
assertThat(pageRequest.getSort()).isEqualTo(QSort.by(user.firstname.asc()));
}
@@ -56,6 +56,6 @@ public class QPageRequestUnitTests extends AbstractPageRequestUnitTests {
public void rejectsNullSort() {
assertThatExceptionOfType(IllegalArgumentException.class) //
.isThrownBy(() -> new QPageRequest(0, 10, (QSort) null));
.isThrownBy(() -> QPageRequest.of(0, 10, (QSort) null));
}
}