Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-581 - Add support for NotContaining keyword for derived repository queries.

Browse Source 
We now support the keyword NotContaining in query methods for repositories. This is achieved by adding NOT_CONTAINING to the Part.Type enum with the variants 'IsNotContaining', 'NotContaining', 'NotContains'. Added a dedicated toString() method to ease debugging to Part.Type.

Original pull request: #100.
This commit is contained in:
Thomas Darimont
2014-10-20 20:19:35 +02:00
committed by Oliver Gierke
parent c898f1ec7b
commit dec5cadce9
2 changed files with 39 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/test/java/org/springframework/data/repository/query/parser/PartTreeUnitTests.java
View File

@@ -150,7 +150,7 @@ public class PartTreeUnitTests {
@Test
public void supportToStringWithSortOrder() throws Exception {
PartTree tree = partTree("firstnameOrderByLastnameDesc");
assertThat(tree.toString(), is(equalTo("firstname SIMPLE_PROPERTY Order By lastname: DESC")));
assertThat(tree.toString(), is(equalTo("firstname SIMPLE_PROPERTY (1): [Is, Equals] Order By lastname: DESC")));
}
@Test
@@ -650,7 +650,25 @@ public class PartTreeUnitTests {
assertLimiting("countFirst10DistinctUsersByLastname", User.class, false, null, true);
assertLimiting("countTop10DistinctUsersByLastname", User.class, false, null, true);
}
/**
* @see DATACMNS-581
*/
@Test
public void parsesIsNotContainingCorrectly() throws Exception {
assertType(asList("firstnameIsNotContaining", "firstnameNotContaining", "firstnameNotContains"), NOT_CONTAINING, "firstname");
}
/**
* @see DATACMNS-581
*/
@Test
public void buildsPartTreeForNotContainingCorrectly() throws Exception {
PartTree tree = new PartTree("findAllByLegalNameNotContaining", Organization.class);
assertPart(tree, new Part[] { new Part("legalNameNotContaining", Organization.class) });
}
private static void assertLimiting(String methodName, Class<?> entityType, boolean limiting, Integer maxResults) {
assertLimiting(methodName, entityType, limiting, maxResults, false);
}