Commit Graph

304 Commits

Author SHA1 Message Date
Oliver Gierke
ddea8eda8f DATACMNS-157 - Query method lookup now only returns most specific method for overridden methods.
Supposed you have a base repository interface declaring a method:

interface BaseRepository<T, ID extends Serializable> extends Repository<T, ID> {

  T myGenericMethod();
}

as well as a concrete repository redeclaring this method to annotate a query on it:

interface ConcreteRepository extends BaseRepository<User, Long> {

  @Query("…")
  User myGenericMethod()
}

Until now we both returned the intermediate method as well as the concrete one which might cause failures as in this case a query derivation would be attempted for the intermediate method which will fail for obvious reasons. The fix now starts with looking up the most specific method when iterating over the repository's methods which causes the intermediate method to be skipped in case it was overridden.
2012-04-20 13:55:49 +02:00
Oliver Gierke
06dc1e5dba DATACMNS-156 - Removed deprecated persistence package. 2012-04-20 13:20:14 +02:00
Oliver Gierke
ecf3592d1f DATACMNS-153 - Fixed class loading issue in SimpleEntityPathResolver.
The path class is loaded using the domain class' class loader instead of the one of SimpleEntityPathResolver.
2012-04-20 13:01:10 +02:00
Oliver Gierke
f1516a96aa DATACMNS-154 - Fixed query method detection when re-declararing CrudRepositoryMethods.
With the fix for DATACMNS-151 we apparently broke the generic parameter type matching for methods that carry the domain class type parameter as argument. We now inspect the bound and make sure we compare the name of it if it's a TypeVariable or use the plain parameter type if its not.
2012-04-19 12:45:33 +02:00
Spring Buildmaster
91eef0e8a5 DATACMNS-148 - Next development version. 2012-04-16 11:55:00 +02:00
Spring Buildmaster
703b285962 Release version 1.3.0.RC1. 2012-04-16 11:54:50 +02:00
Oliver Gierke
81718ae373 DATACMNS-152 - Improved API in mapping subsystem.
PersistentProperty now exposes isEntity(). Mapping context now allows accessing a PersistentEntity referred to from a PersistentProperty. JavaDoc cleanups in MappingContext interface.
2012-04-14 13:27:50 +02:00
Oliver Gierke
67c8c53f5e DATACMNS-151 - Improve CrudRepository method signature generics.
Method signatures of save(…) methods in CrudRepository now return the concrete type passed in. This way subtypes can be persisted without casting the result back.

class Contact { … }
class Person extends Contact { … }

interface ContactRepository extends CrudRepository<Contact, Long> { … }

Before:

Person person = new Person();
person = (Person) repo.save(person);
         ^^^^^^^^

Now:

Person person = new Person();
person = repo.save(person);
2012-04-13 22:32:16 +02:00
Oliver Gierke
c158442dc7 DATACMNS-150 - Fixed potential ClassCastException in DomainClassConverter and -PropertyEditorRegistrar.
Introduced Repositories value object to easily access repository instances and EntityInformation objects registered in an ApplicationContext.
2012-04-13 21:18:07 +02:00
Oliver Gierke
aa12db22c0 DATACMNS-121 - Implement equals(…) and hashCode() of AbstractPersistentProperty.
Implemented equals(…) and hashCode() methods based on the field backing the property.
2012-04-11 21:00:03 +02:00
Oliver Gierke
f3d037ba7d DATACMNS-139 - Fixed potential StackOverflowException in PropertyPath.
When trying to access an inexistent property starting with an underscore (e.g. _id) PropertyPath.create(…) ran into a StackOverflowException. Changed the traversing regular expression to expect at least one capital letter for further traversals.
2012-04-11 18:18:58 +02:00
Oliver Gierke
109e7f903e DATACMNS-132 - Guard against untyped Maps and Collections in AbstractPersistentProperty.isEntity().
Just mentioned method threw a NullPointerException when the property was backed by an untyped Map or Collection as TypeInformation.getActualType() returns null in this case. Changed that to correctly return false.
2012-04-11 18:18:57 +02:00
Oliver Gierke
75c67f0b57 DATACMNS-124 - Removed accidentally committed code. 2012-04-11 18:18:43 +02:00
Oliver Gierke
a2e5cc439e DATACMNS-141 - Added Before and After as query parser keywords.
The query parser now supports After, IsAfter, Before and IsBefore as keywords. Added the Is* prefix to suitable keywords as well and refactored unit tests quite a bit to ease adding new keyword tests.
2012-04-09 17:39:16 +02:00
Oliver Gierke
b811fa3ea8 DATACMNS-124 - Added missing package-info.java files.
Polished JavaDocs. Polished MappingContextEvent and added deprecations to it to be cleaned up for 1.3.GA.
2012-04-04 17:39:30 +02:00
Oliver Gierke
5c248983d2 DATACMNS-120 - Added equals(…) and hashCode() methods to Parameter. 2012-04-03 10:32:52 +02:00
Oliver Gierke
cb375b250f DATACMNS-142 - Polished API of UserCredentials.
Added constant to represent no credentials. Removed empty constructor. Added methods to ask whether username or password is configured.
2012-04-02 15:24:09 +02:00
Oliver Gierke
b4d21008e3 DATACMNS-111 - Added query parser keywords StartingWith, EndingWith and Containing. 2012-03-21 16:41:51 +01:00
Oliver Gierke
8e52d75ca9 DATACMNS-135 - Added accessor for the underlying content to Revisions. 2012-03-21 12:38:12 +01:00
Oliver Gierke
9e44d587f8 DATACMNS-136 - Made some Spring dependencies optional in template.mf.
We have declared some Spring dependencies optional in the pom.xml file. I've changed the template.mf to declare the package dependencies of these artifacts as optional as well.
2012-03-20 11:45:21 +01:00
Oliver Gierke
f8d5e310a7 DATACMNS-135 - Added basic infrastructure to support historiography of data.
Added interfaces for common abstractions needed to implement historiography. A Revision is an entity associated with some RevisionMetadata. That in turn consists of a revision number and date at least and is backed by a implementation specific delegate. The Revisions wrapper class allows accessing the latest revision from a list of Revision instances no matter what order they are in. A RevisionRepository allows access the revision an entity was changed in the last time, access all Revisions of an entity as well as paged access to it.
2012-03-20 11:33:02 +01:00
Oliver Gierke
2f39b74cbc DATACMNS-133 - Fixed bean lookup in DomainClassConverter.
Previously DomainClassConverter looked up the RepositoryInformation instances from the entire BeanFactory hierarchy but only looked the actual repository up from the current BeanFactory and not the entire hierarchy. Fixed and added test case.
2012-03-20 11:03:51 +01:00
Oliver Gierke
c2fd1e255a DATACMNS-134 - Changed instantation infrastructure to be able to instantiate member types.
In case a member class is not static the compiler will either create a constructor with a parameter of the enclosing type or alter the existing ones to add a first parameter of that type. Thus when instantiating the class we need to detect that case and hand in the parent object as parameter value.

Updated PreferredConstructor and Parameter abstractions to allow detecting this case as well as the ParameterValueProvider abstraction to capture the parent object.
2012-03-09 15:06:06 +01:00
Oliver Gierke
9005e1903d DATACMNS-133 - Improved DomainClassConverter implementation.
DomainClassConverter now registers itself with the ConversionService handed into it. Added integration tests for lookup of RepositoryFactoryInformation.
2012-02-28 19:03:58 +01:00
Spring Buildmaster
3903fa7281 Next development version. 2012-02-07 11:23:22 -08:00
Spring Buildmaster
257d8af077 Release version 1.3.0.RELEASE. 2012-02-07 11:23:19 -08:00
Oliver Gierke
bfd306dba7 DATACMNS-131 - Formatting. 2012-02-03 12:07:56 +01:00
Oliver Gierke
4fcb4a7649 DATACMNS-131 - Polished pom.xml. 2012-02-03 12:07:41 +01:00
Oliver Gierke
01898131a6 DATACMNS-129 - Introduced CrudRepository.findAll(Iterable<ID> ids). 2012-02-02 18:29:30 +01:00
Oliver Gierke
b1f2eac2b9 DATACMNS-128 - Introduced ParameterAccessor.hasBindableNullValue(). 2012-02-02 18:29:30 +01:00
Oliver Gierke
15c3b74c3f DATACMNS-127 - Added DelegatingEntityInformation. 2012-02-02 18:29:23 +01:00
Oliver Gierke
e150264f3e Polished namespace schema. 2012-01-31 20:06:26 +01:00
Oliver Gierke
ef65df279f DATACMNS-125 - QueryExecutorMethodInterceptor now correctly rejects repository interfaces with query methods if no QueryLookupStrategy defined. 2012-01-24 10:23:45 +01:00
Oliver Gierke
c683d28add DATACMNS-123 - Deprecated types of persistence package. 2012-01-24 10:02:40 +01:00
Oliver Gierke
35697d639a DATACMNS-122 - Introduced further abstractions to improve entity instantiation.
PersistentEntity now has a isConstructorArgument(…) allowing to find out whether a PersistentProperty is referred to from a constructor argument. The PreferredConstructor abstraction now keeps track of the PersistentEntity it is built for and thus allows finding out whether a constructor Parameter maps a PersistentProperty.

Removed bean creation responsibility from BeanWrapper and introduced EntityInstantiator abstraction to allow the entity instantiation mechanism be short circuited via custom implementations. The reflection based implementation from BeanWrapper is now residing in ReflectionEntityInstantiator.
2012-01-24 10:00:27 +01:00
Oliver Gierke
59d8852921 DATACMNS-119 - Order now implements Serializable. 2012-01-11 13:37:31 +01:00
Oliver Gierke
8c360af381 DATACMNS-118 - Prepare 1.3.0 development branch. 2011-12-22 20:24:42 +01:00
Oliver Gierke
5213eace28 DATACMNS-118 - Preparations for 1.2.0 release.
Updated changelog and version. Removed milestone repository and use Artifactory repository now.
2011-12-22 20:17:11 +01:00
Oliver Gierke
0053e335b5 DATACMNS-104 - Upgraded to Spring 3.0.7.
Removed GenericTypeResolver copy as all necessary local changes have been released with Spring 3.0.7.
2011-12-22 20:08:44 +01:00
Oliver Gierke
48d4c05a9d DATACMNS-114 - Improved detection of custom implementations for repositories.
Fixed edge case scenario where the lookup for repository implementation classes picked up multiple classes if they ended with the same suffix (e.g. FooRepoImpl, AnotherFooRepoImpl). We're now expecting the classname to be an exact match but still allow nested packages. Changed the parser to reject multiple found implementation classes strictly now to at least avoid undiscoverable errors in case an ambiguity is popping up.
2011-12-20 12:29:38 +01:00
Oliver Gierke
89410efb7a DATACMNS-112, DATACMNS-109 - Upgraded to Querydsl 2.3.0. 2011-12-19 18:03:08 +01:00
Dirk Mahler
eebc822dff DATACMNS-110 - Added support for CDI integration for repositories.
Added custom CDI extension to use repositories in a CDI environment. Base class picks up all Spring Data repository interfaces and allows working with qualifiers to bind beans to be created to qualifiers.
2011-12-19 16:29:46 +01:00
Oliver Gierke
0334a2dd78 DATACMNS-113 - Introduced annotations to resolve custom conversion disambiguities.
Introduced @ReadingConverter and @WritingConverter to allow to resolve disambiguates that might arise when implementing custom Converters.

Suppose we implemented a Converter<String, Class> and the store is able to handle both String and Class as native types. In this case there's no way to determine whether the converter shall actually be used to convert String properties into Class instances when writing or to create Class instances from Strings when reading. Thus the @ReadingConverter comes in handy in this case to tell the infrastructure to consider the converter for reading only.
2011-12-16 14:11:08 +01:00
Mark Pollack
a0c91672ae prepare for Spring Data Commons 1.2.0.BUILD-SNAPSHOT 2011-12-06 17:37:12 -05:00
Mark Pollack
a15186013f prepare for Spring Data Commons 1.2.0.RC1 2011-12-06 17:07:08 -05:00
Oliver Gierke
188e396268 DATACMNS-107 - Allow IsTrue/IsFalse as keywords for True/False. 2011-12-06 17:02:54 +01:00
Oliver Gierke
ca4d2f504a DATACMNS-108 - Fixed ClassCastException in RepositoryFactorySupport. 2011-12-05 18:58:49 +01:00
Oliver Gierke
b3c8cb5620 DATACMNS-88 - Map value types are now resolve correctly for generic types extending Map.
Extracted base ParentTypeAwareTypeInformation class as base class for TypeInformations that need to consider the parent's type variable map.
2011-12-05 16:56:29 +01:00
Oliver Gierke
498f40b69f DATACMNS-107 - Added support for True and False as query method keywords. 2011-12-05 12:52:52 +01:00
Oliver Gierke
f7b796dcee DATACMNS-94 - Added Regex and Exists keywords for query parser. 2011-12-05 12:52:21 +01:00