Commit Graph

1309 Commits

Author SHA1 Message Date
Mark Paluch
e01d8e4243 DATACMNS-1562 - Prepare 2.2 GA (Moore). 2019-09-30 15:50:43 +02:00
Mark Paluch
1e88d28335 DATACMNS-1562 - Updated changelog. 2019-09-30 15:50:33 +02:00
Mark Paluch
38e06ff084 DATACMNS-1561 - Updated changelog. 2019-09-30 11:16:16 +02:00
Christoph Strobl
c62bc6f7cc DATAMONGO-1584 - Polishing.
Original Pull Request: #407
2019-09-30 10:20:07 +02:00
Mark Paluch
37ab48e97e DATACMNS-1584 - Add documentation for Kotlin support.
Original Pull Request: #407
2019-09-30 09:55:09 +02:00
Mark Paluch
dbc6810fc3 DATACMNS-1211 - Add ReactivePageableHandlerMethodArgumentResolver.
Add ReactivePageableHandlerMethodArgumentResolver and extract shared code from imperative PageableHandlerMethodArgumentResolver into PageableHandlerMethodArgumentResolverSupport.

Original pull request: #264.
2019-09-26 16:43:58 +02:00
Mark Paluch
48daa4c4b1 DATACMNS-1211 - Add ReactiveSortHandlerMethodArgumentResolver.
Add ReactiveSortHandlerMethodArgumentResolver and extract shared code from imperative SortHandlerMethodArgumentResolver into SortHandlerMethodArgumentResolverSupport.

Original pull request: #264.
2019-09-26 16:43:50 +02:00
Oliver Drotbohm
d1d5fa085d DATACMNS-1583 - Introduced QPageRequest.of(…) factory methods.
These methods are introduced for consistency with PageRequest. Constructors have been deprecated fro removal in 2.2.
2019-09-25 13:58:39 +02:00
Oliver Drotbohm
725d88811c DATACMNS-1581 - Polishing.
Javadoc on (Q)PageRequest.
2019-09-25 13:45:20 +02:00
Oliver Drotbohm
221ad9353e DATACMNS-1581 - Tighten nullability constraints for Sort parameters in PageRequest factory methods.
We now explicitly rejects null values for the Sort parameters in the constructor of PageRequest to avoid the creation of invalid instances if the IDE validation of nullability constraints is not in use.
2019-09-25 13:45:14 +02:00
Bruno Lellis
74a26dd3fe DATACMNS-1580 - Fix PersonRepository domain class in documentation.
Just a small fix declaring Person as PersonRepository's domain class.

Original pull request: #298.
2019-09-18 15:56:11 +02:00
Roland Weisleder
2467cd7d42 DATACMNS-1580 - Fix typo in Javadoc.
Original pull request: #316.
2019-09-18 15:43:24 +02:00
Matthias Merdes
9647e72c27 DATACMNS-1580 - Fix typo in Javadoc.
Original pull request: #329.
2019-09-18 15:41:35 +02:00
Mark Paluch
78dcab59c7 DATACMNS-1486 - Polishing.
Consistently annotate all nullable method arguments with Nullable.

Original pull request: #341.
2019-09-18 15:34:47 +02:00
Henning Hoefer
6699e9692f DATACMNS-1486 - Add missing Nullable annotation in HateoasSortHandlerMethodArgumentResolver.
Original pull request: #341.
2019-09-18 15:33:39 +02:00
Jef LeCompte
598c9cf443 DATACMNS-1580 - Add semicolon in documentation for clarity.
Original pull request: #401.
2019-09-18 15:28:58 +02:00
Mark Paluch
1813ee79f0 DATACMNS-1563 - Prepare 2.2 RC3 (Moore). 2019-09-06 10:10:12 +02:00
Mark Paluch
e3e8dfde6f DATACMNS-1563 - Updated changelog. 2019-09-06 10:10:01 +02:00
Oliver Drotbohm
ac3fc2bddd DATACMNS-1578 - Polishing. 2019-09-05 17:35:15 +02:00
Colin Gao
30dbac1bce DATACMNS-1578 - Proper handling of null values in QuerydslDefaultBinding.
We now properly use an ….isNull() binding if the value to be compared to is null.
2019-09-05 17:34:51 +02:00
Oliver Drotbohm
3ebe74d018 DATACMNS-1568 - Document null handling of Sort (and Pageable) properties. 2019-09-02 15:21:17 +02:00
Michael Simons
2024c1941b DATACMNS-1576 - Fix JavaDoc on CustomConversions.
Original pull request: #405.
2019-09-02 14:26:24 +02:00
Oliver Drotbohm
c42f5efe01 DATACMNS-1547 - Properly remove partially populated PersistentEntity instances from cache.
We now remove partially populated PersistentEntity instances from the cache held in AbstractMappingContext as the creation could fail for other RuntimeExceptions other than a MappingException and we wouldn't want to keep the instances around in any case.

Slight refactorings in the unit tests so that we can easily create MappingContext instances that reject certain types with certain exceptions.
2019-08-30 12:11:55 +02:00
Oliver Drotbohm
3e41d932dd DATACMNS-1571 - Polishing. 2019-08-28 10:06:46 +02:00
Oliver Drotbohm
85e257fc82 DATACMNS-1571 - Fixed specialization in ParameterizedTypeInformation.
DATACMNS-783 introduced code to specialize a raw type containing generics with the type information from it's context so that it can be established if only the raw type has been e.g. stored as type hint in a store (SomeType<T> stored as SomeType and T needing to be reestablished from the context). That application of the context unfortunately did not consider that the raw type might carry generics information itself, like `SomeType extends Foo<String, Integer>`.

We've now changed the specialization algorithm so that the the target type is being looked at in the context of the type used for the assignment (e.g. `Foo<T, ID> foo`). If that assignment fully resolves the declared type, we just outright use the given type as it by definition carries all generics information plus better type information in the first place.

If the type to specialize on is only partially expanding the generics we now create a synthetic type to merge the generics information. I.e. a `SomeType<T> extends Foo<T, Integer>` stored as SomeType would still resolve ID to Integer but capture T from the context including all potentially declared bounds.

Related tickets: DATACMNS-783, DATACMNS-1138.
2019-08-28 10:06:46 +02:00
Christoph Strobl
150e327109 DATACMNS-1571 - Unit tests to reproduce the issue. 2019-08-28 10:06:46 +02:00
Jens Schauder
65b85da8f1 DATACMNS-1570 - Made the behaviour consistent between Subject part and Order By part.
The subject part wasn't decapitalizing properties starting with multiple characters properly.

Original pull request: #402.
2019-08-27 09:39:04 +02:00
Oliver Drotbohm
dcb08cfaed DATACMNS-1569 - Updated Javadoc in Querydsl APIs for nullability rules on paging and sorting. 2019-08-22 12:47:36 +02:00
Stas
34c683bc57 DATACMNS-1567 - Fixed copyright year in Repository.java.
Original pull request: #392.
2019-08-16 08:49:14 +02:00
Mark Paluch
2b326bc4d7 DATACMNS-1565 - Add HTTPS entries into spring.schemas.
To resolve XSD files properly from the classpath, their HTTPS reference must be present in the spring.schemas to avoid internet interaction for resolving an XSD file.
2019-08-06 15:37:12 +02:00
Mark Paluch
9ebbd9e33f DATACMNS-1544 - Prepare 2.2 RC2 (Moore). 2019-08-05 15:35:05 +02:00
Mark Paluch
5c85f47feb DATACMNS-1544 - Updated changelog. 2019-08-05 15:34:54 +02:00
Mark Paluch
b609cd0167 DATACMNS-1543 - Updated changelog. 2019-08-05 11:34:28 +02:00
Mark Paluch
a7c76d5593 DATACMNS-1533 - Updated changelog. 2019-08-05 11:09:00 +02:00
Sangwoo Lee
ff02d34474 DATACMNS-1557 - Fix typo in Sort Javadoc.
From `ASC` to `DESC`.

Original pull request: #400.
2019-07-29 11:07:00 +02:00
Mark Paluch
88b0b3c924 DATACMNS-1556 - Store values as array in ParametersParameterAccessor.
Prevents changes in store modules that expose values as array.
2019-07-25 14:12:11 +02:00
Mark Paluch
b8c0a2fa8f DATACMNS-1556 - Deeply inspect query results deeply for the need of query post-processing.
We now inspect returned Collections whether we need to convert these at all. If not, we skip conversion.

Also, allocate GenericConversionService only once for memory-efficiency.
2019-07-25 14:12:11 +02:00
Mark Paluch
94c4713e0f DATACMNS-1556 - Conditionally copy and unwrap query method arguments.
ParametersParameterAccessor now inspects invocation arguments whether we need to unwrap these at all. If not, we skip copying the list of values.
2019-07-25 14:12:11 +02:00
Mark Paluch
f1bc778098 DATACMNS-1556 - Remove capturing lambdas from hot code paths.
Replaced orElseThrow with if blocks. Introduce nullable RepositoryComposition.getMethod(Method) to avoid Optional handling in hot code paths.
2019-07-25 14:12:11 +02:00
Mark Paluch
972449ef2d DATACMNS-1556 - Limit default method invocation only to interfaces that actually declare default methods. 2019-07-25 14:12:11 +02:00
Mark Paluch
293bbd9a63 DATACMNS-1556 - General performance improvements in repository execution.
We now avoid the allocation of an Optional instance in the lookup of a dynamic projection in ParameterAccessor. Also, Lazy now exposes a ….getNullable() to be favored over ….getOptional() for hot code paths.

Replaced Stream and Optional usage with for-loops and nullable return values. Reuse parameter names to avoid repeated annotation lookups. Reuse result from Parameters.getBindable(). Introduce ParametersParameterAccessor.getValues() to consistently reuse a single accessor instance allowing access to the unwrapped values. Introduce type cache to QueryExecutionConverters to quickly reject types that do not require wrapping. Avoid recalculation of QueryMethod.isCollectionQuery().
2019-07-25 14:12:11 +02:00
Oliver Drotbohm
e0f2d65d73 DATACMNS-1555 - Support for extracting properties during a PersistentPropertyPath traversal.
PersistentPropertyAccessor now has an overloaded method to pass in a TraversalContext that can be prepared to property handlers for PersistentProperties. During the traversal, the handler is called with the value for the property so that it can e.g. extract list elements, map values etc.
2019-07-22 10:56:07 +02:00
Mark Paluch
704913c866 DATACMNS-1554 - Polishing.
Replace AtTest(expected = …) and ExpectedException with the corresponding AssertJ assertThatExceptionOfType(…) and assertThatIllegalArgumentException().isThrownBy(…).
2019-07-10 11:47:46 +02:00
Mark Paluch
660006b8c9 DATACMNS-1554 - Migrate tests to AssertJ. 2019-07-10 10:32:25 +02:00
Oliver Drotbohm
fa9e5b799a DATACMNS-1552 - Test case to verify Option values are returned as is.
Make sure that the fix for DATACMNS-1524 fixes this ticket as well. A bit of whitespace in QueryExecutionResultHandler.
2019-07-04 12:23:14 +02:00
Oliver Drotbohm
d29fefca5b DATACMNS-1524 - Fix performance regression in QueryExecutionResultHandler.
A side effect of the fix for DATACMNS-1482 trigged source objects that already perfectly match the desired return type would still be subject to detailed inspection of potential conversions, which – by definition – will not kick in.

The code has now been changed to only trigger detailed inspection for collection values.

Related tickets: DATACMNS-1482.
2019-07-02 14:25:08 +02:00
Oliver Drotbohm
736d147446 DATACMNS-1550 - Polishing.
Javadoc wording and formatting.
2019-07-01 15:34:19 +02:00
Jens Schauder
f29756e5f8 DATACMNS-1550 - Added RevisionType to RevisionMetadata. 2019-07-01 15:34:19 +02:00
Mark Paluch
1e98932278 DATACMNS-1545 - Polishing.
Fix dangling callout.

Original pull request: #398.
2019-07-01 15:05:45 +02:00
Christoph Strobl
62f05057ec DATACMNS-1545 - Fix documentation anchors for entity callback API.
Original pull request: #398.
2019-07-01 15:05:40 +02:00