From ffe7c52f28d503196adcf6bdd61736334db4a7a2 Mon Sep 17 00:00:00 2001 From: Michael Reiche <48999328+mikereiche@users.noreply.github.com> Date: Wed, 3 May 2023 15:28:50 -0700 Subject: [PATCH] Pass entity in repository delete(entity) and deleteAll(entities). (#1726) Closes #1725. --- .../repository/support/SimpleCouchbaseRepository.java | 4 ++-- .../CouchbaseRepositoryKeyValueIntegrationTests.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/springframework/data/couchbase/repository/support/SimpleCouchbaseRepository.java b/src/main/java/org/springframework/data/couchbase/repository/support/SimpleCouchbaseRepository.java index 1ee9473b..b8c3b89a 100644 --- a/src/main/java/org/springframework/data/couchbase/repository/support/SimpleCouchbaseRepository.java +++ b/src/main/java/org/springframework/data/couchbase/repository/support/SimpleCouchbaseRepository.java @@ -111,7 +111,7 @@ public class SimpleCouchbaseRepository extends CouchbaseRepositoryBase extends CouchbaseRepositoryBase entities) { Assert.notNull(entities, "The given Iterable of entities must not be null!"); operations.removeById(getJavaType()).inScope(getScope()).inCollection(getCollection()) - .all(Streamable.of(entities).map(this::getId).toList()); + .allEntities((Collection)Streamable.of(entities).toList()); } @Override diff --git a/src/test/java/org/springframework/data/couchbase/repository/CouchbaseRepositoryKeyValueIntegrationTests.java b/src/test/java/org/springframework/data/couchbase/repository/CouchbaseRepositoryKeyValueIntegrationTests.java index 4c31557b..a0a015fd 100644 --- a/src/test/java/org/springframework/data/couchbase/repository/CouchbaseRepositoryKeyValueIntegrationTests.java +++ b/src/test/java/org/springframework/data/couchbase/repository/CouchbaseRepositoryKeyValueIntegrationTests.java @@ -113,7 +113,7 @@ public class CouchbaseRepositoryKeyValueIntegrationTests extends ClusterAwareInt assertThrows(DuplicateKeyException.class, () -> userRepository.save(user)); user.setVersion(saveVersion + 1); assertThrows(OptimisticLockingFailureException.class, () -> userRepository.save(user)); - userRepository.delete(user); + userRepository.deleteById(user.getId()); // Airline does not have a version Airline airline = new Airline(UUID.randomUUID().toString(), "MyAirline", null);