Spring/spring-data-dev-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#145 - Migrate unit tests to JUnit 5 and AssertJ.

Browse Source
This commit is contained in:
Mark Paluch
2020-04-30 15:02:35 +02:00
parent 44517c9680
commit 1a1e0cd07d
42 changed files with 480 additions and 456 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
release-tools/src/main/java/org/springframework/data/release/git/GitCommands.java
View File

@@ -119,10 +119,9 @@ class GitCommands extends TimedCommand {
public void backportChangelogs(@CliOption(key = "", mandatory = true) TrainIteration iteration, //
@CliOption(key = "target") String trains) {
List<Train> targets = trains == null ? Collections.emptyList()
: Stream.of(trains.split(",")).//
map(it -> ReleaseTrains.getTrainByName(it)).//
collect(Collectors.toList());
List<Train> targets = trains == null ? Collections.emptyList() : Stream.of(trains.split(",")).//
map(it -> ReleaseTrains.getTrainByName(it)).//
collect(Collectors.toList());
git.backportChangelogs(iteration, targets);
}

2
release-tools/src/main/java/org/springframework/data/release/issues/Tickets.java
View File

@@ -64,7 +64,7 @@ public class Tickets implements Streamable<Ticket> {
public Ticket getReleaseTicket(ModuleIteration moduleIteration) {
return findReleaseTicket(moduleIteration).orElseThrow(
() -> new IllegalStateException(String.format("Did not find a release ticket for %s!", moduleIteration)));
() -> new IllegalArgumentException(String.format("Did not find a release ticket for %s!", moduleIteration)));
}
public Tickets getIssueTickets(ModuleIteration moduleIteration) {

2
release-tools/src/main/java/org/springframework/data/release/issues/github/GitHub.java
View File

@@ -530,7 +530,7 @@ class GitHub implements IssueTracker {
Optional<Milestone> milestone = findMilestone(moduleIteration, repositoryName);
return milestone
.orElseThrow(() -> new IllegalStateException(String.format("No milestone for %s found containing %s!", //
.orElseThrow(() -> new IllegalArgumentException(String.format("No milestone for %s found containing %s!", //
moduleIteration.getProject().getFullName(), //
moduleIteration.getShortVersionString())));
}