From 4345162361417aa308068f4bb54d6d9b39e1266b Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Mon, 4 Oct 2021 11:53:13 +0200 Subject: [PATCH] Polishing. Extract method for easier reuse. See #194 --- .../data/release/issues/github/GitHub.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/release-tools/src/main/java/org/springframework/data/release/issues/github/GitHub.java b/release-tools/src/main/java/org/springframework/data/release/issues/github/GitHub.java index b96eb5e..5920218 100644 --- a/release-tools/src/main/java/org/springframework/data/release/issues/github/GitHub.java +++ b/release-tools/src/main/java/org/springframework/data/release/issues/github/GitHub.java @@ -25,6 +25,7 @@ import java.util.Map; import java.util.Optional; import java.util.concurrent.atomic.AtomicReference; import java.util.function.Function; +import java.util.function.Predicate; import java.util.stream.Collectors; import java.util.stream.Stream; @@ -383,6 +384,11 @@ public class GitHub extends GitHubSupport implements IssueTracker { } private Optional findMilestone(ModuleIteration moduleIteration, String repositoryName) { + return doFindMilestone(moduleIteration, repositoryName, m -> m.matches(moduleIteration)); + } + + private Optional doFindMilestone(ModuleIteration moduleIteration, String repositoryName, + Predicate milestonePredicate) { AtomicReference milestoneRef = new AtomicReference<>(); @@ -398,7 +404,7 @@ public class GitHub extends GitHubSupport implements IssueTracker { MILESTONES_TYPE, milestones -> { Optional milestone = milestones.stream(). // - filter(m -> m.matches(moduleIteration)). // + filter(milestonePredicate). // findFirst(). // map(m -> { logger.log(moduleIteration, "Found milestone %s.", m);