Spring/spring-data-dev-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#134 - Add fixture values for tests.

Browse Source 
We now specify test properties for Jira and GitHub integrations to prevent a fallback to values from application-local.properties.
This commit is contained in:
Mark Paluch
2019-12-04 10:52:41 +01:00
parent de03b62ee1
commit 876924430b
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
release-tools/src/test/java/org/springframework/data/release/issues/github/GitHubIssueTrackerIntegrationTests.java
View File

@@ -228,7 +228,7 @@ public class GitHubIssueTrackerIntegrationTests extends AbstractIntegrationTests
github.assignReleaseTicketToMe(BUILD_HOPPER_RC1); github.assignReleaseTicketToMe(BUILD_HOPPER_RC1);
verify(patchRequestedFor(urlPathMatching(RELEASE_TICKET_URI)) verify(patchRequestedFor(urlPathMatching(RELEASE_TICKET_URI))
.withRequestBody(equalToJson("{\"assignees\":[\"mp911de\"]}"))); .withRequestBody(equalToJson("{\"assignees\":[\"dummy\"]}")));
} }
/** /**
@@ -249,7 +249,7 @@ public class GitHubIssueTrackerIntegrationTests extends AbstractIntegrationTests
github.closeIteration(BUILD_HOPPER_RC1); github.closeIteration(BUILD_HOPPER_RC1);
verify(patchRequestedFor(urlPathMatching(RELEASE_TICKET_URI)) verify(patchRequestedFor(urlPathMatching(RELEASE_TICKET_URI))
.withRequestBody(equalToJson("{\"state\":\"closed\",\"assignees\":[\"mp911de\"]}"))); .withRequestBody(equalToJson("{\"state\":\"closed\",\"assignees\":[\"dummy\"]}")));
} }
private void mockGetIssueWith(String fromClassPath, int issueId) { private void mockGetIssueWith(String fromClassPath, int issueId) {

5
release-tools/src/test/resources/application-test.properties
View File

@@ -10,4 +10,9 @@ deployment.repository-prefix=test-
jira.username=dummy jira.username=dummy
jira.password=dummy jira.password=dummy
jira.api-url=http://localhost:8888 jira.api-url=http://localhost:8888
git.username=dummy
git.password=dummy
git.email=dummy@dummy.com
git.author=dummy
github.api-url=http://localhost:8888 github.api-url=http://localhost:8888