From 903babe16c1dcb98a0b1078572627511b44e4b6b Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Wed, 21 Mar 2018 15:53:52 +0100 Subject: [PATCH] #71 - Polishing. Fix javadoc, remove superfluous exception declarations. --- .../data/release/cli/ReleaseCommands.java | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/release-tools/src/main/java/org/springframework/data/release/cli/ReleaseCommands.java b/release-tools/src/main/java/org/springframework/data/release/cli/ReleaseCommands.java index 1a54892..d9ac61f 100644 --- a/release-tools/src/main/java/org/springframework/data/release/cli/ReleaseCommands.java +++ b/release-tools/src/main/java/org/springframework/data/release/cli/ReleaseCommands.java @@ -22,8 +22,6 @@ import lombok.NonNull; import lombok.RequiredArgsConstructor; import lombok.experimental.FieldDefaults; -import java.util.List; - import org.springframework.data.release.CliComponent; import org.springframework.data.release.TimedCommand; import org.springframework.data.release.build.BuildOperations; @@ -57,7 +55,7 @@ class ReleaseCommands extends TimedCommand { @NonNull BuildOperations build; @CliCommand("release predict") - public String predictTrainAndIteration() throws Exception { + public String predictTrainAndIteration() { return git.getTags(COMMONS).getLatest().toArtifactVersion().// map(ReleaseCommands::getTrainNameForCommonsVersion).// @@ -66,9 +64,8 @@ class ReleaseCommands extends TimedCommand { /** * Prepares the release of the given iteration of the given train. - * - * @param trainName the name of the release train (ignoring case). - * @param iterationName the name of the iteration. + * + * @param iteration * @throws Exception */ @CliCommand(value = "release prepare", help = "Prepares the release of the iteration of the given train.") @@ -89,7 +86,7 @@ class ReleaseCommands extends TimedCommand { @CliCommand(value = "release build") public void buildRelease(@CliOption(key = "", mandatory = true) TrainIteration iteration, // - @CliOption(key = "project", mandatory = false) String projectName) throws Exception { + @CliOption(key = "project", mandatory = false) String projectName) { if (!iteration.getIteration().isPublic()) { deployment.verifyAuthentication(); @@ -111,7 +108,7 @@ class ReleaseCommands extends TimedCommand { /** * Concludes the release of the given {@link TrainIteration}. - * + * * @param iteration * @throws Exception */ @@ -151,13 +148,12 @@ class ReleaseCommands extends TimedCommand { /** * Triggers the distribution of release artifacts for all projects. - * - * @param trainName - * @param iterationName + * + * @param iteration * @throws Exception */ @CliCommand("release distribute") - public void distribute(@CliOption(key = "", mandatory = true) TrainIteration iteration) throws Exception { + public void distribute(@CliOption(key = "", mandatory = true) TrainIteration iteration) { git.checkout(iteration); build.distributeResources(iteration);