Spring/spring-data-elasticsearch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAES-647: Use terms-query instead of multiple should-queries for In and NotIn.

Browse Source 
Original PR: #315
This commit is contained in:
rasmusfaber
2019-09-09 20:37:57 +02:00
committed by Peter-Josef Meisch
parent 5efe47f868
commit 486a112046
2 changed files with 79 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
src/test/java/org/springframework/data/elasticsearch/repositories/custommethod/CustomMethodRepositoryBaseTests.java
View File

@@ -331,6 +331,68 @@ public abstract class CustomMethodRepositoryBaseTests {
assertThat(page.getContent().get(0).getId()).isEqualTo(documentId2);
}
@Test // DATAES-647
public void shouldHandleManyValuesQueryingIn() {
// given
String documentId1 = randomNumeric(32);
SampleEntity sampleEntity1 = new SampleEntity();
sampleEntity1.setId(documentId1);
sampleEntity1.setKeyword("foo");
repository.save(sampleEntity1);
String documentId2 = randomNumeric(32);
SampleEntity sampleEntity2 = new SampleEntity();
sampleEntity2.setId(documentId2);
sampleEntity2.setKeyword("bar");
repository.save(sampleEntity2);
List<String> keywords = new ArrayList<>();
keywords.add("foo");
for (int i = 0; i < 1025; i++) {
keywords.add(randomNumeric(32));
}
// when
List<SampleEntity> list = repository.findByKeywordIn(keywords);
// then
assertThat(list.size()).isEqualTo(1L);
assertThat(list.get(0).getId()).isEqualTo(documentId1);
}
@Test // DATAES-647
public void shouldHandleManyValuesQueryingNotIn() {
// given
String documentId1 = randomNumeric(32);
SampleEntity sampleEntity1 = new SampleEntity();
sampleEntity1.setId(documentId1);
sampleEntity1.setKeyword("foo");
repository.save(sampleEntity1);
String documentId2 = randomNumeric(32);
SampleEntity sampleEntity2 = new SampleEntity();
sampleEntity2.setId(documentId2);
sampleEntity2.setKeyword("bar");
repository.save(sampleEntity2);
List<String> keywords = new ArrayList<>();
keywords.add("foo");
for (int i = 0; i < 1025; i++) {
keywords.add(randomNumeric(32));
}
// when
List<SampleEntity> list = repository.findByKeywordNotIn(keywords);
// then
assertThat(list.size()).isEqualTo(1L);
assertThat(list.get(0).getId()).isEqualTo(documentId2);
}
@Test
public void shouldExecuteCustomMethodForTrue() {
@@ -1296,6 +1358,7 @@ public abstract class CustomMethodRepositoryBaseTests {
@Id private String id;
@Field(type = Text, store = true, fielddata = true) private String type;
@Field(type = Text, store = true, fielddata = true) private String message;
@Field(type = Keyword) private String keyword;
private int rate;
private boolean available;
private GeoPoint location;
@@ -1337,6 +1400,10 @@ public abstract class CustomMethodRepositoryBaseTests {
Page<SampleEntity> findByIdIn(List<String> ids, Pageable pageable);
List<SampleEntity> findByKeywordIn(List<String> keywords);
List<SampleEntity> findByKeywordNotIn(List<String> keywords);
Page<SampleEntity> findByIdNotIn(List<String> ids, Pageable pageable);
Page<SampleEntity> findByAvailableTrue(Pageable pageable);