From 846dbea2b80eaf07be7660299038bcf4e509e9db Mon Sep 17 00:00:00 2001
From: Peter-Josef Meisch <pj.meisch@sothawo.com>
Date: Mon, 8 Jun 2020 10:13:28 +0200
Subject: [PATCH] DATAES-263 - Inner Hits support.

Original PR: #473
minor fix
---
 .../data/elasticsearch/core/SearchHitMapping.java      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/springframework/data/elasticsearch/core/SearchHitMapping.java b/src/main/java/org/springframework/data/elasticsearch/core/SearchHitMapping.java
index d6a0b393..7a128ae1 100644
--- a/src/main/java/org/springframework/data/elasticsearch/core/SearchHitMapping.java
+++ b/src/main/java/org/springframework/data/elasticsearch/core/SearchHitMapping.java
@@ -178,10 +178,10 @@ class SearchHitMapping<T> {
 			ElasticsearchPersistentEntityWithNestedMetaData persistentEntityWithNestedMetaData = getPersistentEntity(
 					mappingContext.getPersistentEntity(type), nestedMetaData);
 
-			List<SearchHit<Object>> convertedSearchHits = new ArrayList<>();
-
 			if (persistentEntityWithNestedMetaData.entity != null) {
+				List<SearchHit<Object>> convertedSearchHits = new ArrayList<>();
 				Class<?> targetType = persistentEntityWithNestedMetaData.entity.getType();
+
 				// convert the list of SearchHit<SearchDocument> to list of SearchHit<Object>
 				searchHits.getSearchHits().forEach(searchHit -> {
 					SearchDocument searchDocument = searchHit.getContent();
@@ -192,7 +192,7 @@ class SearchHitMapping<T> {
 							searchDocument.getScore(), //
 							searchDocument.getSortValues(), //
 							searchDocument.getHighlightFields(), //
-							mapInnerHits(searchDocument), //
+							searchHit.getInnerHits(), //
 							persistentEntityWithNestedMetaData.nestedMetaData, //
 							targetObject));
 				});
@@ -221,9 +221,9 @@ class SearchHitMapping<T> {
 	 * 
 	 * @param persistentEntity base entity
 	 * @param nestedMetaData nested metadata
-	 * @return The found entity or null
+	 * @return A {@link ElasticsearchPersistentEntityWithNestedMetaData} containing the found entity or null together with
+	 *         the {@link NestedMetaData} that has mapped field names.
 	 */
-	@Nullable
 	private ElasticsearchPersistentEntityWithNestedMetaData getPersistentEntity(
 			@Nullable ElasticsearchPersistentEntity<?> persistentEntity, @Nullable NestedMetaData nestedMetaData) {