From c6c4f0c6bf190cb0c23986d29c2a1100e8150d50 Mon Sep 17 00:00:00 2001 From: Julien Millau Date: Tue, 13 Nov 2018 01:35:13 +0100 Subject: [PATCH] #146 - Avoid executing IN-query with empty parameter list. These queries are illegal in Postgres and possible other databases. Original pull request: #147. --- .../repository/support/EnversRevisionRepositoryImpl.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java b/src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java index d50c44f..8fa5efc 100755 --- a/src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java +++ b/src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java @@ -52,6 +52,7 @@ import org.springframework.util.Assert; * @author Philipp Huegelmeyer * @author Michael Igler * @author Jens Schauder + * @author Julien Millau */ @Transactional(readOnly = true) public class EnversRevisionRepositoryImpl> @@ -150,8 +151,8 @@ public class EnversRevisionRepositoryImpl revisionNumbers.size()) { - return new PageImpl>(Collections.> emptyList(), pageable, 0); + if (revisionNumbers.isEmpty() || pageable.getOffset() > revisionNumbers.size()) { + return Page.empty(pageable); } long upperBound = pageable.getOffset() + pageable.getPageSize();