Spring/spring-data-examples
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#266 - Refactor reactive tests to use StepVerifier and test methods.

Browse Source 
We now use StepVerifier and RxJava's .test() methods instead of .block() calls. Using blocking methods is an anti pattern which should be avoided within tests. Test API comes with timeouts and protects tests from never completing.
This commit is contained in:
Mark Paluch
2017-11-30 18:01:52 -08:00
parent a2f963df14
commit 69c2c2aef4
9 changed files with 189 additions and 237 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
cassandra/reactive/src/test/java/example/springdata/cassandra/people/ReactiveCassandraTemplateIntegrationTest.java
View File

@@ -20,10 +20,10 @@ import static org.assertj.core.api.Assertions.*;
import example.springdata.cassandra.util.CassandraKeyspace;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
import reactor.test.StepVerifier;
import rx.RxReactiveStreams;
import java.util.concurrent.CountDownLatch;
import org.junit.Before;
import org.junit.ClassRule;
import org.junit.Test;
@@ -52,14 +52,14 @@ public class ReactiveCassandraTemplateIntegrationTest {
@Before
public void setUp() {
template.truncate(Person.class) //
Flux<Person> truncateAndInsert = template.truncate(Person.class) //
.thenMany(Flux.just(new Person("Walter", "White", 50), //
new Person("Skyler", "White", 45), //
new Person("Saul", "Goodman", 42), //
new Person("Jesse", "Pinkman", 27))) //
.flatMap(template::insert) //
.then() //
.block();
.flatMap(template::insert);
StepVerifier.create(truncateAndInsert).expectNextCount(4).verifyComplete();
}
/**
@@ -67,22 +67,18 @@ public class ReactiveCassandraTemplateIntegrationTest {
* the two counts ({@code 4} and {@code 6}) to the console.
*/
@Test
public void shouldInsertAndCountData() throws Exception {
public void shouldInsertAndCountData() {
CountDownLatch countDownLatch = new CountDownLatch(1);
template.count(Person.class) //
Mono<Long> saveAndCount = template.count(Person.class) //
.doOnNext(System.out::println) //
.thenMany(Flux.just(new Person("Hank", "Schrader", 43), //
new Person("Mike", "Ehrmantraut", 62)))
.flatMap(template::insert) //
.last() //
.flatMap(v -> template.count(Person.class)) //
.doOnNext(System.out::println) //
.doOnTerminate(countDownLatch::countDown) //
.subscribe();
.doOnNext(System.out::println);
countDownLatch.await();
StepVerifier.create(saveAndCount).expectNext(6L).verifyComplete();
}
/**

67
cassandra/reactive/src/test/java/example/springdata/cassandra/people/ReactivePersonRepositoryIntegrationTest.java
View File

@@ -15,14 +15,10 @@
*/
package example.springdata.cassandra.people;
import static org.assertj.core.api.Assertions.*;
import example.springdata.cassandra.util.CassandraKeyspace;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
import java.util.List;
import java.util.concurrent.CountDownLatch;
import reactor.test.StepVerifier;
import org.junit.Before;
import org.junit.ClassRule;
@@ -51,34 +47,30 @@ public class ReactivePersonRepositoryIntegrationTest {
@Before
public void setUp() {
repository.deleteAll() //
Flux<Person> deleteAndInsert = repository.deleteAll() //
.thenMany(repository.saveAll(Flux.just(new Person("Walter", "White", 50), //
new Person("Skyler", "White", 45), //
new Person("Saul", "Goodman", 42), //
new Person("Jesse", "Pinkman", 27))))
.then() //
.block();
new Person("Jesse", "Pinkman", 27))));
StepVerifier.create(deleteAndInsert).expectNextCount(4).verifyComplete();
}
/**
* This sample performs a count, inserts data and performs a count again using reactive operator chaining.
*/
@Test
public void shouldInsertAndCountData() throws Exception {
public void shouldInsertAndCountData() {
CountDownLatch countDownLatch = new CountDownLatch(1);
repository.count() //
Mono<Long> saveAndCount = repository.count() //
.doOnNext(System.out::println) //
.thenMany(repository.saveAll(Flux.just(new Person("Hank", "Schrader", 43), //
new Person("Mike", "Ehrmantraut", 62)))) //
.last() //
.flatMap(v -> repository.count()) //
.doOnNext(System.out::println) //
.doOnTerminate(countDownLatch::countDown) //
.subscribe();
.doOnNext(System.out::println);
countDownLatch.await();
StepVerifier.create(saveAndCount).expectNext(6L).verifyComplete();
}
/**
@@ -86,17 +78,11 @@ public class ReactivePersonRepositoryIntegrationTest {
* prefetch define the amount of fetched records.
*/
@Test
public void shouldPerformConversionBeforeResultProcessing() throws Exception {
public void shouldPerformConversionBeforeResultProcessing() {
CountDownLatch countDownLatch = new CountDownLatch(1);
repository.findAll() //
.doOnNext(System.out::println) //
.doOnComplete(countDownLatch::countDown) //
.doOnError(throwable -> countDownLatch.countDown()) //
.subscribe();
countDownLatch.await();
StepVerifier.create(repository.findAll().doOnNext(System.out::println)) //
.expectNextCount(4) //
.verifyComplete();
}
/**
@@ -104,12 +90,7 @@ public class ReactivePersonRepositoryIntegrationTest {
*/
@Test
public void shouldQueryDataWithQueryDerivation() {
List<Person> whites = repository.findByLastname("White") //
.collectList() //
.block();
assertThat(whites).hasSize(2);
StepVerifier.create(repository.findByLastname("White")).expectNextCount(2).verifyComplete();
}
/**
@@ -117,11 +98,7 @@ public class ReactivePersonRepositoryIntegrationTest {
*/
@Test
public void shouldQueryDataWithStringQuery() {
Person heisenberg = repository.findByFirstnameInAndLastname("Walter", "White") //
.block();
assertThat(heisenberg).isNotNull();
StepVerifier.create(repository.findByFirstnameInAndLastname("Walter", "White")).expectNextCount(1).verifyComplete();
}
/**
@@ -129,12 +106,7 @@ public class ReactivePersonRepositoryIntegrationTest {
*/
@Test
public void shouldQueryDataWithDeferredQueryDerivation() {
List<Person> whites = repository.findByLastname(Mono.just("White")) //
.collectList() //
.block();
assertThat(whites).hasSize(2);
StepVerifier.create(repository.findByLastname(Mono.just("White"))).expectNextCount(2).verifyComplete();
}
/**
@@ -143,10 +115,9 @@ public class ReactivePersonRepositoryIntegrationTest {
@Test
public void shouldQueryDataWithMixedDeferredQueryDerivation() {
Person heisenberg = repository.findByFirstnameAndLastname(Mono.just("Walter"), "White") //
.block();
assertThat(heisenberg).isNotNull();
StepVerifier.create(repository.findByFirstnameAndLastname(Mono.just("Walter"), "White")) //
.expectNextCount(1) //
.verifyComplete();
}
}

73
cassandra/reactive/src/test/java/example/springdata/cassandra/people/RxJava2PersonRepositoryIntegrationTest.java
View File

@@ -15,16 +15,11 @@
*/
package example.springdata.cassandra.people;
import static org.assertj.core.api.Assertions.*;
import example.springdata.cassandra.util.CassandraKeyspace;
import io.reactivex.Completable;
import io.reactivex.Flowable;
import io.reactivex.Single;
import java.util.List;
import java.util.concurrent.CountDownLatch;
import org.junit.Before;
import org.junit.ClassRule;
import org.junit.Test;
@@ -60,16 +55,16 @@ public class RxJava2PersonRepositoryIntegrationTest {
new Person("Saul", "Goodman", 42), //
new Person("Jesse", "Pinkman", 27)));
deleteAll.andThen(save).blockingLast();
deleteAll.andThen(save).test().await().assertNoErrors();
}
/**
* This sample performs a count, inserts data and performs a count again using reactive operator chaining.
* This sample performs a count, inserts data and performs a count again using reactive operator chaining. It prints
* the two counts ({@code 4} and {@code 6}) to the console.
*/
@Test
public void shouldInsertAndCountData() throws Exception {
public void shouldInsertAndCountData() {
CountDownLatch countDownLatch = new CountDownLatch(1);
repository.count() //
.doOnSuccess(System.out::println) //
@@ -80,10 +75,11 @@ public class RxJava2PersonRepositoryIntegrationTest {
.toSingle() //
.flatMap(v -> repository.count()) //
.doOnSuccess(System.out::println) //
.doAfterTerminate(countDownLatch::countDown) //
.subscribe();
countDownLatch.await();
.test() //
.awaitCount(1) //
.assertValue(6L) //
.assertNoErrors() //
.awaitTerminalEvent();
}
/**
@@ -91,17 +87,14 @@ public class RxJava2PersonRepositoryIntegrationTest {
* prefetch define the amount of fetched records.
*/
@Test
public void shouldPerformConversionBeforeResultProcessing() throws Exception {
CountDownLatch countDownLatch = new CountDownLatch(1);
public void shouldPerformConversionBeforeResultProcessing() {
repository.findAll() //
.doOnNext(System.out::println) //
.doOnEach(it -> countDownLatch.countDown()) //
.doOnError(throwable -> countDownLatch.countDown()) //
.subscribe();
countDownLatch.await();
.test() //
.awaitCount(4) //
.assertNoErrors() //
.awaitTerminalEvent();
}
/**
@@ -110,11 +103,11 @@ public class RxJava2PersonRepositoryIntegrationTest {
@Test
public void shouldQueryDataWithQueryDerivation() {
List<Person> whites = repository.findByLastname("White") //
.toList() //
.blockingGet();
assertThat(whites).hasSize(2);
repository.findByLastname("White") //
.test() //
.awaitCount(2) //
.assertNoErrors() //
.awaitTerminalEvent();
}
/**
@@ -123,10 +116,11 @@ public class RxJava2PersonRepositoryIntegrationTest {
@Test
public void shouldQueryDataWithStringQuery() {
Person heisenberg = repository.findByFirstnameAndLastname("Walter", "White") //
.blockingGet();
assertThat(heisenberg).isNotNull();
repository.findByFirstnameAndLastname("Walter", "White") //
.test() //
.awaitCount(1) //
.assertNoErrors() //
.awaitTerminalEvent();
}
/**
@@ -135,11 +129,11 @@ public class RxJava2PersonRepositoryIntegrationTest {
@Test
public void shouldQueryDataWithDeferredQueryDerivation() {
List<Person> whites = repository.findByLastname(Single.just("White")) //
.toList() //
.blockingGet();
assertThat(whites).hasSize(2);
repository.findByLastname(Single.just("White")) //
.test() //
.awaitCount(2) //
.assertNoErrors() //
.awaitTerminalEvent();
}
/**
@@ -148,9 +142,10 @@ public class RxJava2PersonRepositoryIntegrationTest {
@Test
public void shouldQueryDataWithMixedDeferredQueryDerivation() {
Person heisenberg = repository.findByFirstnameAndLastname(Single.just("Walter"), "White") //
.blockingGet();
assertThat(heisenberg).isNotNull();
repository.findByFirstnameAndLastname(Single.just("Walter"), "White") //
.test() //
.awaitCount(1) //
.assertNoErrors() //
.awaitTerminalEvent();
}
}