From 100366367ea4e83c0aed841f43a09daa50ece7a8 Mon Sep 17 00:00:00 2001
From: John Blum <jblum@vmware.com>
Date: Mon, 27 Sep 2021 13:16:38 -0700
Subject: [PATCH] Configure the maven-javadoc-plugin for the project build, the
 'ci' build profile and the 'distribute' build profile.

Add link to Apache Geode (public) Javadoc site.

Add dependency source excluces on org.apache.geode:geode-gfsh.

Set 'failOnWarnings' to false.

Resolves gh-538.
---
 pom.xml                   | 64 +++++++++++++++++++++++++++++++++++++++
 spring-data-geode/pom.xml |  9 ++----
 2 files changed, 66 insertions(+), 7 deletions(-)

diff --git a/pom.xml b/pom.xml
index a5ef9680..f065e2ba 100644
--- a/pom.xml
+++ b/pom.xml
@@ -54,6 +54,70 @@
 		<spring-shell.version>1.2.0.RELEASE</spring-shell.version>
 	</properties>
 
+	<build>
+		<plugins>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-javadoc-plugin</artifactId>
+				<configuration>
+					<dependencySourceExcludes>
+						<dependencySourceExclude>org.apache.geode:geode-gfsh</dependencySourceExclude>
+					</dependencySourceExcludes>
+					<failOnWarnings>false</failOnWarnings>
+					<links>
+						<link>https://geode.apache.org/releases/latest/javadoc/</link>
+					</links>
+				</configuration>
+			</plugin>
+		</plugins>
+	</build>
+
+	<profiles>
+
+		<profile>
+			<id>ci</id>
+			<build>
+				<plugins>
+					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
+						<artifactId>maven-javadoc-plugin</artifactId>
+						<configuration>
+							<dependencySourceExcludes>
+								<dependencySourceExclude>org.apache.geode:geode-gfsh</dependencySourceExclude>
+							</dependencySourceExcludes>
+							<failOnWarnings>false</failOnWarnings>
+							<links>
+								<link>https://geode.apache.org/releases/latest/javadoc/</link>
+							</links>
+						</configuration>
+					</plugin>
+				</plugins>
+			</build>
+		</profile>
+
+		<profile>
+			<id>distribute</id>
+			<build>
+				<plugins>
+					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
+						<artifactId>maven-javadoc-plugin</artifactId>
+						<configuration>
+							<dependencySourceExcludes>
+								<dependencySourceExclude>org.apache.geode:geode-gfsh</dependencySourceExclude>
+							</dependencySourceExcludes>
+							<failOnWarnings>false</failOnWarnings>
+							<links>
+								<link>https://geode.apache.org/releases/latest/javadoc/</link>
+							</links>
+						</configuration>
+					</plugin>
+				</plugins>
+			</build>
+		</profile>
+
+	</profiles>
+
 	<repositories>
 
 		<repository>
diff --git a/spring-data-geode/pom.xml b/spring-data-geode/pom.xml
index 8dc3ab7e..72cdeac2 100644
--- a/spring-data-geode/pom.xml
+++ b/spring-data-geode/pom.xml
@@ -283,17 +283,11 @@
 					</systemProperties>
 				</configuration>
 			</plugin>
-			<plugin>
-				<groupId>org.apache.maven.plugins</groupId>
-				<artifactId>maven-javadoc-plugin</artifactId>
-				<configuration>
-					<excludePackageNames>org.apache.geode.lang:org.apache.geode.management.internal</excludePackageNames>
-				</configuration>
-			</plugin>
 		</plugins>
 	</build>
 
 	<profiles>
+
 		<profile>
 			<id>local-java17</id>
 			<build>
@@ -343,6 +337,7 @@
 				</plugins>
 			</build>
 		</profile>
+
 	</profiles>
 
 </project>