SGF-216: Fixed bug in FunctionContextInjectingArgumentResolver

This commit is contained in:
David Turanski
2013-11-07 10:24:00 -05:00
parent a602254e21
commit 40c68e4951
2 changed files with 299 additions and 268 deletions

View File

@@ -34,288 +34,313 @@ import com.gemstone.gemfire.cache.execute.ResultSender;
/**
* @author David Turanski
*
*/
public class FunctionArgumentResolverTest {
@Test
public void testDefaultFunctionArgumentResolverSingleArg() {
FunctionArgumentResolver far = new DefaultFunctionArgumentResolver();
@Test
public void testDefaultFunctionArgumentResolverSingleArg() {
FunctionArgumentResolver far = new DefaultFunctionArgumentResolver();
FunctionContext functionContext = mock(FunctionContext.class);
FunctionContext functionContext = mock(FunctionContext.class);
when(functionContext.getArguments()).thenReturn("hello");
when(functionContext.getArguments()).thenReturn("hello");
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] args = far.resolveFunctionArguments(functionContext);
assertEquals(1, args.length);
assertEquals("hello", args[0]);
}
assertEquals(1, args.length);
assertEquals("hello", args[0]);
}
@Test
public void testDefaultFunctionArgumentResolverSingleArgAsArray() {
FunctionArgumentResolver far = new DefaultFunctionArgumentResolver();
@Test
public void testDefaultFunctionArgumentResolverSingleArgAsArray() {
FunctionArgumentResolver far = new DefaultFunctionArgumentResolver();
FunctionContext functionContext = mock(FunctionContext.class);
FunctionContext functionContext = mock(FunctionContext.class);
when(functionContext.getArguments()).thenReturn(new String[] { "hello" });
when(functionContext.getArguments()).thenReturn(new String[]{"hello"});
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] args = far.resolveFunctionArguments(functionContext);
assertEquals(1, args.length);
assertEquals("hello", args[0]);
}
assertEquals(1, args.length);
assertEquals("hello", args[0]);
}
@Test
public void testMethodWithNoSpecialArgs() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@Test
public void testMethodWithNoSpecialArgs() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
Method method = TestFunction.class.getDeclaredMethod("methodWithNoSpecialArgs", String.class, int.class,
boolean.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Method method = TestFunction.class.getDeclaredMethod("methodWithNoSpecialArgs", String.class, int.class,
boolean.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Object[] originalArgs = new Object[] { "hello", 0, false };
when(functionContext.getArguments()).thenReturn(originalArgs);
Object[] originalArgs = new Object[]{"hello", 0, false};
when(functionContext.getArguments()).thenReturn(originalArgs);
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] args = far.resolveFunctionArguments(functionContext);
assertEquals(originalArgs.length, args.length);
assertEquals(originalArgs.length, args.length);
int i = 0;
for (Object arg : args) {
assertSame(originalArgs[i++], arg);
}
int i = 0;
for (Object arg : args) {
assertSame(originalArgs[i++], arg);
}
}
}
@Test
public void testMethodWithRegionType() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@SuppressWarnings("unchecked")
Region<Object, Object> region = mock(Region.class);
@Test
public void testMethodWithRegionType() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@SuppressWarnings("unchecked")
Region<Object, Object> region = mock(Region.class);
Method method = TestFunction.class.getDeclaredMethod("methodWithRegionType", String.class, Region.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Method method = TestFunction.class.getDeclaredMethod("methodWithRegionType", String.class, Region.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Object[] originalArgs = new Object[] { "hello" };
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
Object[] originalArgs = new Object[]{"hello"};
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] args = far.resolveFunctionArguments(functionContext);
assertEquals(originalArgs.length + 1, args.length);
assertEquals(originalArgs.length + 1, args.length);
int i = 0;
for (Object arg : args) {
if (i != 1) {
assertSame(originalArgs[i++], arg);
} else {
assertSame(region, arg);
}
}
int i = 0;
for (Object arg : args) {
if (i != 1) {
assertSame(originalArgs[i++], arg);
} else {
assertSame(region, arg);
}
}
}
}
@Test
public void testMethodWithOneArgRegionType() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@SuppressWarnings("unchecked")
Region<Object, Object> region = mock(Region.class);
@Test
public void testMethodWithOneArgRegionType() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@SuppressWarnings("unchecked")
Region<Object, Object> region = mock(Region.class);
Method method = TestFunction.class.getDeclaredMethod("methodWithOneArgRegionType", Region.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Method method = TestFunction.class.getDeclaredMethod("methodWithOneArgRegionType", Region.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Object[] originalArgs = new Object[] {};
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
Object[] originalArgs = new Object[]{};
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] args = far.resolveFunctionArguments(functionContext);
assertEquals(1, args.length);
assertSame(region, args[0]);
assertEquals(1, args.length);
assertSame(region, args[0]);
}
}
@Test
public void testMethodWithAnnotatedRegion() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@SuppressWarnings("unchecked")
Region<Object, Object> region = mock(Region.class);
@Test
public void testMethodWithAnnotatedRegion() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@SuppressWarnings("unchecked")
Region<Object, Object> region = mock(Region.class);
Method method = TestFunction.class.getDeclaredMethod("methodWithAnnotatedRegion", Region.class, String.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Method method = TestFunction.class.getDeclaredMethod("methodWithAnnotatedRegion", Region.class, String.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Object[] originalArgs = new Object[] { "hello" };
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
Object[] originalArgs = new Object[]{"hello"};
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] args = far.resolveFunctionArguments(functionContext);
assertEquals(2, args.length);
assertSame(region, args[0]);
assertSame(originalArgs[0], args[1]);
assertEquals(2, args.length);
assertSame(region, args[0]);
assertSame(originalArgs[0], args[1]);
}
}
@Test
public void testMethodWithFunctionContext() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@SuppressWarnings("unchecked")
Region<Object, Object> region = mock(Region.class);
@Test
public void testMethodWithFunctionContext() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
@SuppressWarnings("unchecked")
Region<Object, Object> region = mock(Region.class);
Method method = TestFunction.class.getDeclaredMethod("methodWithFunctionContext", Map.class, String.class,
FunctionContext.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Method method = TestFunction.class.getDeclaredMethod("methodWithFunctionContext", Map.class, String.class,
FunctionContext.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Object[] originalArgs = new Object[] { "hello" };
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
Object[] originalArgs = new Object[]{"hello"};
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] args = far.resolveFunctionArguments(functionContext);
assertEquals(3, args.length);
assertSame(region, args[0]);
assertSame(originalArgs[0], args[1]);
assertSame(functionContext, args[2]);
}
@SuppressWarnings({ "unchecked", "rawtypes" })
@Test
public void testMethodWithResultSender () throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
ResultSender resultSender = mock(ResultSender.class);
Region<Object, Object> region = mock(Region.class);
assertEquals(3, args.length);
assertSame(region, args[0]);
assertSame(originalArgs[0], args[1]);
assertSame(functionContext, args[2]);
}
Method method = TestFunction.class.getDeclaredMethod("methodWithResultSender", Map.class, ResultSender.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
@SuppressWarnings({"unchecked", "rawtypes"})
@Test
public void testMethodWithResultSender() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
ResultSender resultSender = mock(ResultSender.class);
Region<Object, Object> region = mock(Region.class);
Object[] originalArgs = new Object[] { };
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
when(functionContext.getResultSender()).thenReturn(resultSender);
Method method = TestFunction.class.getDeclaredMethod("methodWithResultSender", Map.class, ResultSender.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] originalArgs = new Object[]{};
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
when(functionContext.getResultSender()).thenReturn(resultSender);
assertEquals(2, args.length);
assertSame(region, args[0]);
assertSame(resultSender, args[1]);
}
Object[] args = far.resolveFunctionArguments(functionContext);
assertEquals(2, args.length);
assertSame(region, args[0]);
assertSame(resultSender, args[1]);
}
@SuppressWarnings("unchecked")
@Test
public void testMethodWithFilterAndRegion() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
Region<Object, Object> region = mock(Region.class);
Method method = TestFunction.class.getDeclaredMethod("methodWithFilterAndRegion", Map.class, Set.class,
Object.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
@SuppressWarnings("unchecked")
@Test
public void testMethodWithFilterAndRegion() throws SecurityException, NoSuchMethodException {
RegionFunctionContext functionContext = mock(RegionFunctionContext.class);
Region<Object, Object> region = mock(Region.class);
Object[] originalArgs = new Object[] { new Object() };
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
@SuppressWarnings("rawtypes")
Set keys = new HashSet<String>();
when(functionContext.getFilter()).thenReturn(keys);
Method method = TestFunction.class.getDeclaredMethod("methodWithFilterAndRegion", Map.class, Set.class,
Object.class);
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
Object[] args = far.resolveFunctionArguments(functionContext);
Object[] originalArgs = new Object[]{new Object()};
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getDataSet()).thenReturn(region);
@SuppressWarnings("rawtypes")
Set keys = new HashSet<String>();
when(functionContext.getFilter()).thenReturn(keys);
assertEquals(3, args.length);
assertSame(region, args[0]);
assertSame(originalArgs[0], args[2]);
assertSame(keys, args[1]);
}
Object[] args = far.resolveFunctionArguments(functionContext);
@Test
public void testMethodWithMultipleRegionData() throws SecurityException, NoSuchMethodException {
assertEquals(3, args.length);
assertSame(region, args[0]);
assertSame(originalArgs[0], args[2]);
assertSame(keys, args[1]);
}
Method method = TestFunction.class.getDeclaredMethod("methodWithMultipleRegionData", Map.class, Map.class);
@Test
public void testMethodWithMultipleRegionData() throws SecurityException, NoSuchMethodException {
try {
new FunctionContextInjectingArgumentResolver(method);
fail("Should throw exception");
} catch (Exception e) {
Method method = TestFunction.class.getDeclaredMethod("methodWithMultipleRegionData", Map.class, Map.class);
}
try {
new FunctionContextInjectingArgumentResolver(method);
fail("Should throw exception");
} catch (Exception e) {
}
}
@Test
public void testMethodWithMultipleRegions() throws SecurityException, NoSuchMethodException {
}
Method method = TestFunction.class.getDeclaredMethod("methodWithMultipleRegions", Region.class, Map.class);
@Test
public void testMethodWithMultipleRegions() throws SecurityException, NoSuchMethodException {
try {
new FunctionContextInjectingArgumentResolver(method);
fail("Should throw exception");
} catch (Exception e) {
Method method = TestFunction.class.getDeclaredMethod("methodWithMultipleRegions", Region.class, Map.class);
}
}
try {
new FunctionContextInjectingArgumentResolver(method);
fail("Should throw exception");
} catch (Exception e) {
@Test
public void testMethodWithInvalidTypeForAnnotation() throws SecurityException, NoSuchMethodException {
}
}
Method method = TestFunction.class.getDeclaredMethod("methodWithInvalidTypeForAnnotation", Region.class);
@Test
public void testMethodWithInvalidTypeForAnnotation() throws SecurityException, NoSuchMethodException {
try {
new FunctionContextInjectingArgumentResolver(method);
fail("Should throw exception");
} catch (Exception e) {
Method method = TestFunction.class.getDeclaredMethod("methodWithInvalidTypeForAnnotation", Region.class);
}
}
try {
new FunctionContextInjectingArgumentResolver(method);
fail("Should throw exception");
} catch (Exception e) {
@Test
public void testMethodWithMultipleFunctionContext() throws SecurityException, NoSuchMethodException {
}
}
Method method = TestFunction.class.getDeclaredMethod("methodWithMultipleFunctionContext",
FunctionContext.class, FunctionContext.class);
@Test
public void testMethodWithMultipleFunctionContext() throws SecurityException, NoSuchMethodException {
try {
new FunctionContextInjectingArgumentResolver(method);
fail("Should throw exception");
} catch (Exception e) {
Method method = TestFunction.class.getDeclaredMethod("methodWithMultipleFunctionContext",
FunctionContext.class, FunctionContext.class);
}
}
try {
new FunctionContextInjectingArgumentResolver(method);
fail("Should throw exception");
} catch (Exception e) {
static class TestFunction {
public void methodWithNoSpecialArgs(String s1, int i1, boolean b1) {
}
}
}
public void methodWithRegionType(String s1, Region<?, ?> region) {
}
@Test
public void testMethodWithFunctionContextAndResultSender() throws NoSuchMethodException {
public void methodWithOneArgRegionType(Region<?, ?> region) {
}
FunctionContext functionContext = mock(FunctionContext.class);
ResultSender resultSender = mock(ResultSender.class);
Method method = TestFunction.class.getDeclaredMethod("methodWithFunctionContextAndResultSender",
FunctionContext.class, ResultSender.class);
public void methodWithAnnotatedRegion(@RegionData Region<?, ?> data, String s1) {
}
FunctionArgumentResolver far = new FunctionContextInjectingArgumentResolver(method);
public void methodWithFunctionContext(@RegionData Map<?, ?> data, String s1, FunctionContext fc) {
}
public void methodWithResultSender(@RegionData Map<?, ?> data, ResultSender<?> resultSender) {
}
Object[] originalArgs = new Object[]{};
when(functionContext.getArguments()).thenReturn(originalArgs);
when(functionContext.getResultSender()).thenReturn(resultSender);
public void methodWithFilterAndRegion(@RegionData Map<String, Object> region, @Filter Set<String> keys,
Object arg) {
}
Object[] args = far.resolveFunctionArguments(functionContext);
//Invalid Method Signatures
public void methodWithMultipleRegionData(@RegionData Map<?, ?> r1, @RegionData Map<?, ?> r2) {
}
assertEquals(2, args.length);
assertSame(functionContext, args[0]);
assertSame(resultSender, args[1]);
public void methodWithMultipleRegions(Region<?, ?> r1, @RegionData Map<?, ?> r2) {
}
}
public void methodWithInvalidTypeForAnnotation(@Filter Region<?, ?> r1) {
}
static class TestFunction {
public void methodWithNoSpecialArgs(String s1, int i1, boolean b1) {
}
public void methodWithMultipleFunctionContext(FunctionContext fc1, FunctionContext fc2) {
}
public void methodWithRegionType(String s1, Region<?, ?> region) {
}
}
public void methodWithOneArgRegionType(Region<?, ?> region) {
}
public void methodWithAnnotatedRegion(@RegionData Region<?, ?> data, String s1) {
}
public void methodWithFunctionContext(@RegionData Map<?, ?> data, String s1, FunctionContext fc) {
}
public void methodWithResultSender(@RegionData Map<?, ?> data, ResultSender<?> resultSender) {
}
public void methodWithFilterAndRegion(@RegionData Map<String, Object> region, @Filter Set<String> keys,
Object arg) {
}
//Invalid Method Signatures
public void methodWithMultipleRegionData(@RegionData Map<?, ?> r1, @RegionData Map<?, ?> r2) {
}
public void methodWithMultipleRegions(Region<?, ?> r1, @RegionData Map<?, ?> r2) {
}
public void methodWithInvalidTypeForAnnotation(@Filter Region<?, ?> r1) {
}
public void methodWithMultipleFunctionContext(FunctionContext fc1, FunctionContext fc2) {
}
public void methodWithFunctionContextAndResultSender(FunctionContext fc1, ResultSender<?> rs) {
}
}
}