DATAGEODE-180 - Set Framework and Geode log level in tests to error.

Remove out System.out and System.err println(..) statements.
This commit is contained in:
John Blum
2019-04-09 14:27:03 -07:00
parent c1d6a710c0
commit 4358b51f98
126 changed files with 176 additions and 320 deletions

View File

@@ -10,85 +10,71 @@
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*/
package org.springframework.data.gemfire.function.execution;
import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.Map;
import org.apache.geode.cache.execute.Execution;
import org.apache.geode.cache.execute.Function;
import org.springframework.data.gemfire.function.annotation.FunctionId;
import org.springframework.util.Assert;
import org.springframework.util.ReflectionUtils;
/**
* Base class for method level metadata for a function execution interface. This is used at runtime by the
* function execution proxy to create the corresponding Gemfire function {@link Execution}
* Base class for method-level metadata for a {@link Function} {@link Execution} interface.
*
* This is used at runtime by the {@link Function} {@link Execution} proxy to create
* the corresponding {@link Function} {@link Execution}.
*
* @author David Turanski
*
* @author John Blum
* @see org.springframework.data.gemfire.function.execution.MethodMetadata
*/
abstract class FunctionExecutionMethodMetadata<T extends MethodMetadata > {
abstract class FunctionExecutionMethodMetadata<T extends MethodMetadata> {
protected final Map<Method, T> methodMetadata = new HashMap<Method, T>();
private final boolean singletonInterface;
protected final Map<Method, T> methodMetadata = new HashMap<>();
public FunctionExecutionMethodMetadata(final Class<?> serviceInterface) {
public FunctionExecutionMethodMetadata(Class<?> serviceInterface) {
this.singletonInterface = serviceInterface.getMethods().length == 1;
ReflectionUtils.doWithMethods(serviceInterface, method -> {
ReflectionUtils.doWithMethods(serviceInterface, new ReflectionUtils.MethodCallback() {
@Override
public void doWith(Method method) throws IllegalArgumentException, IllegalAccessException {
T mmd = newMetadataInstance(method);
if (mmd.getFunctionId() == null) {
mmd.setFunctionId(method.getName());
}
T methodMetadata = newMetadataInstance(method);
methodMetadata.put(method, mmd);
if (methodMetadata.getFunctionId() == null) {
methodMetadata.setFunctionId(method.getName());
}
this.methodMetadata.put(method, methodMetadata);
});
}
protected abstract T newMetadataInstance(Method method);
T getMethodMetadata(Method method) {
return methodMetadata.get(method);
}
boolean isSingletonInterface() {
return this.singletonInterface;
}
T getSingletonMethodMetada() {
Assert.isTrue(isSingletonInterface(),"this is not a singleton interface.");
return methodMetadata.values().iterator().next();
return this.methodMetadata.get(method);
}
}
class MethodMetadata {
private String functionId;
public MethodMetadata(Method method) {
String annotatedFunctionId = annotatedFunctionId(method);
this.functionId = (annotatedFunctionId == null) ? null : annotatedFunctionId;
}
/**
* @return the functionId
*/
public String getFunctionId() {
return functionId;
FunctionId functionIdAnnotation = method.getAnnotation(FunctionId.class);
if (functionIdAnnotation != null) {
this.functionId = functionIdAnnotation.value();
}
}
public void setFunctionId(String functionId) {
this.functionId = functionId;
}
private String annotatedFunctionId(Method method) {
FunctionId functionIdAnnotation = method.getAnnotation(FunctionId.class);
return (functionIdAnnotation == null) ? null : functionIdAnnotation.value();
public String getFunctionId() {
return this.functionId;
}
}

View File

@@ -18,11 +18,11 @@ import java.util.Set;
import org.springframework.data.gemfire.function.GemfireFunctionUtils;
import org.springframework.data.gemfire.function.annotation.Filter;
/**
* @author David Turanski
*
* @author David Turanski
* @author John Blum
* @see org.springframework.data.gemfire.function.execution.FunctionExecutionMethodMetadata
*/
class OnRegionExecutionMethodMetadata extends FunctionExecutionMethodMetadata<OnRegionMethodMetadata> {
@@ -33,9 +33,6 @@ class OnRegionExecutionMethodMetadata extends FunctionExecutionMethodMetadata<On
super(serviceInterface);
}
/* (non-Javadoc)
* @see org.springframework.data.gemfire.function.config.FunctionExecutionMethodMetadata#newMetadataInstance(java.lang.reflect.Method)
*/
@Override
protected OnRegionMethodMetadata newMetadataInstance(Method method) {
return new OnRegionMethodMetadata(method);
@@ -48,8 +45,11 @@ class OnRegionMethodMetadata extends MethodMetadata {
private final int filterArgPosition;
public OnRegionMethodMetadata(Method method) {
super(method);
this.filterArgPosition = GemfireFunctionUtils.getAnnotationParameterPosition(method, Filter.class, new Class<?>[]{Set.class});
this.filterArgPosition = GemfireFunctionUtils.getAnnotationParameterPosition(method, Filter.class,
new Class<?>[] { Set.class });
}
public int getFilterArgPosition() {