From 4a46ee4c9cb1e41e6bf4528f2b809b68604c6bc6 Mon Sep 17 00:00:00 2001 From: John Blum Date: Fri, 31 Mar 2017 12:25:21 -0700 Subject: [PATCH] SGF-595 - Polish. --- .../data/gemfire/mapping/GemfirePersistentProperty.java | 6 ++++-- .../data/gemfire/mapping/model/GemfireSimpleTypeHolder.java | 3 +-- .../gemfire/mapping/model/GemfireSimpleTypeHolderTest.java | 6 ++---- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/main/java/org/springframework/data/gemfire/mapping/GemfirePersistentProperty.java b/src/main/java/org/springframework/data/gemfire/mapping/GemfirePersistentProperty.java index 08f33975..02c3b9b4 100644 --- a/src/main/java/org/springframework/data/gemfire/mapping/GemfirePersistentProperty.java +++ b/src/main/java/org/springframework/data/gemfire/mapping/GemfirePersistentProperty.java @@ -16,7 +16,7 @@ package org.springframework.data.gemfire.mapping; -import static org.springframework.data.gemfire.util.CollectionUtils.*; +import static org.springframework.data.gemfire.util.CollectionUtils.asSet; import java.util.Set; @@ -32,12 +32,13 @@ import org.springframework.data.mapping.model.SimpleTypeHolder; * {@link PersistentProperty} implementation to for Gemfire related metadata. * * @author Oliver Gierke + * @author John Blum + * @see org.springframework.data.mapping.model.AnnotationBasedPersistentProperty */ public class GemfirePersistentProperty extends AnnotationBasedPersistentProperty { protected static final Set SUPPORTED_IDENTIFIER_NAMES = asSet("id"); - /** * Constructs an instance of {@link GemfirePersistentProperty} initialized with entity persistent property * information (meta-data). @@ -53,6 +54,7 @@ public class GemfirePersistentProperty extends AnnotationBasedPersistentProperty */ public GemfirePersistentProperty(Property property, PersistentEntity owner, SimpleTypeHolder simpleTypeHolder) { + super(property, owner, simpleTypeHolder); } diff --git a/src/main/java/org/springframework/data/gemfire/mapping/model/GemfireSimpleTypeHolder.java b/src/main/java/org/springframework/data/gemfire/mapping/model/GemfireSimpleTypeHolder.java index b38be56c..b1d3860f 100644 --- a/src/main/java/org/springframework/data/gemfire/mapping/model/GemfireSimpleTypeHolder.java +++ b/src/main/java/org/springframework/data/gemfire/mapping/model/GemfireSimpleTypeHolder.java @@ -36,7 +36,7 @@ public class GemfireSimpleTypeHolder extends SimpleTypeHolder { private static final boolean REGISTER_DEFAULTS = true; - protected static final Set> CUSTOM_SIMPLE_TYPES = new HashSet>(2); + protected static final Set> CUSTOM_SIMPLE_TYPES = new HashSet<>(2); static { CUSTOM_SIMPLE_TYPES.add(BigDecimal.class); @@ -63,5 +63,4 @@ public class GemfireSimpleTypeHolder extends SimpleTypeHolder { public GemfireSimpleTypeHolder(SimpleTypeHolder source) { super(CUSTOM_SIMPLE_TYPES, source); } - } diff --git a/src/test/java/org/springframework/data/gemfire/mapping/model/GemfireSimpleTypeHolderTest.java b/src/test/java/org/springframework/data/gemfire/mapping/model/GemfireSimpleTypeHolderTest.java index 48f8ee0e..b713cec0 100644 --- a/src/test/java/org/springframework/data/gemfire/mapping/model/GemfireSimpleTypeHolderTest.java +++ b/src/test/java/org/springframework/data/gemfire/mapping/model/GemfireSimpleTypeHolderTest.java @@ -26,8 +26,7 @@ import org.junit.Test; import org.springframework.data.mapping.model.SimpleTypeHolder; /** - * The GemfireSimpleTypeHolderTest class is a test suite of test cases testing the contract and functionality - * of the GemfireSimpleTypeHolder class. + * Unit tests for {@link GemfireSimpleTypeHolder} class. * * @author John Blum * @see org.junit.Test @@ -50,7 +49,6 @@ public class GemfireSimpleTypeHolderTest { assertThat(holder.isSimpleType(Person.class), is(false)); } - class Person { - } + class Person { } }