From e152b593fa9543939af2c39ace3eb2e1244fbf83 Mon Sep 17 00:00:00 2001 From: John Blum Date: Wed, 8 Jun 2022 17:29:16 -0700 Subject: [PATCH] Remove punctuation from Exception messages. Closes #601. --- .../data/gemfire/IndexFactoryBean.java | 6 +++--- .../data/gemfire/JndiDataSourceType.java | 2 +- .../data/gemfire/config/xml/ParsingUtils.java | 2 +- .../config/xml/PartitionedRegionParser.java | 2 +- .../eviction/EvictionAttributesFactoryBean.java | 2 +- .../DefaultFunctionArgumentResolver.java | 2 +- .../function/PdxFunctionArgumentResolver.java | 2 +- .../function/config/TypeFilterParser.java | 4 ++-- .../adapter/ContinuousQueryListenerAdapter.java | 2 +- .../gemfire/repository/query/Predicates.java | 2 +- .../SpringContextBootstrappingInitializer.java | 2 +- .../transaction/GemfireTransactionManager.java | 8 ++++---- ...gionLookupWithAutowiringIntegrationTests.java | 4 ++-- ...kupWithComponentScanningIntegrationTests.java | 2 +- ...acheClusterConfigurationIntegrationTests.java | 4 ++-- .../CollocatedRegionIntegrationTests.java | 2 +- ...singPropertyPlaceholdersIntegrationTests.java | 2 +- ...GenericRegionFactoryBeanIntegrationTests.java | 4 ++-- .../data/gemfire/IndexFactoryBeanUnitTests.java | 12 ++++++------ ...pPartitionRegionMutationIntegrationTests.java | 16 ++++++++-------- .../LookupRegionMutationIntegrationTests.java | 16 ++++++++-------- .../gemfire/LookupSubRegionIntegrationTests.java | 6 +++--- .../gemfire/PdxDiskStoreIntegrationTests.java | 8 ++++---- .../data/gemfire/PeerRegionFactoryBeanTest.java | 6 +++--- ...egionDataPolicyShortcutsIntegrationTests.java | 16 ++++++++-------- .../gemfire/RegionLookupIntegrationTests.java | 2 +- .../data/gemfire/SubRegionIntegrationTests.java | 4 ++-- .../CachingWithGemFireIntegrationTests.java | 8 ++++---- .../ClientCacheIndexingIntegrationTests.java | 2 +- .../client/ClientSubRegionIntegrationTests.java | 2 +- ...xistWithCacheApplicationIntegrationTests.java | 2 +- .../xml/CacheNamespaceIntegrationTests.java | 2 +- .../ClientRegionNamespaceIntegrationTests.java | 16 ++++++++-------- ...stenerContainerNamespaceIntegrationTests.java | 8 ++++---- ...ceiverAutoStartNamespaceIntegrationTests.java | 2 +- ...verDefaultStartNamespaceIntegrationTests.java | 2 +- ...iverManualStartNamespaceIntegrationTests.java | 2 +- ...emfireV8GatewayNamespaceIntegrationTests.java | 6 +++--- ...rtyPlaceholdersNamespaceIntegrationTests.java | 2 +- .../LocalRegionNamespaceIntegrationTests.java | 12 ++++++------ ...ionPolicyActionNamespaceIntegrationTests.java | 6 +++--- ...rtitionedRegionNamespaceIntegrationTests.java | 10 +++++----- ...itionUsingBeansNamespaceIntegrationTests.java | 4 ++-- ...ationAttributesNamespaceIntegrationTests.java | 6 +++--- ...ptionAttributesNamespaceIntegrationTests.java | 2 +- ...sistenceEvictionSettingsIntegrationTests.java | 8 ++++---- ...eplicatedRegionNamespaceIntegrationTests.java | 10 +++++----- ...egionSubElementNamespaceIntegrationTests.java | 4 ++-- ...ateClientRegionNamespaceIntegrationTests.java | 12 ++++++------ ...PartitionRegionNamespaceIntegrationTests.java | 4 ++-- ...TemplateRegionsNamespaceIntegrationTests.java | 16 ++++++++-------- .../EvictionAttributesFactoryBeanTest.java | 2 +- ...FunctionArgumentResolverIntegrationTests.java | 2 +- .../mapping/MappingPdxSerializerUnitTests.java | 2 +- .../data/gemfire/repository/sample/Account.java | 2 +- .../AlgorithmRepositoryIntegrationTests.java | 4 ++-- .../SubRegionRepositoryIntegrationTests.java | 6 +++--- .../UserRepositoryQueriesIntegrationTests.java | 4 ++-- ...GemfireRepositoryFactoryIntegrationTests.java | 2 +- ...eRepositoryTransactionalIntegrationTests.java | 2 +- .../lucene/LuceneOperationsIntegrationTests.java | 2 +- ...ableSupportFunctionBasedIntegrationTests.java | 4 ++-- ...BootstrappingInitializerIntegrationTests.java | 2 +- ...ContextBootstrappingInitializerUnitTests.java | 2 +- .../data/gemfire/support/sample/TestUserDao.java | 2 +- .../gemfire/support/sample/TestUserService.java | 2 +- ...ctExceptionTransactionalIntegrationTests.java | 2 +- ...emfireTransactionManagerIntegrationTests.java | 4 ++-- ...entQueueAndGatewaySenderIntegrationTests.java | 6 +++--- ...tewayReceiverManualStartIntegrationTests.java | 8 ++++---- 70 files changed, 174 insertions(+), 174 deletions(-) diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/IndexFactoryBean.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/IndexFactoryBean.java index aa3910f2..585bcf2d 100644 --- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/IndexFactoryBean.java +++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/IndexFactoryBean.java @@ -259,7 +259,7 @@ public class IndexFactoryBean extends AbstractFactoryBeanSupport implemen .filter(existingIndex -> isIgnoreIfExists()) .map(existingIndex -> { - logWarning("WARNING! You are choosing to ignore this Index [%1$s] and return the existing" + logWarning("WARNING; You are choosing to ignore this Index [%1$s] and return the existing" + " Index having the same basic definition [%2$s] but with a different name [%3$s];" + " Make sure no OQL Query Hints refer to this Index by name [%1$s]", indexName, toBasicIndexDefinition(), existingIndex.getName()); @@ -273,7 +273,7 @@ public class IndexFactoryBean extends AbstractFactoryBeanSupport implemen .map(existingIndex -> { // Log an informational warning to caution the user about using the override - logWarning("WARNING! You are attempting to 'override' an existing Index [%1$s]" + logWarning("WARNING; You are attempting to 'override' an existing Index [%1$s]" + " having the same basic definition [%2$s] as the Index that will be created" + " by this IndexFactoryBean [%3$s]; 'Override' effectively 'renames' the existing" + " Index [%1$s] by removing it then recreating it under the new name [%3$s] with" @@ -370,7 +370,7 @@ public class IndexFactoryBean extends AbstractFactoryBeanSupport implemen String existingIndexDefinition = String.format(BASIC_INDEX_DEFINITION, existingIndex.getIndexedExpression(), existingIndex.getFromClause(), IndexType.valueOf(existingIndex.getType())); - logWarning("WARNING! %1$s existing Index [%2$s] having a definition [%3$s]" + logWarning("WARNING; %1$s existing Index [%2$s] having a definition [%3$s]" + " that does not match the Index defined [%4$s] by this IndexFactoryBean [%5$s]", action, existingIndex.getName(), existingIndexDefinition, toBasicIndexDefinition(), indexName); } diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/JndiDataSourceType.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/JndiDataSourceType.java index 98e92c6a..62a3449e 100644 --- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/JndiDataSourceType.java +++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/JndiDataSourceType.java @@ -42,7 +42,7 @@ public enum JndiDataSourceType { * @param name the GemFire named JNDI DataSource implementation. */ JndiDataSourceType(final String name) { - Assert.hasText(name, "The JNDI DataSource Type 'name' must be specified!"); + Assert.hasText(name, "The JNDI DataSource Type 'name' must be specified"); this.name = name; } diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/config/xml/ParsingUtils.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/config/xml/ParsingUtils.java index 99f38495..dc39de71 100644 --- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/config/xml/ParsingUtils.java +++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/config/xml/ParsingUtils.java @@ -498,7 +498,7 @@ abstract class ParsingUtils { ? String.format("Attribute [%1$s] of element [%2$s]", attributeName, elementName) : String.format("Element [%s]", elementName); - String message = String.format("%1$s requires VMware Tanzu GemFire version 7 or later. Current version is %2$s.", + String message = String.format("%1$s requires VMware Tanzu GemFire version 7 or later; Current version is %2$s", messagePrefix, GemfireUtils.GEMFIRE_VERSION); parserContext.getReaderContext().error(message, null); diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/config/xml/PartitionedRegionParser.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/config/xml/PartitionedRegionParser.java index 0e99e963..b0cb1bc1 100644 --- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/config/xml/PartitionedRegionParser.java +++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/config/xml/PartitionedRegionParser.java @@ -159,7 +159,7 @@ class PartitionedRegionParser extends AbstractPeerRegionParser { else { String message = - String.format("The Region template [%1$s] must be defined before the Region [%2$s] referring to the template!", + String.format("The Region template [%1$s] must be defined before the Region [%2$s] referring to the template", regionTemplateName, resolveId(element, regionBuilder.getRawBeanDefinition(), parserContext)); parserContext.getReaderContext().error(message, element); diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/eviction/EvictionAttributesFactoryBean.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/eviction/EvictionAttributesFactoryBean.java index eaf22c82..7510763e 100644 --- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/eviction/EvictionAttributesFactoryBean.java +++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/eviction/EvictionAttributesFactoryBean.java @@ -62,7 +62,7 @@ public class EvictionAttributesFactoryBean implements FactoryBean isValidEventHandlerMethodSignature(method, methodName)); Assert.isTrue(!this.methods.isEmpty(), String.format("Cannot find a suitable method named [%1$s#%2$s];" - + " Is the method public and does it have the proper arguments?", + + " Is the method public and does it have the proper arguments", delegateType.getName(), methodName)); } diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/repository/query/Predicates.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/repository/query/Predicates.java index ccc4aac8..60ee7c7f 100644 --- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/repository/query/Predicates.java +++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/repository/query/Predicates.java @@ -200,7 +200,7 @@ class Predicates implements Predicate { case CONTAINING: return "LIKE"; default: - throw new IllegalArgumentException(String.format("Unsupported operator %s!", partType)); + throw new IllegalArgumentException(String.format("Unsupported operator: %s", partType)); } } } diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializer.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializer.java index 9c9e2c0f..51b6ccb2 100644 --- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializer.java +++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializer.java @@ -451,7 +451,7 @@ public class SpringContextBootstrappingInitializer implements ApplicationListene contextConfigLocationsArray))); Assert.state(localApplicationContext.isRunning(), String.format( - "The Spring ApplicationContext (%1$s) failed to be properly initialized with the context config files (%2$s) or base packages (%3$s)!", + "The Spring ApplicationContext (%1$s) failed to be properly initialized with the context config files (%2$s) or base packages (%3$s)", nullSafeGetApplicationContextId(localApplicationContext), Arrays.toString(contextConfigLocationsArray), Arrays.toString(basePackagesArray))); diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/transaction/GemfireTransactionManager.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/transaction/GemfireTransactionManager.java index 8eb4bc16..004bfdb1 100644 --- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/transaction/GemfireTransactionManager.java +++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/transaction/GemfireTransactionManager.java @@ -163,8 +163,8 @@ public class GemfireTransactionManager extends AbstractPlatformTransactionManage } catch (Exception cause) { throw new CannotCreateTransactionException(String.format("%1$s; %2$s", - "An existing, ongoing transaction is already associated with the current thread.", - " Are multiple transaction managers present?"), cause); + "An existing, ongoing transaction is already associated with the current thread;", + " Are multiple transaction managers present"), cause); } } @@ -187,7 +187,7 @@ public class GemfireTransactionManager extends AbstractPlatformTransactionManage } catch (Exception cause) { throw new NoTransactionException( - "No transaction is associated with the current thread. Are multiple transaction managers present?", + "No transaction is associated with the current thread; Are multiple transaction managers present", cause); } } @@ -243,7 +243,7 @@ public class GemfireTransactionManager extends AbstractPlatformTransactionManage catch (Exception cause) { String exceptionMessage = - "No transaction is associated with the current thread. Are multiple transaction managers present?"; + "No transaction is associated with the current thread; Are multiple transaction managers present"; throw new NoTransactionException(exceptionMessage, cause); } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/AutoRegionLookupWithAutowiringIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/AutoRegionLookupWithAutowiringIntegrationTests.java index 21099617..ac007933 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/AutoRegionLookupWithAutowiringIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/AutoRegionLookupWithAutowiringIntegrationTests.java @@ -55,14 +55,14 @@ public class AutoRegionLookupWithAutowiringIntegrationTests extends IntegrationT DataPolicy expectedDataPolicy) { assertThat(region) - .describedAs(String.format("Region (%1$s) was not properly configured and initialized!", expectedName)) + .describedAs(String.format("Region (%1$s) was not properly configured and initialized", expectedName)) .isNotNull(); assertThat(region.getName()).isEqualTo(expectedName); assertThat(region.getFullPath()).isEqualTo(expectedFullPath); assertThat(region.getAttributes()) - .describedAs(String.format("Region (%1$s) must have RegionAttributes defined!", expectedName)) + .describedAs(String.format("Region (%1$s) must have RegionAttributes defined", expectedName)) .isNotNull(); assertThat(region.getAttributes().getDataPolicy()).isEqualTo(expectedDataPolicy); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/AutoRegionLookupWithComponentScanningIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/AutoRegionLookupWithComponentScanningIntegrationTests.java index db8c8057..062f6dd2 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/AutoRegionLookupWithComponentScanningIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/AutoRegionLookupWithComponentScanningIntegrationTests.java @@ -51,7 +51,7 @@ public class AutoRegionLookupWithComponentScanningIntegrationTests extends Integ public void testAutowiredNativeRegions() { assertThat(this.applicationContext.containsBean("autoRegionLookupDao")) - .describedAs("The 'autoRegionLookupDao' Spring bean DAO was not properly configured an initialized!") + .describedAs("The 'autoRegionLookupDao' Spring bean DAO was not properly configured an initialized") .isTrue(); assertThat(this.applicationContext.getBean("autoRegionLookupDao", AutoRegionLookupDao.class)).isNotNull(); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/CacheClusterConfigurationIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/CacheClusterConfigurationIntegrationTests.java index df6ef39e..d7a84c46 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/CacheClusterConfigurationIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/CacheClusterConfigurationIntegrationTests.java @@ -198,7 +198,7 @@ public class CacheClusterConfigurationIntegrationTests extends ForkingClientServ String expectedRegionFullPath) { assertThat(actualRegion) - .describedAs("The [%s] was not properly configured and initialized!", expectedRegionName) + .describedAs("The [%s] was not properly configured and initialized", expectedRegionName) .isNotNull(); assertThat(actualRegion.getName()).isEqualTo(expectedRegionName); @@ -272,7 +272,7 @@ public class CacheClusterConfigurationIntegrationTests extends ForkingClientServ fail("Loading the 'cacheUsingLocalOnlyConfigurationIntegrationTest.xml' Spring ApplicationContext" + " configuration file should have resulted in an Exception due to the Region lookup on" - + " 'ClusterConfigRegion' when GemFire Cluster Configuration is disabled!"); + + " 'ClusterConfigRegion' when GemFire Cluster Configuration is disabled"); } catch (BeanCreationException expected) { diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/CollocatedRegionIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/CollocatedRegionIntegrationTests.java index 324f171c..60bf3b14 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/CollocatedRegionIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/CollocatedRegionIntegrationTests.java @@ -59,7 +59,7 @@ public class CollocatedRegionIntegrationTests extends IntegrationTestsSupport { assertThat(region).isNotNull(); assertThat(region.getName()) - .describedAs("Expected Region with name %1$s; but was %2$s!", expectedRegionName, region.getName()) + .describedAs("Expected Region with name [%1$s]; but was [%2$s]", expectedRegionName, region.getName()) .isEqualTo(expectedRegionName); } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/DiskStoreBeanUsingPropertyPlaceholdersIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/DiskStoreBeanUsingPropertyPlaceholdersIntegrationTests.java index 3be418c8..73e20aad 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/DiskStoreBeanUsingPropertyPlaceholdersIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/DiskStoreBeanUsingPropertyPlaceholdersIntegrationTests.java @@ -75,7 +75,7 @@ public class DiskStoreBeanUsingPropertyPlaceholdersIntegrationTests extends Inte @Test public void testDiskStoreBeanWithPropertyPlaceholderConfiguration() { - assertThat(testDataStore).describedAs("The Disk Store was not configured and initialized!").isNotNull(); + assertThat(testDataStore).describedAs("The Disk Store was not configured and initialized").isNotNull(); assertThat(testDataStore.getAllowForceCompaction()).isEqualTo(getExpectedValue("allowForceCompaction")); assertThat(testDataStore.getAutoCompact()).isEqualTo(getExpectedValue("autoCompact")); assertThat(testDataStore.getCompactionThreshold()).isEqualTo(getExpectedValue("compactionThreshold")); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/GenericRegionFactoryBeanIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/GenericRegionFactoryBeanIntegrationTests.java index e58861f0..e833376d 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/GenericRegionFactoryBeanIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/GenericRegionFactoryBeanIntegrationTests.java @@ -155,10 +155,10 @@ public class GenericRegionFactoryBeanIntegrationTests extends IntegrationTestsSu protected void assertRegionAttributes(Region region, String expectedRegionName, String expectedRegionPath, DataPolicy expectedDataPolicy, Scope expectedScope) { - assertThat(region).as("The GemFire Cache Region must not be null!").isNotNull(); + assertThat(region).as("The GemFire Cache Region must not be null").isNotNull(); assertThat(region.getName()).isEqualTo(expectedRegionName); assertThat(region.getFullPath()).isEqualTo(expectedRegionPath); - assertThat(region.getAttributes()).as("The RegionAttributes must be specified!").isNotNull(); + assertThat(region.getAttributes()).as("The RegionAttributes must be specified").isNotNull(); assertThat(region.getAttributes().getDataPolicy()).isEqualTo(expectedDataPolicy); assertThat(region.getAttributes().getScope()).isEqualTo(expectedScope); } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/IndexFactoryBeanUnitTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/IndexFactoryBeanUnitTests.java index 706abb3c..0a6cc4a8 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/IndexFactoryBeanUnitTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/IndexFactoryBeanUnitTests.java @@ -758,7 +758,7 @@ public class IndexFactoryBeanUnitTests { .createKeyIndex(eq(mockQueryService), eq("TestIndex"), eq("id"), eq("/Example")); verify(mockLogger, times(1)).warn( - eq(String.format("WARNING! You are choosing to ignore this Index [TestIndex] and return the existing Index" + eq(String.format("WARNING; You are choosing to ignore this Index [TestIndex] and return the existing Index" + " having the same basic definition [%s] but with a different name [MockIndex];" + " Make sure no OQL Query Hints refer to this Index by name [TestIndex]", indexFactoryBean.toBasicIndexDefinition()))); @@ -799,7 +799,7 @@ public class IndexFactoryBeanUnitTests { .createKeyIndex(eq(mockQueryService), eq("TestIndex"), eq("id"), eq("/Example")); verify(mockLogger, times(1)).warn( - eq(String.format("WARNING! You are attempting to 'override' an existing Index [MockIndex]" + eq(String.format("WARNING; You are attempting to 'override' an existing Index [MockIndex]" + " having the same basic definition [%s] as the Index that will be created by this" + " IndexFactoryBean [TestIndex]; 'Override' effectively 'renames' the existing Index [MockIndex]" + " by removing it then recreating it under the new name [TestIndex] with the same definition;" @@ -861,7 +861,7 @@ public class IndexFactoryBeanUnitTests { .createKeyIndex(eq(mockQueryService), eq("TestIndex"), eq("id"), eq("/Example")); verify(mockLogger, times(1)).warn( - eq(String.format("WARNING! You are attempting to 'override' an existing Index [MockIndex]" + eq(String.format("WARNING; You are attempting to 'override' an existing Index [MockIndex]" + " having the same basic definition [%s] as the Index that will be created by this" + " IndexFactoryBean [TestIndex]; 'Override' effectively 'renames' the existing Index [MockIndex]" + " by removing it then recreating it under the new name [TestIndex] with the same definition;" @@ -1041,7 +1041,7 @@ public class IndexFactoryBeanUnitTests { eq("/Orders"), eq(null)); verify(mockLogger, times(1)).warn(String.format( - "WARNING! Returning existing Index [TestIndex] having a definition [%1$s] that does not match" + "WARNING; Returning existing Index [TestIndex] having a definition [%1$s] that does not match" + " the Index defined [%2$s] by this IndexFactoryBean [TestIndex]", existingIndexDefinition, indexFactoryBean.toBasicIndexDefinition())); @@ -1127,7 +1127,7 @@ public class IndexFactoryBeanUnitTests { eq("TestIndex"), eq("purchaseDate"), eq("/Orders"), eq(null)); verify(mockLogger, times(1)).warn(eq(String.format( - "WARNING! Overriding existing Index [TestIndex] having a definition [%1$s] that does not match" + "WARNING; Overriding existing Index [TestIndex] having a definition [%1$s] that does not match" + " the Index defined [%2$s] by this IndexFactoryBean [TestIndex]", existingIndexDefinition, indexFactoryBean.toBasicIndexDefinition()))); @@ -1189,7 +1189,7 @@ public class IndexFactoryBeanUnitTests { .createKeyIndex(eq(mockQueryService), eq("MockIndex"), eq("id"), eq("/Example")); verify(mockLogger, times(1)).warn(eq(String.format( - "WARNING! Overriding existing Index [MockIndex] having a definition [%1$s] that does not match" + "WARNING; Overriding existing Index [MockIndex] having a definition [%1$s] that does not match" + " the Index defined [%2$s] by this IndexFactoryBean [MockIndex]", existingIndexDefinition, indexFactoryBean.toBasicIndexDefinition()))); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupPartitionRegionMutationIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupPartitionRegionMutationIntegrationTests.java index f9e8097d..415931b0 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupPartitionRegionMutationIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupPartitionRegionMutationIntegrationTests.java @@ -82,7 +82,7 @@ public class LookupPartitionRegionMutationIntegrationTests extends IntegrationTe Collection expectedCacheListenerNames) { if (!expectedCacheListenerNames.isEmpty()) { - assertNotNull("CacheListeners must not be null!", cacheListeners); + assertNotNull("CacheListeners must not be null", cacheListeners); assertEquals(expectedCacheListenerNames.size(), cacheListeners.length); assertTrue(toStrings(cacheListeners).containsAll(expectedCacheListenerNames)); } @@ -91,7 +91,7 @@ public class LookupPartitionRegionMutationIntegrationTests extends IntegrationTe private void assertEvictionAttributes(EvictionAttributes evictionAttributes, EvictionAction expectedAction, EvictionAlgorithm expectedAlgorithm, int expectedMaximum) { - assertNotNull("EvictionAttributes must not be null!", evictionAttributes); + assertNotNull("EvictionAttributes must not be null", evictionAttributes); assertEquals(expectedAction, evictionAttributes.getAction()); assertEquals(expectedAlgorithm, evictionAttributes.getAlgorithm()); assertEquals(expectedMaximum, evictionAttributes.getMaximum()); @@ -100,7 +100,7 @@ public class LookupPartitionRegionMutationIntegrationTests extends IntegrationTe private void assertExpirationAttributes(ExpirationAttributes expirationAttributes, String description, int expectedTimeout, ExpirationAction expectedAction) { - assertNotNull(String.format("ExpirationAttributes for '%1$s' must not be null!", description), + assertNotNull(String.format("ExpirationAttributes for '%1$s' must not be null", description), expirationAttributes); assertEquals(expectedAction, expirationAttributes.getAction()); assertEquals(expectedTimeout, expirationAttributes.getTimeout()); @@ -116,7 +116,7 @@ public class LookupPartitionRegionMutationIntegrationTests extends IntegrationTe private void assertGemFireComponent(Object gemfireComponent, String expectedName) { - assertNotNull("The GemFire component must not be null!", gemfireComponent); + assertNotNull("The GemFire component must not be null", gemfireComponent); assertEquals(expectedName, gemfireComponent.toString()); } @@ -129,7 +129,7 @@ public class LookupPartitionRegionMutationIntegrationTests extends IntegrationTe private void assertRegionAttributes(Region region, String expectedName, String expectedFullPath, DataPolicy expectedDataPolicy) { - assertNotNull(String.format("'%1$s' Region was not properly initialized!", region)); + assertNotNull(String.format("'%1$s' Region was not properly initialized", region)); assertEquals(expectedName, region.getName()); assertEquals(expectedFullPath, region.getFullPath()); assertNotNull(region.getAttributes()); @@ -205,7 +205,7 @@ public class LookupPartitionRegionMutationIntegrationTests extends IntegrationTe @Override public boolean processEvents(List events) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override @@ -242,7 +242,7 @@ public class LookupPartitionRegionMutationIntegrationTests extends IntegrationTe @Override public V load(LoaderHelper helper) throws CacheLoaderException { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override @@ -276,7 +276,7 @@ public class LookupPartitionRegionMutationIntegrationTests extends IntegrationTe @Override public ExpirationAttributes getExpiry(Region.Entry entry) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupRegionMutationIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupRegionMutationIntegrationTests.java index 4392e7ab..a5afa0b2 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupRegionMutationIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupRegionMutationIntegrationTests.java @@ -81,7 +81,7 @@ public class LookupRegionMutationIntegrationTests extends IntegrationTestsSuppor Collection expectedCacheListenerNames) { if (!expectedCacheListenerNames.isEmpty()) { - assertThat(cacheListeners).as("CacheListeners must not be null!").isNotNull(); + assertThat(cacheListeners).as("CacheListeners must not be null").isNotNull(); assertThat(cacheListeners.length).isEqualTo(expectedCacheListenerNames.size()); assertThat(toStrings(cacheListeners).containsAll(expectedCacheListenerNames)).isTrue(); } @@ -90,7 +90,7 @@ public class LookupRegionMutationIntegrationTests extends IntegrationTestsSuppor private void assertEvictionAttributes(EvictionAttributes evictionAttributes, EvictionAction expectedAction, EvictionAlgorithm expectedAlgorithm, int expectedMaximum) { - assertThat(evictionAttributes).as("EvictionAttributes must not be null!").isNotNull(); + assertThat(evictionAttributes).as("EvictionAttributes must not be null").isNotNull(); assertThat(evictionAttributes.getAction()).isEqualTo(expectedAction); assertThat(evictionAttributes.getAlgorithm()).isEqualTo(expectedAlgorithm); assertThat(evictionAttributes.getMaximum()).isEqualTo(expectedMaximum); @@ -101,7 +101,7 @@ public class LookupRegionMutationIntegrationTests extends IntegrationTestsSuppor String description, int expectedTimeout, ExpirationAction expectedAction) { assertThat(expirationAttributes) - .as(String.format("ExpirationAttributes for '%1$s' must not be null!", description)).isNotNull(); + .as(String.format("ExpirationAttributes for '%1$s' must not be null", description)).isNotNull(); assertThat(expirationAttributes.getAction()).isEqualTo(expectedAction); assertThat(expirationAttributes.getTimeout()).isEqualTo(expectedTimeout); } @@ -116,7 +116,7 @@ public class LookupRegionMutationIntegrationTests extends IntegrationTestsSuppor private void assertGemFireComponent(Object gemfireComponent, String expectedName) { - assertThat(gemfireComponent).as("The GemFire component must not be null!").isNotNull(); + assertThat(gemfireComponent).as("The GemFire component must not be null").isNotNull(); assertThat(gemfireComponent.toString()).isEqualTo(expectedName); } @@ -129,7 +129,7 @@ public class LookupRegionMutationIntegrationTests extends IntegrationTestsSuppor private void assertRegionAttributes(Region region, String expectedName, String expectedFullPath, DataPolicy expectedDataPolicy) { - assertThat(String.format("'%1$s' Region was not properly initialized!", region)).isNotNull(); + assertThat(String.format("'%1$s' Region was not properly initialized", region)).isNotNull(); assertThat(region.getName()).isEqualTo(expectedName); assertThat(region.getFullPath()).isEqualTo(expectedFullPath); assertThat(region.getAttributes()).isNotNull(); @@ -208,7 +208,7 @@ public class LookupRegionMutationIntegrationTests extends IntegrationTestsSuppor @Override public boolean processEvents(List events) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override @@ -245,7 +245,7 @@ public class LookupRegionMutationIntegrationTests extends IntegrationTestsSuppor @Override public V load(LoaderHelper helper) throws CacheLoaderException { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override @@ -279,7 +279,7 @@ public class LookupRegionMutationIntegrationTests extends IntegrationTestsSuppor @Override public ExpirationAttributes getExpiry(Region.Entry entry) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupSubRegionIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupSubRegionIntegrationTests.java index e1dbdccd..bbc8b655 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupSubRegionIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/LookupSubRegionIntegrationTests.java @@ -52,15 +52,15 @@ public class LookupSubRegionIntegrationTests extends IntegrationTestsSupport { private void assertRegionExists(String expectedRegionName, String expectedRegionPath, Region region) { assertThat(region) - .describedAs("The Region with name (%1$s) at path (%2$s) was null!",expectedRegionName, expectedRegionPath) + .describedAs("The Region with name (%1$s) at path (%2$s) was null",expectedRegionName, expectedRegionPath) .isNotNull(); assertThat(region.getName()) - .describedAs("Expected Region name of %1$s; but was %2$s!", expectedRegionName, region.getName()) + .describedAs("Expected Region name of %1$s; but was %2$s", expectedRegionName, region.getName()) .isEqualTo(expectedRegionName); assertThat(region.getFullPath()) - .describedAs("Expected Region path of %1$s; but was %2$s!", expectedRegionPath, region.getFullPath()) + .describedAs("Expected Region path of %1$s; but was %2$s", expectedRegionPath, region.getFullPath()) .isEqualTo(expectedRegionPath); } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/PdxDiskStoreIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/PdxDiskStoreIntegrationTests.java index c8b79d03..2c324505 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/PdxDiskStoreIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/PdxDiskStoreIntegrationTests.java @@ -71,11 +71,11 @@ public class PdxDiskStoreIntegrationTests extends IntegrationTestsSupport { assertThat(region).isNotNull(); assertThat(region.getName()) - .describedAs("Expected Region with name %1$s; but was %2$s!", expectedRegionName, region.getName()) + .describedAs("Expected Region with name %1$s; but was %2$s", expectedRegionName, region.getName()) .isEqualTo(expectedRegionName); assertThat(region.getFullPath()) - .describedAs("Expected Region with path %1$s; but was %2$s!", expectedRegionPath, region.getFullPath()) + .describedAs("Expected Region with path %1$s; but was %2$s", expectedRegionPath, region.getFullPath()) .isEqualTo(expectedRegionPath); } @@ -109,7 +109,7 @@ public class PdxDiskStoreIntegrationTests extends IntegrationTestsSupport { @Before public void setup() { - assertThat(pdxDataRegion).as("The PdxData GemFire Region was not created successfully!").isNotNull(); + assertThat(pdxDataRegion).as("The PdxData GemFire Region was not created successfully").isNotNull(); if (pdxDataRegion.size() == 0) { for (int index = 1; index <= NUMBER_OF_REGION_ENTRIES; index++) { @@ -152,7 +152,7 @@ public class PdxDiskStoreIntegrationTests extends IntegrationTestsSupport { public KeyHolder(T key) { - Assert.notNull(key, "The key cannot be null!"); + Assert.notNull(key, "The key cannot be null"); this.key = key; } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/PeerRegionFactoryBeanTest.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/PeerRegionFactoryBeanTest.java index 0988ede6..0963b567 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/PeerRegionFactoryBeanTest.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/PeerRegionFactoryBeanTest.java @@ -845,7 +845,7 @@ public class PeerRegionFactoryBeanTest extends AbstractRegionFactoryBeanTests { factoryBean.setPersistent(true); factoryBean.resolveDataPolicy(mockRegionFactory, true, "PARTITION"); fail( - "Setting the 'persistent' attribute to TRUE and 'Data Policy' to PARTITION should have thrown an IllegalArgumentException!"); + "Setting the 'persistent' attribute to TRUE and 'Data Policy' to PARTITION should have thrown an IllegalArgumentException"); } catch (IllegalArgumentException expected) { assertThat(expected.getMessage()).isEqualTo("Data Policy [PARTITION] is not valid when persistent is true"); @@ -1033,7 +1033,7 @@ public class PeerRegionFactoryBeanTest extends AbstractRegionFactoryBeanTests { factoryBean.setPersistent(false); factoryBean.resolveDataPolicy(mockRegionFactory, false, DataPolicy.PERSISTENT_REPLICATE); fail( - "Setting the 'persistent' attribute to FALSE and 'Data Policy' to PERSISTENT_REPLICATE should have thrown an IllegalArgumentException!"); + "Setting the 'persistent' attribute to FALSE and 'Data Policy' to PERSISTENT_REPLICATE should have thrown an IllegalArgumentException"); } catch (IllegalArgumentException expected) { assertThat(expected.getMessage()) @@ -1057,7 +1057,7 @@ public class PeerRegionFactoryBeanTest extends AbstractRegionFactoryBeanTests { factoryBean.setPersistent(true); factoryBean.resolveDataPolicy(mockRegionFactory, true, "REPLICATE"); fail( - "Setting the 'persistent' attribute to TRUE and 'Data Policy' to REPLICATE should have thrown an IllegalArgumentException!"); + "Setting the 'persistent' attribute to TRUE and 'Data Policy' to REPLICATE should have thrown an IllegalArgumentException"); } catch (IllegalArgumentException expected) { assertThat(expected.getMessage()).isEqualTo("Data Policy [REPLICATE] is not valid when persistent is true"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/RegionDataPolicyShortcutsIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/RegionDataPolicyShortcutsIntegrationTests.java index 7037ceed..fed100d8 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/RegionDataPolicyShortcutsIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/RegionDataPolicyShortcutsIntegrationTests.java @@ -88,7 +88,7 @@ public class RegionDataPolicyShortcutsIntegrationTests extends IntegrationTestsS public void localRegionWithDataPolicyIsCorrect() { assertThat(localWithDataPolicy) - .describedAs("A reference to the 'LocalWithDataPolicy' Region was not property configured!") + .describedAs("A reference to the 'LocalWithDataPolicy' Region was not property configured") .isNotNull(); assertThat(localWithDataPolicy.getName()).isEqualTo("LocalWithDataPolicy"); @@ -101,7 +101,7 @@ public class RegionDataPolicyShortcutsIntegrationTests extends IntegrationTestsS public void localRegionWithShortcutIsCorrect() { assertThat(localWithShortcut) - .describedAs("A reference to the 'LocalWithShortcut' Region was not property configured!") + .describedAs("A reference to the 'LocalWithShortcut' Region was not property configured") .isNotNull(); assertThat(localWithShortcut.getName()).isEqualTo("LocalWithShortcut"); @@ -114,7 +114,7 @@ public class RegionDataPolicyShortcutsIntegrationTests extends IntegrationTestsS public void partitionRegionWithDataPolicyIsCorrect() { assertThat(partitionWithDataPolicy) - .describedAs("A reference to the 'PartitionWithDataPolicy' Region was not property configured!") + .describedAs("A reference to the 'PartitionWithDataPolicy' Region was not property configured") .isNotNull(); assertThat(partitionWithDataPolicy.getName()).isEqualTo("PartitionWithDataPolicy"); @@ -127,7 +127,7 @@ public class RegionDataPolicyShortcutsIntegrationTests extends IntegrationTestsS public void partitionRegionWithShortcutIsCorrect() { assertThat(partitionWithShortcut) - .describedAs("A reference to the 'PartitionWithShortcut' Region was not property configured!") + .describedAs("A reference to the 'PartitionWithShortcut' Region was not property configured") .isNotNull(); assertThat(partitionWithShortcut.getName()).isEqualTo("PartitionWithShortcut"); @@ -140,7 +140,7 @@ public class RegionDataPolicyShortcutsIntegrationTests extends IntegrationTestsS public void replicateRegionWithDataPolicyIsCorrect() { assertThat(replicateWithDataPolicy) - .describedAs("A reference to the 'ReplicateWithDataPolicy' Region was not property configured!") + .describedAs("A reference to the 'ReplicateWithDataPolicy' Region was not property configured") .isNotNull(); assertThat(replicateWithDataPolicy.getName()).isEqualTo("ReplicateWithDataPolicy"); @@ -153,7 +153,7 @@ public class RegionDataPolicyShortcutsIntegrationTests extends IntegrationTestsS public void replicateRegionWithShortcutIsCorrect() { assertThat(replicateWithShortcut) - .describedAs("A reference to the 'ReplicateWithShortcut' Region was not property configured!") + .describedAs("A reference to the 'ReplicateWithShortcut' Region was not property configured") .isNotNull(); assertThat(replicateWithShortcut.getName()).isEqualTo("ReplicateWithShortcut"); @@ -166,7 +166,7 @@ public class RegionDataPolicyShortcutsIntegrationTests extends IntegrationTestsS public void shortcutDefaultsRegionIsCorrect() { assertThat(shortcutDefaults) - .describedAs("A reference to the 'ShortcutDefaults' Region was not properly configured!") + .describedAs("A reference to the 'ShortcutDefaults' Region was not properly configured") .isNotNull(); assertThat(shortcutDefaults.getName()).isEqualTo("ShortcutDefaults"); @@ -194,7 +194,7 @@ public class RegionDataPolicyShortcutsIntegrationTests extends IntegrationTestsS public void shortcutOverridesRegionIsCorrect() { assertThat(shortcutOverrides) - .describedAs("A reference to the 'ShortcutOverrides' Region was not properly configured!") + .describedAs("A reference to the 'ShortcutOverrides' Region was not properly configured") .isNotNull(); assertThat(shortcutOverrides.getName()).isEqualTo("ShortcutOverrides"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/RegionLookupIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/RegionLookupIntegrationTests.java index 9ba55eda..9338a24a 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/RegionLookupIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/RegionLookupIntegrationTests.java @@ -51,7 +51,7 @@ public class RegionLookupIntegrationTests extends IntegrationTestsSupport { try { applicationContext = newApplicationContext(configLocation); - fail("Spring ApplicationContext should have thrown a BeanCreationException caused by a RegionExistsException!"); + fail("Spring ApplicationContext should have thrown a BeanCreationException caused by a RegionExistsException"); } catch (BeanCreationException expected) { diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/SubRegionIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/SubRegionIntegrationTests.java index b1aa7f1c..f80f5a6b 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/SubRegionIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/SubRegionIntegrationTests.java @@ -69,7 +69,7 @@ public class SubRegionIntegrationTests extends IntegrationTestsSupport { @SuppressWarnings("unchecked") public void testGemFireAccountsSubRegionCreation() { - assertThat(cache).as("The GemFire Cache was not properly initialized!").isNotNull(); + assertThat(cache).as("The GemFire Cache was not properly initialized").isNotNull(); Region customers = cache.getRegion("Customers"); @@ -92,7 +92,7 @@ public class SubRegionIntegrationTests extends IntegrationTestsSupport { @SuppressWarnings("unchecked") public void testSpringSubRegionConfiguration() { - assertThat(accounts).as("The /Customers/Accounts SubRegion was not properly initialized!").isNotNull(); + assertThat(accounts).as("The /Customers/Accounts SubRegion was not properly initialized").isNotNull(); assertThat(accounts.getName()).isEqualTo("Accounts"); assertThat(accounts.getFullPath()).isEqualTo("/Customers/Accounts"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/cache/CachingWithGemFireIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/cache/CachingWithGemFireIntegrationTests.java index 6db341b2..226fa90d 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/cache/CachingWithGemFireIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/cache/CachingWithGemFireIntegrationTests.java @@ -109,13 +109,13 @@ public class CachingWithGemFireIntegrationTests extends IntegrationTestsSupport private NamedNumbersInMemoryRepository namedNumbersRepo; public final void setNamedNumbersRepo(final NamedNumbersInMemoryRepository namedNumbersRepo) { - Assert.notNull(namedNumbersRepo, "The 'NamedNumbers' Repository must not be null!"); + Assert.notNull(namedNumbersRepo, "The 'NamedNumbers' Repository must not be null"); this.namedNumbersRepo = namedNumbersRepo; } protected NamedNumbersInMemoryRepository getNamedNumbersRepo() { Assert.state(namedNumbersRepo != null, - "A reference to the 'NamedNumbers' Repository was not properly configured and initialized!"); + "A reference to the 'NamedNumbers' Repository was not properly configured and initialized"); return namedNumbersRepo; } @@ -141,12 +141,12 @@ public class CachingWithGemFireIntegrationTests extends IntegrationTestsSupport } public final void setNamedNumbers(final Map namedNumbers) { - Assert.notNull(namedNumbers, "The reference to the 'NamedNumbers' Map must not be null!"); + Assert.notNull(namedNumbers, "The reference to the 'NamedNumbers' Map must not be null"); this.namedNumbers = namedNumbers; } protected Map getNamedNumbers() { - Assert.state(namedNumbers != null, "The 'NamedNumbers' Map was not properly configured and initialized!"); + Assert.state(namedNumbers != null, "The 'NamedNumbers' Map was not properly configured and initialized"); return namedNumbers; } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/client/ClientCacheIndexingIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/client/ClientCacheIndexingIntegrationTests.java index c74afae1..6203324f 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/client/ClientCacheIndexingIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/client/ClientCacheIndexingIntegrationTests.java @@ -86,7 +86,7 @@ public class ClientCacheIndexingIntegrationTests extends ForkingClientServerInte public void testIndexByName() { assertThat(clientCache) - .describedAs("The GemFire ClientCache was not properly configured and initialized!") + .describedAs("The GemFire ClientCache was not properly configured and initialized") .isNotNull(); Index actualIndex = getIndex(clientCache, "ExampleIndex"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/client/ClientSubRegionIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/client/ClientSubRegionIntegrationTests.java index a5f1c367..5578e1ae 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/client/ClientSubRegionIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/client/ClientSubRegionIntegrationTests.java @@ -89,7 +89,7 @@ public class ClientSubRegionIntegrationTests extends ForkingClientServerIntegrat public void gemFireSubRegionCreationConfigurationIsCorrect() { assertThat(this.clientCache) - .describedAs("The Client Cache was not properly initialized!") + .describedAs("The Client Cache was not properly initialized") .isNotNull(); Region parent = this.clientCache.getRegion("Parent"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/annotation/LocatorApplicationCannotCoexistWithCacheApplicationIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/annotation/LocatorApplicationCannotCoexistWithCacheApplicationIntegrationTests.java index 1a9ada3f..85a03101 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/annotation/LocatorApplicationCannotCoexistWithCacheApplicationIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/annotation/LocatorApplicationCannotCoexistWithCacheApplicationIntegrationTests.java @@ -63,7 +63,7 @@ public class LocatorApplicationCannotCoexistWithCacheApplicationIntegrationTests getBean(GemFireCache.class); getBean(Locator.class); - fail("Caches and Locators cannot coexist!"); + fail("Caches and Locators cannot coexist"); } catch (BeanDefinitionStoreException expected) { diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/CacheNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/CacheNamespaceIntegrationTests.java index 6d3e31af..6ba32fbd 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/CacheNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/CacheNamespaceIntegrationTests.java @@ -274,7 +274,7 @@ public class CacheNamespaceIntegrationTests extends IntegrationTestsSupport { @Override public void onEvent(TimestampedEntryEvent event, GatewayConflictHelper helper) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } } } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ClientRegionNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ClientRegionNamespaceIntegrationTests.java index 9abbf083..f4b31909 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ClientRegionNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ClientRegionNamespaceIntegrationTests.java @@ -109,7 +109,7 @@ public class ClientRegionNamespaceIntegrationTests extends IntegrationTestsSuppo Region simple = requireApplicationContext().getBean("simple", Region.class); - assertThat(simple).as("The 'SimpleRegion' Client Region was not properly configured and initialized!") + assertThat(simple).as("The 'SimpleRegion' Client Region was not properly configured and initialized") .isNotNull(); assertThat(simple.getName()).isEqualTo("SimpleRegion"); assertThat(simple.getFullPath()).isEqualTo(Region.SEPARATOR + "SimpleRegion"); @@ -171,7 +171,7 @@ public class ClientRegionNamespaceIntegrationTests extends IntegrationTestsSuppo Region persistent = requireApplicationContext().getBean("persistent", Region.class); assertThat(persistent) - .describedAs("The 'PersistentRegion' Region was not properly configured and initialized!") + .describedAs("The 'PersistentRegion' Region was not properly configured and initialized") .isNotNull(); assertThat(persistent.getName()).isEqualTo("PersistentRegion"); @@ -234,7 +234,7 @@ public class ClientRegionNamespaceIntegrationTests extends IntegrationTestsSuppo Region compressed = requireApplicationContext().getBean("Compressed", Region.class); - assertThat(compressed).as("The 'Compressed' Client Region was not properly configured and initialized!") + assertThat(compressed).as("The 'Compressed' Client Region was not properly configured and initialized") .isNotNull(); assertThat(compressed.getName()).isEqualTo("Compressed"); assertThat(compressed.getFullPath()).isEqualTo(Region.SEPARATOR + "Compressed"); @@ -242,7 +242,7 @@ public class ClientRegionNamespaceIntegrationTests extends IntegrationTestsSuppo assertThat(compressed.getAttributes().getDataPolicy()).isEqualTo(DataPolicy.EMPTY); assertThat(compressed.getAttributes().getPoolName()).isEqualTo("gemfire-pool"); assertThat(compressed.getAttributes().getCompressor() instanceof TestCompressor) - .describedAs(String.format("Expected 'TestCompressor'; but was '%s'!", + .describedAs(String.format("Expected 'TestCompressor'; but was '%s'", ObjectUtils.nullSafeClassName(compressed.getAttributes().getCompressor()))) .isTrue(); assertThat(compressed.getAttributes().getCompressor().toString()).isEqualTo("STD"); @@ -258,7 +258,7 @@ public class ClientRegionNamespaceIntegrationTests extends IntegrationTestsSuppo requireApplicationContext().getBean("client-with-attributes", Region.class); assertThat(clientRegion) - .describedAs("The 'client-with-attributes' Client Region was not properly configured and initialized!") + .describedAs("The 'client-with-attributes' Client Region was not properly configured and initialized") .isNotNull(); assertThat(clientRegion.getName()).isEqualTo("client-with-attributes"); @@ -311,7 +311,7 @@ public class ClientRegionNamespaceIntegrationTests extends IntegrationTestsSuppo @Override public Object load(final LoaderHelper helper) throws CacheLoaderException { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override @@ -331,12 +331,12 @@ public class ClientRegionNamespaceIntegrationTests extends IntegrationTestsSuppo @Override public byte[] compress(final byte[] input) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override public byte[] decompress(final byte[] input) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ContinuousQueryListenerContainerNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ContinuousQueryListenerContainerNamespaceIntegrationTests.java index 3b356312..8605a01a 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ContinuousQueryListenerContainerNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ContinuousQueryListenerContainerNamespaceIntegrationTests.java @@ -86,11 +86,11 @@ public class ContinuousQueryListenerContainerNamespaceIntegrationTests @Test public void testContainerConfiguration() throws Exception { - assertThat(container).as("The ContinuousQueryListenerContainer was not properly configured!").isNotNull(); - assertThat(container.isActive()).as("The CQ Listener Container should be active (initialized)!").isTrue(); - assertThat(container.isAutoStartup()).as("The CQ Listener container should not be configured to auto-start!") + assertThat(container).as("The ContinuousQueryListenerContainer was not properly configured").isNotNull(); + assertThat(container.isActive()).as("The CQ Listener Container should be active (initialized)").isTrue(); + assertThat(container.isAutoStartup()).as("The CQ Listener container should not be configured to auto-start") .isFalse(); - assertThat(container.isRunning()).as("The CQ Listener Container should not be running!").isFalse(); + assertThat(container.isRunning()).as("The CQ Listener Container should not be running").isFalse(); assertThat(container.getPhase()).isEqualTo(4); assertThat(testErrorHandler).isNotNull(); assertThat(TestUtils.readField("errorHandler", container)).isSameAs(testErrorHandler); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverAutoStartNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverAutoStartNamespaceIntegrationTests.java index 474bb6ea..3cce9136 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverAutoStartNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverAutoStartNamespaceIntegrationTests.java @@ -64,7 +64,7 @@ public class GatewayReceiverAutoStartNamespaceIntegrationTests extends Integrati public void testAuto() throws Exception { assertThat(this.autoGatewayReceiverFactory) - .describedAs("The 'Auto' GatewayReceiverFactoryBean was not properly configured and initialized!") + .describedAs("The 'Auto' GatewayReceiverFactoryBean was not properly configured and initialized") .isNotNull(); GatewayReceiver autoGatewayReceiver = this.autoGatewayReceiverFactory.getObject(); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverDefaultStartNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverDefaultStartNamespaceIntegrationTests.java index 6b0636b1..2596f843 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverDefaultStartNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverDefaultStartNamespaceIntegrationTests.java @@ -64,7 +64,7 @@ public class GatewayReceiverDefaultStartNamespaceIntegrationTests extends Integr public void testDefault() throws Exception { assertThat(this.defaultGatewayReceiverFactory) - .describedAs("The 'Default' GatewayReceiverFactoryBean was not properly configured and initialized!") + .describedAs("The 'Default' GatewayReceiverFactoryBean was not properly configured and initialized") .isNotNull(); GatewayReceiver defaultGatewayReceiver = this.defaultGatewayReceiverFactory.getObject(); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverManualStartNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverManualStartNamespaceIntegrationTests.java index d057bd66..b37fbf09 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverManualStartNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GatewayReceiverManualStartNamespaceIntegrationTests.java @@ -63,7 +63,7 @@ public class GatewayReceiverManualStartNamespaceIntegrationTests extends Integra public void testManual() throws Exception { assertThat(this.manualGatewayReceiverFactory) - .describedAs("The 'Manual' GatewayReceiverFactoryBean was not properly configured and initialized!") + .describedAs("The 'Manual' GatewayReceiverFactoryBean was not properly configured and initialized") .isNotNull(); GatewayReceiver manualGatewayReceiver = this.manualGatewayReceiverFactory.getObject(); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GemfireV8GatewayNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GemfireV8GatewayNamespaceIntegrationTests.java index 6313144f..5ef8aa40 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GemfireV8GatewayNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/GemfireV8GatewayNamespaceIntegrationTests.java @@ -64,7 +64,7 @@ public class GemfireV8GatewayNamespaceIntegrationTests extends IntegrationTestsS public void testGatewaySenderEventSubstitutionFilter() { assertThat(gatewaySenderWithEventSubstitutionFilter) - .describedAs("The 'gatewaySenderEventSubtitutionFilter' bean was not properly configured and initialized!") + .describedAs("The 'gatewaySenderEventSubtitutionFilter' bean was not properly configured and initialized") .isNotNull(); assertThat(gatewaySenderWithEventSubstitutionFilter.getId()).isEqualTo("gateway-sender-with-event-substitution-filter"); @@ -81,7 +81,7 @@ public class GemfireV8GatewayNamespaceIntegrationTests extends IntegrationTestsS public void testGatewaySenderEventSubstitutionFilterRef() { assertThat(gatewaySenderWithEventSubstitutionFilterRef) - .describedAs("The 'gatewaySenderEventSubtitutionFilter' bean was not properly configured and initialized!") + .describedAs("The 'gatewaySenderEventSubtitutionFilter' bean was not properly configured and initialized") .isNotNull(); assertThat(gatewaySenderWithEventSubstitutionFilterRef.getId()).isEqualTo("gateway-sender-with-event-substitution-filter-ref"); @@ -108,7 +108,7 @@ public class GemfireV8GatewayNamespaceIntegrationTests extends IntegrationTestsS @Override public Object getSubstituteValue(EntryEvent objectObjectEntryEvent) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/JndiBindingsWithPropertyPlaceholdersNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/JndiBindingsWithPropertyPlaceholdersNamespaceIntegrationTests.java index 9ee7f814..329755d5 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/JndiBindingsWithPropertyPlaceholdersNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/JndiBindingsWithPropertyPlaceholdersNamespaceIntegrationTests.java @@ -58,7 +58,7 @@ public class JndiBindingsWithPropertyPlaceholdersNamespaceIntegrationTests exten } } - fail("ConfigProperty with name [%1$s] was not found!", expectedPropertyName); + fail("ConfigProperty with name [%1$s] was not found", expectedPropertyName); } @Test diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/LocalRegionNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/LocalRegionNamespaceIntegrationTests.java index 9b12654b..e345497f 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/LocalRegionNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/LocalRegionNamespaceIntegrationTests.java @@ -72,7 +72,7 @@ public class LocalRegionNamespaceIntegrationTests extends IntegrationTestsSuppor Region simple = applicationContext.getBean("simple", Region.class); assertThat(simple) - .describedAs("The 'simple' Region was not properly configured or initialized!") + .describedAs("The 'simple' Region was not properly configured or initialized") .isNotNull(); assertThat(simple.getName()).isEqualTo("simple"); @@ -132,7 +132,7 @@ public class LocalRegionNamespaceIntegrationTests extends IntegrationTestsSuppor Region region = applicationContext.getBean("local-with-attributes", Region.class); assertThat(region) - .describedAs("The 'local-with-attributes' Region was not properly configured and initialized!") + .describedAs("The 'local-with-attributes' Region was not properly configured and initialized") .isNotNull(); assertThat(region.getName()).isEqualTo("local-with-attributes"); @@ -174,7 +174,7 @@ public class LocalRegionNamespaceIntegrationTests extends IntegrationTestsSuppor Region persistentLocalRegion = applicationContext.getBean("persistent", Region.class); assertThat(persistentLocalRegion) - .describedAs("The 'persistent' Local Region was not properly configured and initialized!") + .describedAs("The 'persistent' Local Region was not properly configured and initialized") .isNotNull(); assertThat(persistentLocalRegion.getName()).isEqualTo("persistent"); @@ -193,7 +193,7 @@ public class LocalRegionNamespaceIntegrationTests extends IntegrationTestsSuppor Region compressed = applicationContext.getBean("Compressed", Region.class); - assertThat(compressed).as("The 'Compressed' Local Region was not properly configured and initialized!") + assertThat(compressed).as("The 'Compressed' Local Region was not properly configured and initialized") .isNotNull(); assertThat(compressed.getName()).isEqualTo("Compressed"); assertThat(compressed.getFullPath()).isEqualTo(Region.SEPARATOR + "Compressed"); @@ -214,12 +214,12 @@ public class LocalRegionNamespaceIntegrationTests extends IntegrationTestsSuppor @Override public byte[] compress(byte[] input) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override public byte[] decompress(byte[] input) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/LocalRegionWithEvictionPolicyActionNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/LocalRegionWithEvictionPolicyActionNamespaceIntegrationTests.java index 04e64363..dcaab528 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/LocalRegionWithEvictionPolicyActionNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/LocalRegionWithEvictionPolicyActionNamespaceIntegrationTests.java @@ -65,7 +65,7 @@ public class LocalRegionWithEvictionPolicyActionNamespaceIntegrationTests extend @Test public void testLocalRegionConfigurationWithEvictionPolicyActionSetToLocalDestroy() { - assertThat(localDestroyRegion).as("The 'LocalDestroy' Region was not properly configured and initialized!") + assertThat(localDestroyRegion).as("The 'LocalDestroy' Region was not properly configured and initialized") .isNotNull(); assertThat(localDestroyRegion.getName()).isEqualTo("LocalDestroy"); assertThat(localDestroyRegion.getFullPath()).isEqualTo("/LocalDestroy"); @@ -80,7 +80,7 @@ public class LocalRegionWithEvictionPolicyActionNamespaceIntegrationTests extend @Test public void testLocalRegionConfigurationWithEvictionPolicyActionSetToNone() { - assertThat(noneRegion).as("The 'None' Region was not properly configured and initialized!").isNotNull(); + assertThat(noneRegion).as("The 'None' Region was not properly configured and initialized").isNotNull(); assertThat(noneRegion.getName()).isEqualTo("None"); assertThat(noneRegion.getFullPath()).isEqualTo("/None"); assertThat(noneRegion.getAttributes()).isNotNull(); @@ -93,7 +93,7 @@ public class LocalRegionWithEvictionPolicyActionNamespaceIntegrationTests extend @Test public void testLocalRegionConfigurationWithEvictionPolicyActionSetToOverflowToDisk() { - assertThat(overflowRegion).as("The 'Overflow' Region was not properly configured and initialized!").isNotNull(); + assertThat(overflowRegion).as("The 'Overflow' Region was not properly configured and initialized").isNotNull(); assertThat(overflowRegion.getName()).isEqualTo("Overflow"); assertThat(overflowRegion.getFullPath()).isEqualTo("/Overflow"); assertThat(overflowRegion.getAttributes()).isNotNull(); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/PartitionedRegionNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/PartitionedRegionNamespaceIntegrationTests.java index b7332386..0cf635e4 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/PartitionedRegionNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/PartitionedRegionNamespaceIntegrationTests.java @@ -157,7 +157,7 @@ public class PartitionedRegionNamespaceIntegrationTests extends IntegrationTests Region compressed = requireApplicationContext().getBean("compressed", Region.class); assertThat(compressed) - .describedAs("The 'compressed' PARTITION Region was not properly configured and initialized!") + .describedAs("The 'compressed' PARTITION Region was not properly configured and initialized") .isNotNull(); assertThat(compressed.getName()).isEqualTo("compressed"); @@ -203,7 +203,7 @@ public class PartitionedRegionNamespaceIntegrationTests extends IntegrationTests Region listeners = requireApplicationContext().getBean("listeners", Region.class); assertThat(listeners) - .describedAs("The 'listeners' PARTITION Region was not properly configured and initialized!") + .describedAs("The 'listeners' PARTITION Region was not properly configured and initialized") .isNotNull(); assertThat(listeners.getName()).isEqualTo("listeners"); @@ -233,7 +233,7 @@ public class PartitionedRegionNamespaceIntegrationTests extends IntegrationTests Region listeners = requireApplicationContext().getBean("listenerRef", Region.class); assertThat(listeners) - .describedAs("The 'listenerRef' PARTITION Region was not properly configured and initialized!") + .describedAs("The 'listenerRef' PARTITION Region was not properly configured and initialized") .isNotNull(); assertThat(listeners.getName()).isEqualTo("listenerRef"); @@ -260,12 +260,12 @@ public class PartitionedRegionNamespaceIntegrationTests extends IntegrationTests @Override public byte[] compress(final byte[] input) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override public byte[] decompress(final byte[] input) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionDefinitionUsingBeansNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionDefinitionUsingBeansNamespaceIntegrationTests.java index fc92a2be..21c1de31 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionDefinitionUsingBeansNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionDefinitionUsingBeansNamespaceIntegrationTests.java @@ -71,7 +71,7 @@ public class RegionDefinitionUsingBeansNamespaceIntegrationTests extends Integra @Test public void testExampleRegionBeanDefinitionConfiguration() { - assertThat(example).as("The '/Example' Region was not properly configured and initialized!").isNotNull(); + assertThat(example).as("The '/Example' Region was not properly configured and initialized").isNotNull(); assertThat(example.getName()).isEqualTo("Example"); assertThat(example.getFullPath()).isEqualTo("/Example"); assertThat(example.getAttributes()).isNotNull(); @@ -107,7 +107,7 @@ public class RegionDefinitionUsingBeansNamespaceIntegrationTests extends Integra @Test public void testAnotherExampleRegionDefinitionConfiguration() { - assertThat(anotherExample).as("The '/AnotherExample' Region was not properly configured and initialized!") + assertThat(anotherExample).as("The '/AnotherExample' Region was not properly configured and initialized") .isNotNull(); assertThat(anotherExample.getName()).isEqualTo("AnotherExample"); assertThat(anotherExample.getFullPath()).isEqualTo("/AnotherExample"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionExpirationAttributesNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionExpirationAttributesNamespaceIntegrationTests.java index 9bfe71af..4e7d9d6d 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionExpirationAttributesNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionExpirationAttributesNamespaceIntegrationTests.java @@ -77,7 +77,7 @@ public class RegionExpirationAttributesNamespaceIntegrationTests extends Integra DataPolicy dataPolicy) { assertThat(region) - .as(String.format("The '%1$s' Region was not properly configured and initialized!", regionName)) + .as(String.format("The '%1$s' Region was not properly configured and initialized", regionName)) .isNotNull(); assertThat(region.getName()).isEqualTo(regionName); assertThat(region.getFullPath()).isEqualTo(regionFullPath); @@ -167,8 +167,8 @@ public class RegionExpirationAttributesNamespaceIntegrationTests extends Integra @Override public ExpirationAttributes getExpiry(final Region.Entry kvEntry) { - Assert.state(timeout != null, "The expiration 'timeout' must be specified!"); - Assert.state(action != null, "The expiration 'action' must be specified!"); + Assert.state(timeout != null, "The expiration 'timeout' must be specified"); + Assert.state(action != null, "The expiration 'action' must be specified"); return new ExpirationAttributes(timeout, action); } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionSubscriptionAttributesNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionSubscriptionAttributesNamespaceIntegrationTests.java index a0ef473d..4807f700 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionSubscriptionAttributesNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionSubscriptionAttributesNamespaceIntegrationTests.java @@ -71,7 +71,7 @@ public class RegionSubscriptionAttributesNamespaceIntegrationTests extends Integ private void assertSubscription(Region region, String expectedRegionName, DataPolicy expectedDataPolicy, InterestPolicy expectedInterestedPolicy) { - assertThat(region).describedAs(String.format("The '%1$s' Region was not properly configured an initialized!", expectedRegionName)).isNotNull(); + assertThat(region).describedAs(String.format("The '%1$s' Region was not properly configured an initialized", expectedRegionName)).isNotNull(); assertThat(region.getName()).isEqualTo(expectedRegionName); assertThat(region.getAttributes()).isNotNull(); assertThat(region.getAttributes().getDataPolicy()).isEqualTo(expectedDataPolicy); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionsWithDiskStoreAndPersistenceEvictionSettingsIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionsWithDiskStoreAndPersistenceEvictionSettingsIntegrationTests.java index d406334f..9a4605b0 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionsWithDiskStoreAndPersistenceEvictionSettingsIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/RegionsWithDiskStoreAndPersistenceEvictionSettingsIntegrationTests.java @@ -69,7 +69,7 @@ public class RegionsWithDiskStoreAndPersistenceEvictionSettingsIntegrationTests public void testNotPersistentNoOverflowRegion() { assertThat(notPersistentNoOverflowRegion) - .describedAs("The Not Persistent, No Overflow Region was not properly configured and initialized!") + .describedAs("The Not Persistent, No Overflow Region was not properly configured and initialized") .isNotNull(); assertThat(notPersistentNoOverflowRegion.getAttributes()).isNotNull(); @@ -83,7 +83,7 @@ public class RegionsWithDiskStoreAndPersistenceEvictionSettingsIntegrationTests public void testNotPersistentOverflowRegion() { assertThat(notPersistentOverflowRegion) - .describedAs("The Not Persistent, Overflow Region was not properly configured and initialized!") + .describedAs("The Not Persistent, Overflow Region was not properly configured and initialized") .isNotNull(); assertThat(notPersistentOverflowRegion.getAttributes()).isNotNull(); @@ -97,7 +97,7 @@ public class RegionsWithDiskStoreAndPersistenceEvictionSettingsIntegrationTests public void testPersistentNoOverflowRegion() { assertThat(persistentNoOverflowRegion) - .describedAs("The Persistent, No Overflow Region was not properly configured and initialized!") + .describedAs("The Persistent, No Overflow Region was not properly configured and initialized") .isNotNull(); assertThat(persistentNoOverflowRegion.getAttributes()).isNotNull(); @@ -111,7 +111,7 @@ public class RegionsWithDiskStoreAndPersistenceEvictionSettingsIntegrationTests public void testPersistentOverflowRegion() { assertThat(persistentOverflowRegion) - .describedAs("The Persistent, Overflow Region was not properly configured and initialized!") + .describedAs("The Persistent, Overflow Region was not properly configured and initialized") .isNotNull(); assertThat(persistentOverflowRegion.getAttributes()).isNotNull(); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ReplicatedRegionNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ReplicatedRegionNamespaceIntegrationTests.java index 59c49071..a9f2de39 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ReplicatedRegionNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/ReplicatedRegionNamespaceIntegrationTests.java @@ -137,7 +137,7 @@ public class ReplicatedRegionNamespaceIntegrationTests extends IntegrationTestsS Region region = applicationContext.getBean("replicated-with-attributes", Region.class); assertThat(region) - .describedAs("The 'replicated-with-attributes' Region was not properly configured and initialized!") + .describedAs("The 'replicated-with-attributes' Region was not properly configured and initialized") .isNotNull(); RegionAttributes regionAttributes = region.getAttributes(); @@ -167,7 +167,7 @@ public class ReplicatedRegionNamespaceIntegrationTests extends IntegrationTestsS Region region = applicationContext.getBean("replicated-with-synchronous-index-updates", Region.class); - assertThat(region).as(String.format("The '%1$s' Region was not properly configured and initialized!", + assertThat(region).as(String.format("The '%1$s' Region was not properly configured and initialized", "replicated-with-synchronous-index-updates")).isNotNull(); RegionAttributes regionAttributes = region.getAttributes(); @@ -200,7 +200,7 @@ public class ReplicatedRegionNamespaceIntegrationTests extends IntegrationTestsS Region compressed = applicationContext.getBean("Compressed", Region.class); - assertThat(compressed).as("The 'Compressed' REPLICATE Region was not properly configured and initialized!") + assertThat(compressed).as("The 'Compressed' REPLICATE Region was not properly configured and initialized") .isNotNull(); assertThat(compressed.getName()).isEqualTo("Compressed"); assertThat(compressed.getFullPath()).isEqualTo(Region.SEPARATOR + "Compressed"); @@ -221,12 +221,12 @@ public class ReplicatedRegionNamespaceIntegrationTests extends IntegrationTestsS @Override public byte[] compress(final byte[] input) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override public byte[] decompress(final byte[] input) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/SubRegionSubElementNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/SubRegionSubElementNamespaceIntegrationTests.java index 1f8aaccd..b07b0120 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/SubRegionSubElementNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/SubRegionSubElementNamespaceIntegrationTests.java @@ -76,7 +76,7 @@ public class SubRegionSubElementNamespaceIntegrationTests extends IntegrationTes } assertThat(found) - .as(String.format("Expected a GemFire CacheListener of type (%1$s) to be registered on Region (%2$s)!", + .describedAs(String.format("Expected a GemFire CacheListener of type (%1$s) to be registered on Region (%2$s)", TestNoOpCacheListener.class.getName(), customersAccountsRegion.getName())).isTrue(); } @@ -106,7 +106,7 @@ public class SubRegionSubElementNamespaceIntegrationTests extends IntegrationTes @Override public boolean processEvents(final List events) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplateClientRegionNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplateClientRegionNamespaceIntegrationTests.java index 487abe8d..c14959d6 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplateClientRegionNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplateClientRegionNamespaceIntegrationTests.java @@ -105,7 +105,7 @@ public class TemplateClientRegionNamespaceIntegrationTests extends IntegrationTe private void assertEvictionAttributes(EvictionAttributes evictionAttributes, EvictionAction expectedAction, EvictionAlgorithm expectedAlgorithm, int expectedMaximum, ObjectSizer expectedObjectSizer) { - assertThat(evictionAttributes).describedAs("The 'EvictionAttributes' must not be null!").isNotNull(); + assertThat(evictionAttributes).describedAs("The 'EvictionAttributes' must not be null").isNotNull(); assertThat(evictionAttributes.getAction()).isEqualTo(expectedAction); assertThat(evictionAttributes.getAlgorithm()).isEqualTo(expectedAlgorithm); assertThat(evictionAttributes.getMaximum()).isEqualTo(expectedMaximum); @@ -122,16 +122,16 @@ public class TemplateClientRegionNamespaceIntegrationTests extends IntegrationTe private void assertExpirationAttributes(ExpirationAttributes expirationAttributes, ExpirationAction expectedAction, int expectedTimeout) { - assertThat(expirationAttributes).as("The 'ExpirationAttributes' must not be null!").isNotNull(); + assertThat(expirationAttributes).as("The 'ExpirationAttributes' must not be null").isNotNull(); assertThat(expirationAttributes.getAction()).isEqualTo(expectedAction); assertThat(expirationAttributes.getTimeout()).isEqualTo(expectedTimeout); } private void assertDefaultRegionAttributes(Region region) { - assertThat(region).describedAs("The Region must not be null!").isNotNull(); + assertThat(region).describedAs("The Region must not be null").isNotNull(); assertThat(region.getAttributes()) - .describedAs("The Region (%1$s) must have 'RegionAttributes' defined!", region.getFullPath()) + .describedAs("The Region (%1$s) must have 'RegionAttributes' defined", region.getFullPath()) .isNotNull(); assertThat(region.getAttributes().getCompressor()).isNull(); assertThat(region.getAttributes().getCustomEntryIdleTimeout()).isNull(); @@ -160,11 +160,11 @@ public class TemplateClientRegionNamespaceIntegrationTests extends IntegrationTe private static void assertRegionMetaData(Region region, String expectedRegionName, String expectedRegionPath) { - assertThat(region).as(String.format("The '%1$s' Region was not properly configured and initialized!", + assertThat(region).as(String.format("The '%1$s' Region was not properly configured and initialized", expectedRegionName)).isNotNull(); assertThat(region.getName()).isEqualTo(expectedRegionName); assertThat(region.getFullPath()).isEqualTo(expectedRegionPath); - assertThat(region.getAttributes()).as(String.format("The '%1$s' Region must have RegionAttributes defined!", + assertThat(region.getAttributes()).as(String.format("The '%1$s' Region must have RegionAttributes defined", expectedRegionName)).isNotNull(); } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplatePersistentPartitionRegionNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplatePersistentPartitionRegionNamespaceIntegrationTests.java index d4d28432..5165bcfd 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplatePersistentPartitionRegionNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplatePersistentPartitionRegionNamespaceIntegrationTests.java @@ -77,7 +77,7 @@ public class TemplatePersistentPartitionRegionNamespaceIntegrationTests extends @Test public void testExampleTemplatedPersistentPartitionRegion() { - assertThat(example).describedAs("The '/Example' PARTITION Region was not properly configured and initialized!").isNotNull(); + assertThat(example).describedAs("The '/Example' PARTITION Region was not properly configured and initialized").isNotNull(); assertThat(example.getName()).isEqualTo("Example"); assertThat(example.getFullPath()).isEqualTo("/Example"); assertThat(example.getAttributes()).isNotNull(); @@ -99,7 +99,7 @@ public class TemplatePersistentPartitionRegionNamespaceIntegrationTests extends @Override public Object getRoutingObject(final EntryOperation kvEntryOperation) { - throw new UnsupportedOperationException("Not Implemented!"); + throw new UnsupportedOperationException("Not Implemented"); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplateRegionsNamespaceIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplateRegionsNamespaceIntegrationTests.java index 64f2d2e5..7a875e46 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplateRegionsNamespaceIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/config/xml/TemplateRegionsNamespaceIntegrationTests.java @@ -155,7 +155,7 @@ public class TemplateRegionsNamespaceIntegrationTests extends IntegrationTestsSu private void assertEvictionAttributes(EvictionAttributes evictionAttributes, EvictionAction expectedAction, EvictionAlgorithm expectedAlgorithm, int expectedMaximum, ObjectSizer expectedObjectSizer) { - assertThat(evictionAttributes).as("The 'EvictionAttributes' must not be null!").isNotNull(); + assertThat(evictionAttributes).as("The 'EvictionAttributes' must not be null").isNotNull(); assertThat(evictionAttributes.getAction()).isEqualTo(expectedAction); assertThat(evictionAttributes.getAlgorithm()).isEqualTo(expectedAlgorithm); assertThat(evictionAttributes.getMaximum()).isEqualTo(expectedMaximum); @@ -172,7 +172,7 @@ public class TemplateRegionsNamespaceIntegrationTests extends IntegrationTestsSu private void assertExpirationAttributes(ExpirationAttributes expirationAttributes, ExpirationAction expectedAction, int expectedTimeout) { - assertThat(expirationAttributes).as("The 'ExpirationAttributes' must not be null!").isNotNull(); + assertThat(expirationAttributes).as("The 'ExpirationAttributes' must not be null").isNotNull(); assertThat(expirationAttributes.getAction()).isEqualTo(expectedAction); assertThat(expirationAttributes.getTimeout()).isEqualTo(expectedTimeout); } @@ -216,10 +216,10 @@ public class TemplateRegionsNamespaceIntegrationTests extends IntegrationTestsSu @SuppressWarnings("unchecked") private void assertDefaultRegionAttributes(Region region) { - assertThat(region).describedAs("The Region must not be null!").isNotNull(); + assertThat(region).describedAs("The Region must not be null").isNotNull(); assertThat(region.getAttributes()) - .describedAs(String.format("Region (%1$s) must have 'RegionAttributes' defined!",region.getFullPath())) + .describedAs(String.format("Region (%1$s) must have 'RegionAttributes' defined",region.getFullPath())) .isNotNull(); assertThat(region.getAttributes().getCompressor()).isNull(); @@ -241,7 +241,7 @@ public class TemplateRegionsNamespaceIntegrationTests extends IntegrationTestsSu private void assertSubscriptionAttributes(SubscriptionAttributes subscriptionAttributes, InterestPolicy expectedInterestPolicy) { - assertThat(subscriptionAttributes).as("The 'SubscriptionAttributes' must not be null!").isNotNull(); + assertThat(subscriptionAttributes).as("The 'SubscriptionAttributes' must not be null").isNotNull(); assertThat(subscriptionAttributes.getInterestPolicy()).isEqualTo(expectedInterestPolicy); } @@ -263,11 +263,11 @@ public class TemplateRegionsNamespaceIntegrationTests extends IntegrationTestsSu private static void assertRegionMetaData(Region region, String expectedRegionName, String expectedRegionPath) { - assertThat(region).as(String.format("The '%1$s' Region was not properly configured and initialized!", + assertThat(region).as(String.format("The '%1$s' Region was not properly configured and initialized", expectedRegionName)).isNotNull(); assertThat(region.getName()).isEqualTo(expectedRegionName); assertThat(region.getFullPath()).isEqualTo(expectedRegionPath); - assertThat(region.getAttributes()).as(String.format("The '%1$s' Region must have RegionAttributes defined!", + assertThat(region.getAttributes()).as(String.format("The '%1$s' Region must have RegionAttributes defined", expectedRegionName)).isNotNull(); } @@ -289,7 +289,7 @@ public class TemplateRegionsNamespaceIntegrationTests extends IntegrationTestsSu try { applicationContext.getBean(beanName); fail(String - .format("The abstract bean definition '%1$s' should not exist as a bean in the Spring context!", + .format("The abstract bean definition '%1$s' should not exist as a bean in the Spring context", beanName)); } catch (BeansException expected) { diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/eviction/EvictionAttributesFactoryBeanTest.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/eviction/EvictionAttributesFactoryBeanTest.java index 52393eec..793660ca 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/eviction/EvictionAttributesFactoryBeanTest.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/eviction/EvictionAttributesFactoryBeanTest.java @@ -213,7 +213,7 @@ public class EvictionAttributesFactoryBeanTest { } catch (IllegalArgumentException expected) { assertThat(expected.getMessage()) - .isEqualTo("HEAP_PERCENTAGE (LRU_HEAP algorithm) does not support threshold (a.k.a. maximum)!"); + .isEqualTo("HEAP_PERCENTAGE (LRU_HEAP algorithm) does not support threshold (a.k.a. maximum)"); assertThat(factoryBean.getThreshold().intValue()).isEqualTo(85); assertThat(factoryBean.getType()).isEqualTo(EvictionPolicyType.HEAP_PERCENTAGE); throw expected; diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/function/PdxFunctionArgumentResolverIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/function/PdxFunctionArgumentResolverIntegrationTests.java index 8ab25009..d7f129b0 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/function/PdxFunctionArgumentResolverIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/function/PdxFunctionArgumentResolverIntegrationTests.java @@ -90,7 +90,7 @@ public class PdxFunctionArgumentResolverIntegrationTests extends IntegrationTest return type.getDeclaredMethod(methodName, parameterTypes); } catch (NoSuchMethodException cause) { - throw newRuntimeException("Failed to get method [%1$s] with signature [%2$s] on Class type [%3$s]!", + throw newRuntimeException("Failed to get method [%1$s] with signature [%2$s] on Class type [%3$s]", methodName, getMethodSignature(methodName, parameterTypes), type.getName()); } } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/mapping/MappingPdxSerializerUnitTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/mapping/MappingPdxSerializerUnitTests.java index 5dd5e70d..e503f24e 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/mapping/MappingPdxSerializerUnitTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/mapping/MappingPdxSerializerUnitTests.java @@ -293,7 +293,7 @@ public class MappingPdxSerializerUnitTests { } catch (IllegalArgumentException expected) { - assertThat(expected).hasMessage("CustomInstantiators must not be null!"); + assertThat(expected).hasMessage("CustomInstantiators must not be null"); assertThat(expected).hasNoCause(); throw expected; diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/Account.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/Account.java index 499d7e6f..7d1544b7 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/Account.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/Account.java @@ -40,7 +40,7 @@ public class Account { private String number; public Account(final Long customerId) { - Assert.notNull(customerId, "The Customer ID to which this Account is associated cannot be null!"); + Assert.notNull(customerId, "The Customer ID to which this Account is associated cannot be null"); this.customerId = customerId; } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/AlgorithmRepositoryIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/AlgorithmRepositoryIntegrationTests.java index e7c976fd..7d600156 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/AlgorithmRepositoryIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/AlgorithmRepositoryIntegrationTests.java @@ -58,11 +58,11 @@ public class AlgorithmRepositoryIntegrationTests extends IntegrationTestsSupport public void algorithmsRepositoryFunctionsCorrectly() { assertThat(algorithmRepo) - .describedAs("A reference to the AlgorithmRepository was not properly configured!") + .describedAs("A reference to the AlgorithmRepository was not properly configured") .isNotNull(); assertThat(algorithmsRegion) - .describedAs("A reference to the 'Algorithms' GemFire Cache Region was not properly configured!") + .describedAs("A reference to the 'Algorithms' GemFire Cache Region was not properly configured") .isNotNull(); assertThat(algorithmsRegion.getName()).isEqualTo("Algorithms"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/SubRegionRepositoryIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/SubRegionRepositoryIntegrationTests.java index 52fdc1f2..64142318 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/SubRegionRepositoryIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/SubRegionRepositoryIntegrationTests.java @@ -185,21 +185,21 @@ public class SubRegionRepositoryIntegrationTests extends IntegrationTestsSupport @Before public void setup() { - assertThat(programmers).as("The /Users/Programmers Subregion was null!").isNotNull(); + assertThat(programmers).as("The /Users/Programmers Subregion was null").isNotNull(); if (programmers.isEmpty()) { programmers.putAll(PROGRAMMER_USER_DATA); } assertThat(programmers.size()).isEqualTo(PROGRAMMER_USER_DATA.size()); - assertThat(adminUsers).as("The /Local/Admins/Users Subregion was null!").isNotNull(); + assertThat(adminUsers).as("The /Local/Admins/Users Subregion was null").isNotNull(); if (adminUsers.isEmpty()) { adminUsers.putAll(ADMIN_USER_DATA); } assertThat(adminUsers.size()).isEqualTo(ADMIN_USER_DATA.size()); - assertThat(guestUsers).as("The /Local/Guest/Users Subregion was null!").isNotNull(); + assertThat(guestUsers).as("The /Local/Guest/Users Subregion was null").isNotNull(); if (guestUsers.isEmpty()) { guestUsers.putAll(GUEST_USER_DATA); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/UserRepositoryQueriesIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/UserRepositoryQueriesIntegrationTests.java index 31a04fb7..d7ba743a 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/UserRepositoryQueriesIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/sample/UserRepositoryQueriesIntegrationTests.java @@ -60,7 +60,7 @@ public class UserRepositoryQueriesIntegrationTests extends IntegrationTestsSuppo private static void assertQueryResults(Iterable actualUsers, String... expectedUsernames) { - assertThat(actualUsers).as("The query did not return any results!").isNotNull(); + assertThat(actualUsers).as("The query did not return any results").isNotNull(); List actualUsernames = new ArrayList<>(expectedUsernames.length); @@ -99,7 +99,7 @@ public class UserRepositoryQueriesIntegrationTests extends IntegrationTestsSuppo @SuppressWarnings("unchecked") public void setup() { - assertThat(users).describedAs("The 'Users' GemFire Cache Region cannot be null!").isNotNull(); + assertThat(users).describedAs("The 'Users' GemFire Cache Region cannot be null").isNotNull(); if (users.isEmpty()) { userRepository.save(createUser("blumj", true)); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/support/AbstractGemfireRepositoryFactoryIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/support/AbstractGemfireRepositoryFactoryIntegrationTests.java index 80ca4bd8..2dc19d30 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/support/AbstractGemfireRepositoryFactoryIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/support/AbstractGemfireRepositoryFactoryIntegrationTests.java @@ -144,7 +144,7 @@ public abstract class AbstractGemfireRepositoryFactoryIntegrationTests extends I try { repository.findByLastname("Matthews"); - fail("Exception expected!"); + fail("Exception expected"); } catch (IncorrectResultSizeDataAccessException e) { assertThat(e.getExpectedSize()).isEqualTo(1); assertThat(e.getActualSize()).isEqualTo(2); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/support/SimpleGemfireRepositoryTransactionalIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/support/SimpleGemfireRepositoryTransactionalIntegrationTests.java index 0d460415..bc5e7595 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/support/SimpleGemfireRepositoryTransactionalIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/repository/support/SimpleGemfireRepositoryTransactionalIntegrationTests.java @@ -88,7 +88,7 @@ public class SimpleGemfireRepositoryTransactionalIntegrationTests extends Integr public void setup() { assertThat(this.customers) - .describedAs("The 'Customers' Cache Region was not properly configured and initialized!") + .describedAs("The 'Customers' Cache Region was not properly configured and initialized") .isNotNull(); assertThat(this.customers.getName()).isEqualTo("Customers"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/search/lucene/LuceneOperationsIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/search/lucene/LuceneOperationsIntegrationTests.java index 7d5eda97..cf8979fe 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/search/lucene/LuceneOperationsIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/search/lucene/LuceneOperationsIntegrationTests.java @@ -192,7 +192,7 @@ public class LuceneOperationsIntegrationTests extends IntegrationTestsSupport { } }); - assertThat(flushed).describedAs("LuceneIndex not flushed!").isTrue(); + assertThat(flushed).describedAs("LuceneIndex not flushed").isTrue(); } } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/LazyWiringDeclarableSupportFunctionBasedIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/LazyWiringDeclarableSupportFunctionBasedIntegrationTests.java index fa0fa811..7c7ed41e 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/LazyWiringDeclarableSupportFunctionBasedIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/LazyWiringDeclarableSupportFunctionBasedIntegrationTests.java @@ -83,7 +83,7 @@ public class LazyWiringDeclarableSupportFunctionBasedIntegrationTests extends In @Test public void helloGreeting() { - assertThat(helloFunctionExecution.hello(null)).isEqualTo("Hello Everyone!"); + assertThat(helloFunctionExecution.hello(null)).isEqualTo("Hello Everyone"); } protected static abstract class FunctionAdaptor extends LazyWiringDeclarableSupport implements Function { @@ -121,7 +121,7 @@ public class LazyWiringDeclarableSupportFunctionBasedIntegrationTests extends In protected static final String ADDRESS_TO_PARAMETER = "hello.address.to"; protected static final String DEFAULT_ADDRESS_TO = "World"; - protected static final String HELLO_GREETING = "Hello %1$s!"; + protected static final String HELLO_GREETING = "Hello %1$s"; protected static final String ID = "hello"; @Value("${hello.default.address.to}") diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializerIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializerIntegrationTests.java index 5140a011..f4a602b8 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializerIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializerIntegrationTests.java @@ -246,7 +246,7 @@ public class SpringContextBootstrappingInitializerIntegrationTests extends Integ public UserDataStoreCacheLoader() { Assert.state(INSTANCE.compareAndSet(null, this), - String.format("An instance of %1$s was already created!", getClass().getName())); + String.format("An instance of %1$s was already created", getClass().getName())); } @Override diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializerUnitTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializerUnitTests.java index b6dba752..4e42ef59 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializerUnitTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/SpringContextBootstrappingInitializerUnitTests.java @@ -698,7 +698,7 @@ public class SpringContextBootstrappingInitializerUnitTests { assertThat(expected.getMessage().contains("Failed to bootstrap the Spring ApplicationContext")).isTrue(); assertThat(expected.getCause() instanceof IllegalStateException).isTrue(); assertThat(expected.getCause().getMessage()).isEqualTo( - "The Spring ApplicationContext (testInitWhenApplicationContextIsNotRunning) failed to be properly initialized with the context config files ([]) or base packages ([org.example.app, org.example.plugins])!"); + "The Spring ApplicationContext (testInitWhenApplicationContextIsNotRunning) failed to be properly initialized with the context config files ([]) or base packages ([org.example.app, org.example.plugins])"); throw (IllegalStateException) expected.getCause(); } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/sample/TestUserDao.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/sample/TestUserDao.java index f180f06f..92c01e48 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/sample/TestUserDao.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/sample/TestUserDao.java @@ -40,7 +40,7 @@ public class TestUserDao implements UserDao { private DataSource userDataSource; public DataSource getDataSource() { - Assert.state(userDataSource != null, "A reference to the Users DataSource was not properly configured!"); + Assert.state(userDataSource != null, "A reference to the Users DataSource was not properly configured"); return userDataSource; } } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/sample/TestUserService.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/sample/TestUserService.java index df266072..dbc54e7a 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/sample/TestUserService.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/sample/TestUserService.java @@ -38,7 +38,7 @@ public class TestUserService implements UserService { private UserDao userDao; public UserDao getUserDao() { - Assert.state(userDao != null, "A reference to the UserDao was not properly configured!"); + Assert.state(userDao != null, "A reference to the UserDao was not properly configured"); return userDao; } } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/transaction/CommitConflictExceptionTransactionalIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/transaction/CommitConflictExceptionTransactionalIntegrationTests.java index 04e25d3a..1f526ed0 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/transaction/CommitConflictExceptionTransactionalIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/transaction/CommitConflictExceptionTransactionalIntegrationTests.java @@ -181,7 +181,7 @@ public class CommitConflictExceptionTransactionalIntegrationTests extends Integr }, Function.identity()); - fail("Expected CommitConflictException!"); + fail("Expected CommitConflictException"); } catch (RuntimeException expected) { diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/transaction/GemfireTransactionManagerIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/transaction/GemfireTransactionManagerIntegrationTests.java index 31e185ae..76c4b6e3 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/transaction/GemfireTransactionManagerIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/transaction/GemfireTransactionManagerIntegrationTests.java @@ -77,7 +77,7 @@ public class GemfireTransactionManagerIntegrationTests extends IntegrationTestsS } catch (IllegalArgumentException expected) { - assertThat(expected).hasMessage("BOOM!"); + assertThat(expected).hasMessage("BOOM"); assertThat(expected).hasNoCause(); throw expected; @@ -161,7 +161,7 @@ public class GemfireTransactionManagerIntegrationTests extends IntegrationTestsS @Transactional(propagation = Propagation.REQUIRED) public void doOperationTwoInTransactionOne() { - throw new IllegalArgumentException("BOOM!"); + throw new IllegalArgumentException("BOOM"); } } } diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/wan/CachePartitionRegionWithConcurrentParallelAsyncEventQueueAndGatewaySenderIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/wan/CachePartitionRegionWithConcurrentParallelAsyncEventQueueAndGatewaySenderIntegrationTests.java index 75889b29..f2018dd5 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/wan/CachePartitionRegionWithConcurrentParallelAsyncEventQueueAndGatewaySenderIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/wan/CachePartitionRegionWithConcurrentParallelAsyncEventQueueAndGatewaySenderIntegrationTests.java @@ -71,7 +71,7 @@ public class CachePartitionRegionWithConcurrentParallelAsyncEventQueueAndGateway public void testPartitionRegionWithConcurrentParallelAsyncEventQueueAndGatewaySenderConfiguration() { assertThat(exampleRegion) - .describedAs("The 'ExampleRegion' PARTITION Region was not properly configured and initialized!") + .describedAs("The 'ExampleRegion' PARTITION Region was not properly configured and initialized") .isNotNull(); assertThat(exampleRegion.getName()).isEqualTo("ExampleRegion"); @@ -86,7 +86,7 @@ public class CachePartitionRegionWithConcurrentParallelAsyncEventQueueAndGateway public void testConcurrentParallelAsyncEventQueue() { assertThat(exampleQueue) - .describedAs("The 'ExampleQueue' AsyncEventQueue was not properly configured and initialized!") + .describedAs("The 'ExampleQueue' AsyncEventQueue was not properly configured and initialized") .isNotNull(); assertThat(exampleQueue.getId()).isEqualTo("ExampleQueue"); @@ -99,7 +99,7 @@ public class CachePartitionRegionWithConcurrentParallelAsyncEventQueueAndGateway public void testConcurrentParallelGatewaySender() { assertThat(exampleGateway) - .describedAs("The 'ExampleGateway' was not properly configured and initialized!") + .describedAs("The 'ExampleGateway' was not properly configured and initialized") .isNotNull(); assertThat(exampleGateway.getId()).isEqualTo("ExampleGateway"); diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/wan/GatewayReceiverManualStartIntegrationTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/wan/GatewayReceiverManualStartIntegrationTests.java index 8d34e075..f3ba92de 100644 --- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/wan/GatewayReceiverManualStartIntegrationTests.java +++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/wan/GatewayReceiverManualStartIntegrationTests.java @@ -67,7 +67,7 @@ public class GatewayReceiverManualStartIntegrationTests extends IntegrationTests public void autoGatewayReceiverConfigurationIsCorrect() { assertThat(autoGatewayReceiver) - .describedAs("The 'Auto' GatewayReceiver was not properly configured or initialized!") + .describedAs("The 'Auto' GatewayReceiver was not properly configured or initialized") .isNotNull(); assertThat(autoGatewayReceiver.isRunning()).isTrue(); @@ -77,7 +77,7 @@ public class GatewayReceiverManualStartIntegrationTests extends IntegrationTests int gatewayReceiverPort = autoGatewayReceiver.getPort(); assertGreaterThanEqualToLessThanEqualTo(String.format( - "GatewayReceiver 'port' [%1$d] was not greater than equal to [%2$d] and less than equal to [%3$d]!", + "GatewayReceiver 'port' [%1$d] was not greater than equal to [%2$d] and less than equal to [%3$d]", gatewayReceiverPort, autoGatewayReceiver.getStartPort(), autoGatewayReceiver.getEndPort()), gatewayReceiverPort, autoGatewayReceiver.getStartPort(), autoGatewayReceiver.getEndPort()); @@ -90,7 +90,7 @@ public class GatewayReceiverManualStartIntegrationTests extends IntegrationTests public void manualGatewayReceiverConfigurationIsCorrect() throws IOException { assertThat(manualGatewayReceiver) - .describedAs("The 'Manual' GatewayReceiver was not properly configured or initialized!") + .describedAs("The 'Manual' GatewayReceiver was not properly configured or initialized") .isNotNull(); assertThat(manualGatewayReceiver.isRunning()).isFalse(); @@ -104,7 +104,7 @@ public class GatewayReceiverManualStartIntegrationTests extends IntegrationTests int gatewayReceiverPort = manualGatewayReceiver.getPort(); assertGreaterThanEqualToLessThanEqualTo(String.format( - "GatewayReceiver 'port' [%1$d] was not greater than equal to [%2$d] and less than equal to [%3$d]!", + "GatewayReceiver 'port' [%1$d] was not greater than equal to [%2$d] and less than equal to [%3$d]", gatewayReceiverPort, manualGatewayReceiver.getStartPort(), manualGatewayReceiver.getEndPort()), gatewayReceiverPort, manualGatewayReceiver.getStartPort(), manualGatewayReceiver.getEndPort());