From ebac3737094676de12476b56fdc088f3319371da Mon Sep 17 00:00:00 2001
From: Jacob Barrett <jbarrett@pivotal.io>
Date: Mon, 9 Dec 2019 19:48:51 -0800
Subject: [PATCH] DATAGEODE-283 - Parse standard "host:port" format.

Resolves gh-32.

Adds support for standard "host:port" format when parsing
ConnectionEndpoints while preserving "host[port]" support.
---
 .../gemfire/support/ConnectionEndpoint.java   |  12 +-
 .../support/ConnectionEndpointUnitTests.java  | 119 ++++++++++++++++++
 2 files changed, 130 insertions(+), 1 deletion(-)

diff --git a/spring-data-geode/src/main/java/org/springframework/data/gemfire/support/ConnectionEndpoint.java b/spring-data-geode/src/main/java/org/springframework/data/gemfire/support/ConnectionEndpoint.java
index b8e55df2..87922268 100644
--- a/spring-data-geode/src/main/java/org/springframework/data/gemfire/support/ConnectionEndpoint.java
+++ b/spring-data-geode/src/main/java/org/springframework/data/gemfire/support/ConnectionEndpoint.java
@@ -82,7 +82,7 @@ public class ConnectionEndpoint implements Cloneable, Comparable<ConnectionEndpo
 		String host = StringUtils.trimAllWhitespace(hostPort);
 
 		int port = defaultPort;
-		int portIndex = host.indexOf("[");
+		int portIndex = indexOfPort(host);
 
 		if (portIndex > -1) {
 			port = parsePort(parseDigits(host.substring(portIndex)), defaultPort);
@@ -92,6 +92,16 @@ public class ConnectionEndpoint implements Cloneable, Comparable<ConnectionEndpo
 		return new ConnectionEndpoint(host, port);
 	}
 
+	static int indexOfPort(String host) {
+		for (int i = 0; i < host.length(); ++i) {
+			char c = host.charAt(i);
+			if (':' == c || '[' == c) {
+				return i;
+			}
+		}
+		return -1;
+	}
+
 	static String parseDigits(String value) {
 
 		StringBuilder digits = new StringBuilder();
diff --git a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/ConnectionEndpointUnitTests.java b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/ConnectionEndpointUnitTests.java
index ff1105c4..3e8915cc 100644
--- a/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/ConnectionEndpointUnitTests.java
+++ b/spring-data-geode/src/test/java/org/springframework/data/gemfire/support/ConnectionEndpointUnitTests.java
@@ -16,6 +16,7 @@
 package org.springframework.data.gemfire.support;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import java.net.InetSocketAddress;
 
@@ -60,6 +61,22 @@ public class ConnectionEndpointUnitTests {
 		assertThat(connectionEndpoint.getPort()).isEqualTo(1234);
 	}
 
+	@Test
+	public void parseUsingDefaultHostAndDefaultPortWithColon() {
+
+		ConnectionEndpoint connectionEndpoint = ConnectionEndpoint.parse(":");
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo(ConnectionEndpoint.DEFAULT_HOST);
+		assertThat(connectionEndpoint.getPort()).isEqualTo(ConnectionEndpoint.DEFAULT_PORT);
+
+		connectionEndpoint = ConnectionEndpoint.parse(":", 1234);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo(ConnectionEndpoint.DEFAULT_HOST);
+		assertThat(connectionEndpoint.getPort()).isEqualTo(1234);
+	}
+
 	@Test
 	public void parseWithHostPort() {
 
@@ -82,6 +99,28 @@ public class ConnectionEndpointUnitTests {
 		assertThat(connectionEndpoint.getPort()).isEqualTo(111);
 	}
 
+	@Test
+	public void parseWithHostPortWithColon() {
+
+		ConnectionEndpoint connectionEndpoint = ConnectionEndpoint.parse("skullbox:12345", 80);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("skullbox");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(12345);
+
+		connectionEndpoint = ConnectionEndpoint.parse("localhost:0", 8080);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("localhost");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(0);
+
+		connectionEndpoint = ConnectionEndpoint.parse("jambox:1O1O1", 443);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("jambox");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(111);
+	}
+
 	@Test
 	public void parseWithHostPortHavingSpacing() {
 
@@ -92,6 +131,16 @@ public class ConnectionEndpointUnitTests {
 		assertThat(connectionEndpoint.getPort()).isEqualTo(1234);
 	}
 
+	@Test
+	public void parseWithHostPortHavingSpacingWithColon() {
+
+		ConnectionEndpoint connectionEndpoint = ConnectionEndpoint.parse(" saturn  :1  23 4 ");
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("saturn");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(1234);
+	}
+
 	@Test
 	public void parseWithHostUsingDefaultPort() {
 
@@ -139,6 +188,53 @@ public class ConnectionEndpointUnitTests {
 		assertThat(connectionEndpoint.getPort()).isEqualTo(ConnectionEndpoint.DEFAULT_PORT);
 	}
 
+	@Test
+	public void parseWithHostUsingDefaultPortWithColon() {
+
+		ConnectionEndpoint connectionEndpoint =
+				ConnectionEndpoint.parse("mercury:oneTwoThreeFourFive", 80);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("mercury");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(80);
+
+		connectionEndpoint = ConnectionEndpoint.parse("venus:OxCAFEBABE", 443);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("venus");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(443);
+
+		connectionEndpoint = ConnectionEndpoint.parse("jupiter:#(^$)*!", 21);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("jupiter");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(21);
+
+		connectionEndpoint = ConnectionEndpoint.parse("saturn:", 22);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("saturn");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(22);
+
+		connectionEndpoint = ConnectionEndpoint.parse("uranis:", 23);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("uranis");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(23);
+
+		connectionEndpoint = ConnectionEndpoint.parse("neptune", 25);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("neptune");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(25);
+
+		connectionEndpoint = ConnectionEndpoint.parse("pluto");
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo("pluto");
+		assertThat(connectionEndpoint.getPort()).isEqualTo(ConnectionEndpoint.DEFAULT_PORT);
+	}
+
 	@Test
 	public void parseWithPortUsingDefaultHost() {
 
@@ -149,6 +245,16 @@ public class ConnectionEndpointUnitTests {
 		assertThat(connectionEndpoint.getPort()).isEqualTo(12345);
 	}
 
+	@Test
+	public void parseWithPortUsingDefaultHostWithColon() {
+
+		ConnectionEndpoint connectionEndpoint = ConnectionEndpoint.parse(":12345", 80);
+
+		assertThat(connectionEndpoint).isNotNull();
+		assertThat(connectionEndpoint.getHost()).isEqualTo(ConnectionEndpoint.DEFAULT_HOST);
+		assertThat(connectionEndpoint.getPort()).isEqualTo(12345);
+	}
+
 	@Test(expected = IllegalArgumentException.class)
 	public void parseWithBlankHost() {
 
@@ -209,6 +315,19 @@ public class ConnectionEndpointUnitTests {
 		}
 	}
 
+	@Test
+	public void indexOfPort() {
+		assertThat(ConnectionEndpoint.indexOfPort("")).isEqualTo(-1);
+		assertThat(ConnectionEndpoint.indexOfPort("a")).isEqualTo(-1);
+		assertThat(ConnectionEndpoint.indexOfPort(":")).isEqualTo(0);
+		assertThat(ConnectionEndpoint.indexOfPort("a:")).isEqualTo(1);
+		assertThat(ConnectionEndpoint.indexOfPort(":a")).isEqualTo(0);
+		assertThat(ConnectionEndpoint.indexOfPort("a:b")).isEqualTo(1);
+		assertThat(ConnectionEndpoint.indexOfPort("ab:")).isEqualTo(2);
+		assertThat(ConnectionEndpoint.indexOfPort("ab:c")).isEqualTo(2);
+		assertThatThrownBy(() -> ConnectionEndpoint.indexOfPort(null)).isInstanceOf(NullPointerException.class);
+	}
+
 	@Test
 	public void parseDigits() {