From 1b6c77973bc07359286e9579ea0bbec9c4f1a821 Mon Sep 17 00:00:00 2001
From: Mark Paluch <mpaluch@vmware.com>
Date: Tue, 14 Sep 2021 12:06:13 +0200
Subject: [PATCH] Disable parameter names for test compilation.

We now no longer use compiled parameter names for tests to avoid interference with Eclipselink's mechanism of using these improperly for stored procedure calls. Especially the fact that a parameter is named "in" lets the database consider using an IN clause instead of the parameter name.

When configuring the compile plugin, we also need to ensure that the AspectJ plugin post-processes the compiled classes and doesn't run before the Maven compiler plugin.

Closes: #2298
See also https://github.com/spring-projects/spring-data-build/issues/1513
---
 pom.xml | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/pom.xml b/pom.xml
index f3e001563..b11d2b103 100644
--- a/pom.xml
+++ b/pom.xml
@@ -383,6 +383,22 @@
 				</executions>
 			</plugin>
 
+			<plugin>
+				<artifactId>maven-compiler-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>java-test-compile</id>
+						<phase>test-compile</phase>
+						<goals>
+							<goal>testCompile</goal>
+						</goals>
+						<configuration>
+							<parameters>false</parameters>
+						</configuration>
+					</execution>
+				</executions>
+			</plugin>
+
 			<plugin>
 				<groupId>io.starter</groupId>
 				<artifactId>aspectj-maven-plugin</artifactId>
@@ -404,6 +420,7 @@
 						<goals>
 							<goal>compile</goal>
 						</goals>
+						<phase>process-classes</phase>
 					</execution>
 				</executions>
 				<configuration>