From 547d8791a7d7b41c57decd2678226dff67a77979 Mon Sep 17 00:00:00 2001 From: Jens Schauder Date: Fri, 26 Jan 2018 10:49:41 +0100 Subject: [PATCH] DATAJPA-1248 - Polishing. Removed superfluous modifiers and throws declarations. Used Collections.singletonList where appropriate. Original pull request: #245. --- .../data/jpa/repository/query/TupleConverterUnitTests.java | 6 +++--- .../data/jpa/repository/sample/UserRepository.java | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/test/java/org/springframework/data/jpa/repository/query/TupleConverterUnitTests.java b/src/test/java/org/springframework/data/jpa/repository/query/TupleConverterUnitTests.java index 44e433c5f..a85599df0 100644 --- a/src/test/java/org/springframework/data/jpa/repository/query/TupleConverterUnitTests.java +++ b/src/test/java/org/springframework/data/jpa/repository/query/TupleConverterUnitTests.java @@ -67,9 +67,9 @@ public class TupleConverterUnitTests { @Test // DATAJPA-984 @SuppressWarnings("unchecked") - public void returnsSingleTupleElementIfItMatchesExpectedType() throws Exception { + public void returnsSingleTupleElementIfItMatchesExpectedType() { - doReturn(Arrays.asList(element)).when(tuple).getElements(); + doReturn(Collections.singletonList(element)).when(tuple).getElements(); doReturn("Foo").when(tuple).get(element); TupleConverter converter = new TupleConverter(type); @@ -79,7 +79,7 @@ public class TupleConverterUnitTests { @Test // DATAJPA-1024 @SuppressWarnings("unchecked") - public void returnsNullForSingleElementTupleWithNullValue() throws Exception { + public void returnsNullForSingleElementTupleWithNullValue() { doReturn(Collections.singletonList(element)).when(tuple).getElements(); doReturn(null).when(tuple).get(element); diff --git a/src/test/java/org/springframework/data/jpa/repository/sample/UserRepository.java b/src/test/java/org/springframework/data/jpa/repository/sample/UserRepository.java index 61bc51fc6..a295f1da1 100644 --- a/src/test/java/org/springframework/data/jpa/repository/sample/UserRepository.java +++ b/src/test/java/org/springframework/data/jpa/repository/sample/UserRepository.java @@ -517,14 +517,14 @@ public interface UserRepository @Query("SELECT u FROM User u where u.firstname >= ?1 and u.lastname = '000:1'") List queryWithIndexedParameterAndColonFollowedByIntegerInString(String firstname); - static interface RolesAndFirstname { + interface RolesAndFirstname { String getFirstname(); Set getRoles(); } - static interface NameOnly { + interface NameOnly { String getFirstname();