From 6bae3c5a48a96c4c1585e6716ec1937949102e69 Mon Sep 17 00:00:00 2001
From: Jens Schauder <jschauder@vmware.com>
Date: Wed, 12 Jan 2022 15:44:48 +0100
Subject: [PATCH] Polishing.

Original pull request #2324
---
 .../data/jpa/mapping/JpaPersistentPropertyImpl.java           | 4 ++--
 .../jpa/repository/config/JpaRepositoryConfigExtension.java   | 4 ++--
 .../data/jpa/repository/query/StringQuery.java                | 1 +
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java b/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java
index 4e9c06795..f32dee706 100644
--- a/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java
+++ b/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java
@@ -333,8 +333,8 @@ class JpaPersistentPropertyImpl extends AnnotationBasedPersistentProperty<JpaPer
 				continue;
 			}
 
-			// may cause NullPointerException if the returned value is null
-			return (boolean) AnnotationUtils.getValue(annotation, "updatable");
+			final Object updatable = AnnotationUtils.getValue(annotation, "updatable");
+			return (boolean) (updatable == null ? true : updatable);
 		}
 
 		return true;
diff --git a/src/main/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtension.java b/src/main/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtension.java
index 7cdba8957..2de91cdde 100644
--- a/src/main/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtension.java
+++ b/src/main/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtension.java
@@ -15,6 +15,8 @@
  */
 package org.springframework.data.jpa.repository.config;
 
+import static org.springframework.data.jpa.repository.config.BeanDefinitionNames.*;
+
 import java.lang.annotation.Annotation;
 import java.util.Arrays;
 import java.util.Collection;
@@ -52,8 +54,6 @@ import org.springframework.orm.jpa.support.PersistenceAnnotationBeanPostProcesso
 import org.springframework.util.ClassUtils;
 import org.springframework.util.StringUtils;
 
-import static org.springframework.data.jpa.repository.config.BeanDefinitionNames.*;
-
 /**
  * JPA specific configuration extension parsing custom attributes from the XML namespace and
  * {@link EnableJpaRepositories} annotation. Also, it registers bean definitions for a
diff --git a/src/main/java/org/springframework/data/jpa/repository/query/StringQuery.java b/src/main/java/org/springframework/data/jpa/repository/query/StringQuery.java
index dbac54211..3760477ae 100644
--- a/src/main/java/org/springframework/data/jpa/repository/query/StringQuery.java
+++ b/src/main/java/org/springframework/data/jpa/repository/query/StringQuery.java
@@ -263,6 +263,7 @@ class StringQuery implements DeclaredQuery {
 				Integer parameterIndex = getParameterIndex(parameterIndexString);
 
 				String typeSource = matcher.group(COMPARISION_TYPE_GROUP);
+				Assert.isTrue(parameterIndexString != null || parameterName != null, () -> String.format("We need either a name or an index! Offending query string: %s", query));
 				String expression = spelExtractor.getParameter(parameterName == null ? parameterIndexString : parameterName);
 				String replacement = null;