From a1ebea0a6187b62e0f5c2a75e140403ec6e11efa Mon Sep 17 00:00:00 2001 From: Christoph Strobl Date: Thu, 1 Feb 2024 10:03:16 +0100 Subject: [PATCH] Polishing Add issue reference to test and provide additional test cases. Original Pull Request: #3343 --- .../repository/query/HqlQueryRendererTests.java | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/HqlQueryRendererTests.java b/spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/HqlQueryRendererTests.java index 5a6135dde..6715d4149 100644 --- a/spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/HqlQueryRendererTests.java +++ b/spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/HqlQueryRendererTests.java @@ -22,6 +22,8 @@ import org.antlr.v4.runtime.CharStreams; import org.antlr.v4.runtime.CommonTokenStream; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; /** * Tests built around examples of HQL found in @@ -1636,8 +1638,17 @@ class HqlQueryRendererTests { """); } - @Test - void queryWithSignedNumericLiteralShouldWork() { - assertQuery("select -1"); + @ParameterizedTest // GH-3342 + @ValueSource(strings = { + "select 1 from User", + "select -1 from User", + "select +1 from User", + "select +1*-100 from User", + "select count(u)*-0.7f from User u", + "select count(oi) + (-100) as perc from StockOrderItem oi", + "select p from Payment p where length(p.cardNumber) between +16 and -20" + }) + void signedLiteralShouldWork(String query) { + assertQuery(query); } }