From c7da62ffbcd5cf04dc66de03cfcdaf9358aabc80 Mon Sep 17 00:00:00 2001 From: Jens Schauder Date: Mon, 4 Sep 2017 12:10:54 +0200 Subject: [PATCH] =?UTF-8?q?DATAJPA-1171=20-=20CrudRepository.exists(?= =?UTF-8?q?=E2=80=A6)=20does=20no=20longer=20contain=20a=201=20=3D=201=20c?= =?UTF-8?q?lause=20in=20query.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changed the query generating code to use streams and joiner which made it simpler and the use of 1 = 1 superfluous. Original pull request: #212. --- .../data/jpa/repository/query/QueryUtils.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java b/src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java index f587e27f6..584d25caf 100644 --- a/src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java +++ b/src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java @@ -70,6 +70,7 @@ import org.springframework.util.StringUtils; * @author Christoph Strobl * @author Mark Paluch * @author Sébastien Péralta + * @author Jens Schauder */ public abstract class QueryUtils { @@ -183,14 +184,14 @@ public abstract class QueryUtils { Iterable idAttributes) { StringBuilder sb = new StringBuilder(String.format(COUNT_QUERY_STRING, countQueryPlaceHolder, entityName)); - sb.append(" WHERE "); + String append = " WHERE "; for (String idAttribute : idAttributes) { + sb.append(append); sb.append(String.format(EQUALS_CONDITION_STRING, "x", idAttribute, idAttribute)); - sb.append(" AND "); + append = " AND "; } - sb.append("1 = 1"); return sb.toString(); }