From f092c4edf82671f824a6507916ba1dd16ab2f820 Mon Sep 17 00:00:00 2001
From: Oliver Gierke <ogierke@pivotal.io>
Date: Tue, 19 May 2015 13:47:17 +0200
Subject: [PATCH] DATAJPA-716 - Strengthened tests for updatability detection
 in JpaPersistentProperty.

Added negative check, too, and tweaked implementation to actually correctly detect the updatability.
---
 .../data/jpa/mapping/JpaPersistentPropertyImpl.java         | 6 +++---
 .../jpa/mapping/JpaPersistentPropertyImplUnitTests.java     | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java b/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java
index d02781aec..7a3edc640 100644
--- a/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java
+++ b/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImpl.java
@@ -292,11 +292,11 @@ class JpaPersistentPropertyImpl extends AnnotationBasedPersistentProperty<JpaPer
 
 			Annotation annotation = findAnnotation(annotationType);
 
-			if (annotation != null && AnnotationUtils.getValue(annotation, "updateable") == Boolean.TRUE) {
-				return true;
+			if (annotation != null && AnnotationUtils.getValue(annotation, "updatable").equals(Boolean.FALSE)) {
+				return false;
 			}
 		}
 
-		return false;
+		return true;
 	}
 }
diff --git a/src/test/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImplUnitTests.java b/src/test/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImplUnitTests.java
index 58af4a16c..2f874edff 100644
--- a/src/test/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImplUnitTests.java
+++ b/src/test/java/org/springframework/data/jpa/mapping/JpaPersistentPropertyImplUnitTests.java
@@ -188,6 +188,7 @@ public class JpaPersistentPropertyImplUnitTests {
 	@Test
 	public void considersNonUpdateablePropertyNotWriteable() {
 		assertThat(getProperty(WithReadOnly.class, "name").isWritable(), is(false));
+		assertThat(getProperty(WithReadOnly.class, "updatable").isWritable(), is(true));
 	}
 
 	private JpaPersistentProperty getProperty(Class<?> ownerType, String propertyName) {
@@ -311,5 +312,6 @@ public class JpaPersistentPropertyImplUnitTests {
 
 	static class WithReadOnly {
 		@Column(updatable = false) String name;
+		String updatable;
 	}
 }