From f5484a05a40c32d2e1ec32e5f6766424e5a6b29b Mon Sep 17 00:00:00 2001 From: Oliver Gierke Date: Wed, 4 Apr 2018 12:37:26 +0200 Subject: [PATCH] DATAJPA-1307 - Polishing. Original pull request: #263. --- .../data/jpa/repository/query/DeclaredQuery.java | 6 ++++-- .../jpa/repository/query/SimpleJpaQueryUnitTests.java | 8 +++----- .../data/jpa/repository/query/StringQueryUnitTests.java | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/org/springframework/data/jpa/repository/query/DeclaredQuery.java b/src/main/java/org/springframework/data/jpa/repository/query/DeclaredQuery.java index e9aaa114a..947c32fb4 100644 --- a/src/main/java/org/springframework/data/jpa/repository/query/DeclaredQuery.java +++ b/src/main/java/org/springframework/data/jpa/repository/query/DeclaredQuery.java @@ -93,9 +93,11 @@ interface DeclaredQuery { } /** - * Returns wether the query uses JDBC style parameters, i.e. parameters denoted by a simple ? without any index or name. + * Returns whether the query uses JDBC style parameters, i.e. parameters denoted by a simple ? without any index or + * name. * - * @return Wether the query uses JDBC style parameters. + * @return Whether the query uses JDBC style parameters. + * @since 2.0.6 */ boolean usesJdbcStyleParameters(); } diff --git a/src/test/java/org/springframework/data/jpa/repository/query/SimpleJpaQueryUnitTests.java b/src/test/java/org/springframework/data/jpa/repository/query/SimpleJpaQueryUnitTests.java index cc83030c7..2a92cd1d2 100644 --- a/src/test/java/org/springframework/data/jpa/repository/query/SimpleJpaQueryUnitTests.java +++ b/src/test/java/org/springframework/data/jpa/repository/query/SimpleJpaQueryUnitTests.java @@ -227,12 +227,10 @@ public class SimpleJpaQueryUnitTests { // just verifying that it doesn't throw an exception createJpaQuery(SampleRepository.class.getMethod("legalUseOfJdbcStyleParameters", String.class)); + Method illegalMethod = SampleRepository.class.getMethod("illegalUseOfJdbcStyleParameters", String.class); + assertThatExceptionOfType(IllegalArgumentException.class) // - .isThrownBy( // - () -> createJpaQuery( // - SampleRepository.class.getMethod("illegalUseOfJdbcStyleParameters", String.class) // - ) // - ); + .isThrownBy(() -> createJpaQuery(illegalMethod)); } private AbstractJpaQuery createJpaQuery(Method method) { diff --git a/src/test/java/org/springframework/data/jpa/repository/query/StringQueryUnitTests.java b/src/test/java/org/springframework/data/jpa/repository/query/StringQueryUnitTests.java index 886ff16b7..e802b87e3 100644 --- a/src/test/java/org/springframework/data/jpa/repository/query/StringQueryUnitTests.java +++ b/src/test/java/org/springframework/data/jpa/repository/query/StringQueryUnitTests.java @@ -430,7 +430,7 @@ public class StringQueryUnitTests { } } - @Test // DATAJPA + @Test // DATAJPA-1307 public void makesUsageOfJdbcStyleParameterAvailable() { SoftAssertions softly = new SoftAssertions();