Spring/spring-data-keyvalue
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAKV-96 - Added QueryDslPredicateExecutor.findAll(Predicate, Sort).

Browse Source 
We now support findAll on QuerydslKeyValueRepository that accepts a Querydsl Predicate and a Sort.

Original pull request: #4.
This commit is contained in:
Thomas Darimont
2015-02-23 12:30:52 +01:00
committed by Oliver Gierke
parent 8f1bc111b4
commit c305988582
3 changed files with 38 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/java/org/springframework/data/map/AbstractRepositoryUnitTests.java
View File

@@ -30,6 +30,7 @@ import org.springframework.data.domain.Pageable;
import org.springframework.data.domain.Sort;
import org.springframework.data.domain.Sort.Direction;
import org.springframework.data.keyvalue.Person;
import org.springframework.data.keyvalue.QPerson;
import org.springframework.data.keyvalue.core.KeyValueOperations;
import org.springframework.data.keyvalue.core.KeyValueTemplate;
import org.springframework.data.keyvalue.repository.KeyValueRepository;
@@ -41,6 +42,7 @@ import org.springframework.data.repository.CrudRepository;
*
* @author Christoph Strobl
* @author Oliver Gierke
* @author Thomas Darimont
*/
public abstract class AbstractRepositoryUnitTests<T extends AbstractRepositoryUnitTests.PersonRepository> {
@@ -50,6 +52,8 @@ public abstract class AbstractRepositoryUnitTests<T extends AbstractRepositoryUn
protected static List<Person> LENNISTERS = Arrays.asList(CERSEI, JAIME, TYRION);
protected final QPerson person = QPerson.person;
protected T repository;
protected KeyValueRepositoryFactory factory;

27
src/test/java/org/springframework/data/map/QuerydslKeyValueRepositoryUnitTests.java
View File

@@ -15,15 +15,15 @@
*/
package org.springframework.data.map;
import static org.hamcrest.collection.IsCollectionWithSize.*;
import static org.hamcrest.collection.IsIterableContainingInAnyOrder.*;
import static org.hamcrest.collection.IsIterableContainingInOrder.*;
import static org.hamcrest.core.Is.*;
import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;
import java.util.List;
import org.junit.Test;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Sort;
import org.springframework.data.domain.Sort.Direction;
import org.springframework.data.keyvalue.Person;
import org.springframework.data.keyvalue.QPerson;
@@ -33,11 +33,14 @@ import org.springframework.data.map.QuerydslKeyValueRepositoryUnitTests.QPersonR
import org.springframework.data.querydsl.QSort;
import org.springframework.data.querydsl.QueryDslPredicateExecutor;
import com.google.common.collect.Lists;
/**
* Unit tests for {@link QuerydslKeyValueRepository}.
*
* @author Christoph Strobl
* @author Oliver Gierke
* @author Thomas Darimont
*/
public class QuerydslKeyValueRepositoryUnitTests extends AbstractRepositoryUnitTests<QPersonRepository> {
@@ -165,6 +168,22 @@ public class QuerydslKeyValueRepositoryUnitTests extends AbstractRepositoryUnitT
assertThat(repository.exists(QPerson.person.age.eq(CERSEI.getAge())), is(true));
}
/**
* @see DATAKV-96
*/
@Test
public void shouldSupportFindAllWithPredicateAndSort() {
repository.save(LENNISTERS);
List<Person> users = Lists.newArrayList(repository.findAll(person.age.gt(0), new Sort(Direction.ASC, "firstname")));
assertThat(users, hasSize(3));
assertThat(users.get(0).getFirstname(), is(CERSEI.getFirstname()));
assertThat(users.get(2).getFirstname(), is(TYRION.getFirstname()));
assertThat(users, hasItems(CERSEI, JAIME, TYRION));
}
/*
* (non-Javadoc)
* @see org.springframework.data.map.SimpleKeyValueRepositoryUnitTests#getRepository(org.springframework.data.keyvalue.repository.support.KeyValueRepositoryFactory)