diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/MongoTemplate.java b/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/MongoTemplate.java index d3b77ae9a..3375135f5 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/MongoTemplate.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/MongoTemplate.java @@ -239,7 +239,7 @@ public class MongoTemplate implements InitializingBean { } } - public List queryForCollection(Class targetClass) { + public List getCollection(Class targetClass) { List results = new ArrayList(); DBCollection collection = getDb().getCollection(getDefaultCollectionName()); @@ -253,7 +253,7 @@ public class MongoTemplate implements InitializingBean { return results; } - public List queryForCollection(String collectionName, Class targetClass) { + public List getCollection(String collectionName, Class targetClass) { List results = new ArrayList(); DBCollection collection = getDb().getCollection(collectionName); @@ -267,7 +267,7 @@ public class MongoTemplate implements InitializingBean { return results; } - public List queryForCollection(String collectionName, Class targetClass, MongoReader reader) { + public List getCollection(String collectionName, Class targetClass, MongoReader reader) { List results = new ArrayList(); DBCollection collection = getDb().getCollection(collectionName); for (DBObject dbo : collection.find()) { @@ -278,34 +278,34 @@ public class MongoTemplate implements InitializingBean { // Queries that take JavaScript to express the query. - public List queryForList(String query, Class targetClass) { - return queryForList(getDefaultCollectionName(), (DBObject)JSON.parse(query), targetClass); + public List queryUsingJavaScript(String query, Class targetClass) { + return query(getDefaultCollectionName(), (DBObject)JSON.parse(query), targetClass); // } - public List queryForList(String query, Class targetClass, MongoReader reader) { - return queryForList(getDefaultCollectionName(), (DBObject)JSON.parse(query), targetClass, reader); + public List queryUsingJavaScript(String query, Class targetClass, MongoReader reader) { + return query(getDefaultCollectionName(), (DBObject)JSON.parse(query), targetClass, reader); } - public List queryForList(String collectionName, String query, Class targetClass) { - return queryForList(collectionName, (DBObject)JSON.parse(query), targetClass); + public List queryUsingJavaScript(String collectionName, String query, Class targetClass) { + return query(collectionName, (DBObject)JSON.parse(query), targetClass); // } - public List queryForList(String collectionName, String query, Class targetClass, MongoReader reader) { - return queryForList(collectionName, (DBObject)JSON.parse(query), targetClass, reader); + public List queryUsingJavaScript(String collectionName, String query, Class targetClass, MongoReader reader) { + return query(collectionName, (DBObject)JSON.parse(query), targetClass, reader); } // Queries that take DBObject to express the query - public List queryForList(DBObject query, Class targetClass) { - return queryForList(getDefaultCollectionName(), query, targetClass); + public List query(DBObject query, Class targetClass) { + return query(getDefaultCollectionName(), query, targetClass); // } - public List queryForList(DBObject query, Class targetClass, MongoReader reader) { - return queryForList(getDefaultCollectionName(), query, targetClass, reader); + public List query(DBObject query, Class targetClass, MongoReader reader) { + return query(getDefaultCollectionName(), query, targetClass, reader); } - public List queryForList(String collectionName, DBObject query, Class targetClass) { + public List query(String collectionName, DBObject query, Class targetClass) { DBCollection collection = getDb().getCollection(collectionName); List results = new ArrayList(); for (DBObject dbo : collection.find(query)) { @@ -318,7 +318,7 @@ public class MongoTemplate implements InitializingBean { return results; } - public List queryForList(String collectionName, DBObject query, Class targetClass, MongoReader reader) { + public List query(String collectionName, DBObject query, Class targetClass, MongoReader reader) { DBCollection collection = getDb().getCollection(collectionName); List results = new ArrayList(); for (DBObject dbo : collection.find(query)) { diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/analytics/MvcAnalyticsTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/analytics/MvcAnalyticsTests.java index 1afaf6c17..69a5febb2 100644 --- a/spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/analytics/MvcAnalyticsTests.java +++ b/spring-data-mongodb/src/test/java/org/springframework/data/document/mongodb/analytics/MvcAnalyticsTests.java @@ -57,11 +57,11 @@ public class MvcAnalyticsTests { createAndStoreMvcEvent(3, 3); createAndStoreMvcEvent(8, 4); - List mvcEvents = mongoTemplate.queryForCollection("mvc", + List mvcEvents = mongoTemplate.getCollection("mvc", MvcEvent.class); Assert.assertEquals(22, mvcEvents.size()); - List mvcEvents2 = mongoTemplate.queryForCollection("mvc", MvcEvent.class, + List mvcEvents2 = mongoTemplate.getCollection("mvc", MvcEvent.class, new MongoReader() { public MvcEvent read(Class clazz, DBObject dbo) { return null; @@ -92,7 +92,7 @@ public class MvcAnalyticsTests { for (DBObject dbo : mongoTemplate.getCollection("counters").find(query)) { System.out.println(dbo); } - List counters = mongoTemplate.queryForList("counters", "{ 'name' : 'SignUpController'} ", ControllerCounter.class); + List counters = mongoTemplate.queryUsingJavaScript("counters", "{ 'name' : 'SignUpController'} ", ControllerCounter.class); for (ControllerCounter controllerCounter : counters) { System.out.println(controllerCounter); } @@ -108,7 +108,7 @@ public class MvcAnalyticsTests { @Test public void listAllMvcEvents() { - List mvcEvents = mongoTemplate.queryForCollection("mvc", + List mvcEvents = mongoTemplate.getCollection("mvc", MvcEvent.class); for (MvcEvent mvcEvent : mvcEvents) { System.out.println(mvcEvent.getDate());