From 96ff4e1d147f813fc58eea26fde8845f60ec9576 Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Fri, 24 Apr 2020 09:03:18 +0200 Subject: [PATCH] DATAMONGO-2461 - Polishing. Remove superfluous Test annotation as RepeatFailedTest acts as a TestTemplate so adding the Test annotation causes the test to run twice. --- .../core/ReactiveMongoTemplateIndexTests.java | 15 +++++---------- .../mongodb/core/messaging/ChangeStreamTests.java | 3 +-- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/ReactiveMongoTemplateIndexTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/ReactiveMongoTemplateIndexTests.java index 636dd05b1..a9865e2ec 100644 --- a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/ReactiveMongoTemplateIndexTests.java +++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/ReactiveMongoTemplateIndexTests.java @@ -82,8 +82,7 @@ public class ReactiveMongoTemplateIndexTests { @AfterEach void cleanUp() {} - @Test // DATAMONGO-1444 - @RepeatFailedTest(3) + @RepeatFailedTest(3) // DATAMONGO-1444 void testEnsureIndexShouldCreateIndex() { Person p1 = new Person("Oliver"); @@ -119,8 +118,7 @@ public class ReactiveMongoTemplateIndexTests { }).verifyComplete(); } - @Test // DATAMONGO-1444 - @RepeatFailedTest(3) + @RepeatFailedTest(3) // DATAMONGO-1444 void getIndexInfoShouldReturnCorrectIndex() { Person p1 = new Person("Oliver"); @@ -150,8 +148,7 @@ public class ReactiveMongoTemplateIndexTests { }).verifyComplete(); } - @Test // DATAMONGO-1444, DATAMONGO-2264 - @RepeatFailedTest(3) + @RepeatFailedTest(3) // DATAMONGO-1444, DATAMONGO-2264 void testReadIndexInfoForIndicesCreatedViaMongoShellCommands() { template.indexOps(Person.class).dropAllIndexes() // @@ -201,8 +198,7 @@ public class ReactiveMongoTemplateIndexTests { }).verifyComplete(); } - @Test // DATAMONGO-1928 - @RepeatFailedTest(3) + @RepeatFailedTest(3) // DATAMONGO-1928 void shouldCreateIndexOnAccess() { template.getCollection("indexedSample").flatMapMany(it -> it.listIndexes(Document.class)) // @@ -222,8 +218,7 @@ public class ReactiveMongoTemplateIndexTests { .verifyComplete(); } - @Test // DATAMONGO-1928, DATAMONGO-2264 - @RepeatFailedTest(3) + @RepeatFailedTest(3) // DATAMONGO-1928, DATAMONGO-2264 void indexCreationShouldFail() throws InterruptedException { factory.getMongoDatabase() // diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/messaging/ChangeStreamTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/messaging/ChangeStreamTests.java index 275f25895..435c89ca6 100644 --- a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/messaging/ChangeStreamTests.java +++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/messaging/ChangeStreamTests.java @@ -197,8 +197,7 @@ class ChangeStreamTests { assertThat(messageBodies).hasSize(2).doesNotContain(sugarSplashy); } - @Test // DATAMONGO-1803 - @RepeatFailedTest(3) + @RepeatFailedTest(3) // DATAMONGO-1803 void mapsTypedAggregationToFilterMessages() throws InterruptedException { CollectingMessageListener, User> messageListener = new CollectingMessageListener<>();