From 9eaf67148de725de598d3c43de1bec62c6b69c1a Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Mon, 11 Nov 2019 14:17:01 +0100 Subject: [PATCH] DATAMONGO-2385 - Polishing. Remove null checks for arguments known to be not-null. Remove Nullable annotations from methods that never return null. Original pull request: #802. --- .../data/mongodb/core/convert/MongoConverters.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MongoConverters.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MongoConverters.java index 9cd487234..70d367365 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MongoConverters.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MongoConverters.java @@ -211,7 +211,7 @@ abstract class MongoConverters { INSTANCE; public String convert(URL source) { - return source == null ? null : source.toString(); + return source.toString(); } } @@ -224,7 +224,7 @@ abstract class MongoConverters { public URL convert(String source) { try { - return source == null ? null : new URL(source); + return new URL(source); } catch (MalformedURLException e) { throw new ConversionFailedException(SOURCE, TARGET, source, e); } @@ -483,7 +483,6 @@ abstract class MongoConverters { INSTANCE; - @Nullable @Override public byte[] convert(Binary source) { return source.getData(); @@ -501,7 +500,6 @@ abstract class MongoConverters { INSTANCE; - @Nullable @Override public Instant convert(BsonTimestamp source) { return Instant.ofEpochSecond(source.getTime(), 0);