From d824ed7e72d715886a4b290d8a845949a7475d77 Mon Sep 17 00:00:00 2001 From: Oliver Gierke Date: Fri, 11 Mar 2011 19:01:05 +0100 Subject: [PATCH] DATACMNS-21 - Override Repository methods returning Iterable. As the MongoOperations currently only returns Lists anyway we can override the methods returning an Iterable to return List for now. --- .../mongodb/repository/MongoRepository.java | 21 ++++++++++++++++--- .../repository/SimpleMongoRepository.java | 7 +++---- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/repository/MongoRepository.java b/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/repository/MongoRepository.java index df832fb30..005e3d10b 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/repository/MongoRepository.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/repository/MongoRepository.java @@ -16,16 +16,31 @@ package org.springframework.data.document.mongodb.repository; import java.io.Serializable; +import java.util.List; +import org.springframework.data.domain.Sort; import org.springframework.data.repository.PagingAndSortingRepository; - /** * Mongo specific {@link org.springframework.data.repository.Repository} interface. * * @author Oliver Gierke */ -public interface MongoRepository extends - PagingAndSortingRepository { +public interface MongoRepository extends PagingAndSortingRepository { + /* + * (non-Javadoc) + * + * @see org.springframework.data.repository.Repository#findAll() + */ + @Override + List findAll(); + + /* + * (non-Javadoc) + * + * @see org.springframework.data.repository.PagingAndSortingRepository#findAll(org.springframework.data.domain.Sort) + */ + @Override + List findAll(Sort sort); } diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/repository/SimpleMongoRepository.java b/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/repository/SimpleMongoRepository.java index 94e6e2008..2ba914bb6 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/repository/SimpleMongoRepository.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/document/mongodb/repository/SimpleMongoRepository.java @@ -30,7 +30,6 @@ import org.springframework.data.domain.Page; import org.springframework.data.domain.PageImpl; import org.springframework.data.domain.Pageable; import org.springframework.data.domain.Sort; -import org.springframework.data.repository.PagingAndSortingRepository; import org.springframework.util.Assert; /** @@ -38,13 +37,13 @@ import org.springframework.util.Assert; * * @author Oliver Gierke */ -public class SimpleMongoRepository implements PagingAndSortingRepository { +public class SimpleMongoRepository implements MongoRepository { private final MongoTemplate template; private final MongoEntityInformation entityInformation; /** - * Creates a ew {@link SimpleMongoRepository} for the given {@link MongoInformation} and {@link MongoTemplate}. + * Creates a new {@link SimpleMongoRepository} for the given {@link MongoInformation} and {@link MongoTemplate}. * * @param metadata * @param template @@ -73,7 +72,7 @@ public class SimpleMongoRepository implements Paging * * @see org.springframework.data.repository.Repository#save(java.lang.Iterable) */ - public List save(Iterable entities) { + public Iterable save(Iterable entities) { List result = new ArrayList();