From fe5bb515b7612d8af852fadab747f7a4ed1b88e8 Mon Sep 17 00:00:00 2001 From: Kevin Dosey Date: Sat, 11 Jun 2016 10:03:28 -0400 Subject: [PATCH] DATAMONGO-1449 - Switched to foreach loop in collection handling of MappingMongoConverter. This should result in minor to moderate performance improvement for iteration on Collections/Arrays during DBObject to object mapping. Original pull request: #368. --- .../data/mongodb/core/convert/MappingMongoConverter.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java index 419915dac..a8df88a04 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java @@ -901,9 +901,7 @@ public class MappingMongoConverter extends AbstractMongoConverter implements App Collection items = targetType.getType().isArray() ? new ArrayList() : CollectionFactory.createCollection(collectionType, rawComponentType, sourceValue.size()); - for (int i = 0; i < sourceValue.size(); i++) { - - Object dbObjItem = sourceValue.get(i); + for (Object dbObjItem : sourceValue) { if (dbObjItem instanceof DBRef) { items.add(DBRef.class.equals(rawComponentType) ? dbObjItem