#13 - Polishing.

Add missing header & package-info. Update nullability and add tests.

Original pull request: #17.
This commit is contained in:
Christoph Strobl
2018-11-20 09:59:04 +01:00
committed by Mark Paluch
parent 6267047f17
commit 9f7d3863e5
20 changed files with 164 additions and 30 deletions

View File

@@ -1,3 +1,18 @@
/*
* Copyright 2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.r2dbc.repository.config;
/**

View File

@@ -1,3 +1,18 @@
/*
* Copyright 2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.r2dbc.repository.config;
import org.springframework.data.r2dbc.repository.R2dbcRepository;

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2016-2018 the original author or authors.
* Copyright 2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.r2dbc.repository.config;
import static org.mockito.Mockito.*;

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2016-2018 the original author or authors.
* Copyright 2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -29,6 +29,7 @@ import org.springframework.core.io.support.PathMatchingResourcePatternResolver;
import org.springframework.core.type.StandardAnnotationMetadata;
import org.springframework.data.r2dbc.repository.R2dbcRepository;
import org.springframework.data.relational.core.mapping.Table;
import org.springframework.data.repository.CrudRepository;
import org.springframework.data.repository.config.AnnotationRepositoryConfigurationSource;
import org.springframework.data.repository.config.RepositoryConfiguration;
import org.springframework.data.repository.config.RepositoryConfigurationSource;
@@ -38,6 +39,7 @@ import org.springframework.data.repository.reactive.ReactiveCrudRepository;
* Unit tests for {@link R2dbcRepositoryConfigurationExtension}.
*
* @author Mark Paluch
* @author Christoph Strobl
*/
public class R2dbcRepositoryConfigurationExtensionUnitTests {
@@ -71,6 +73,14 @@ public class R2dbcRepositoryConfigurationExtensionUnitTests {
extension.getRepositoryConfigurations(configurationSource, loader, true));
}
@Test // gh-13
public void doesNotHaveNonReactiveRepository() {
R2dbcRepositoryConfigurationExtension extension = new R2dbcRepositoryConfigurationExtension();
assertDoesNotHaveRepo(NonReactiveRepository.class,
extension.getRepositoryConfigurations(configurationSource, loader, true));
}
private static void assertHasRepo(Class<?> repositoryInterface,
Collection<RepositoryConfiguration<RepositoryConfigurationSource>> configs) {
@@ -107,4 +117,6 @@ public class R2dbcRepositoryConfigurationExtensionUnitTests {
interface UnannotatedRepository extends ReactiveCrudRepository<Store, Long> {}
interface StoreRepository extends R2dbcRepository<Store, Long> {}
interface NonReactiveRepository extends CrudRepository<Sample, Long> {}
}