Polishing.

Rename method to renderForGeneratedValues to reflect its intended usage and enhance documentation.

Tweak Javadoc.

Closes: #483
Original pull request: #602.

src/test/java/org/springframework/data/r2dbc/repository/H2R2dbcRepositoryWithMixedCaseNamesIntegrationTests.java

@@ -36,7 +36,7 @@ import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit.jupiter.SpringExtension;
 
 /**
- * Integration tests for {@link LegoSetRepository} with table and column names that contain * upper and lower case
+ * Integration tests for {@link LegoSetRepository} with table and column names that contain upper and lower case
  * characters against H2.
  *
  * @author Jens Schauder

src/test/java/org/springframework/data/r2dbc/repository/MariaDbR2dbcRepositoryWithMixedCaseNamesIntegrationTests.java

@@ -38,11 +38,10 @@ import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit.jupiter.SpringExtension;
 
 /**
- * Integration tests for {@link LegoSetRepository} with table and column names that contain * upper and lower case
+ * Integration tests for {@link LegoSetRepository} with table and column names that contain upper and lower case
  * characters against MariaDb.
  *
- * @author Mark Paluch
- * @author Zsombor Gegesy
+ * @author Jens Schauder
  */
 @ExtendWith(SpringExtension.class)
 @ContextConfiguration

src/test/java/org/springframework/data/r2dbc/repository/MySqlR2dbcRepositoryWithMixedCaseNamesIntegrationTests.java

@@ -23,15 +23,15 @@ import javax.sql.DataSource;
 
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.RegisterExtension;
+
 import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.FilterType;
-import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.data.r2dbc.config.AbstractR2dbcConfiguration;
 import org.springframework.data.r2dbc.convert.R2dbcCustomConversions;
 import org.springframework.data.r2dbc.mapping.R2dbcMappingContext;
 import org.springframework.data.r2dbc.repository.config.EnableR2dbcRepositories;
-import org.springframework.data.r2dbc.repository.support.R2dbcRepositoryFactory;
 import org.springframework.data.r2dbc.testing.ExternalDatabase;
 import org.springframework.data.r2dbc.testing.MySqlTestSupport;
 import org.springframework.data.relational.core.mapping.NamingStrategy;
@@ -39,11 +39,10 @@ import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit.jupiter.SpringExtension;
 
 /**
- * Integration tests for {@link LegoSetRepository} with table and column names that contain
- *  * upper and lower case characters against MySql.
+ * Integration tests for {@link LegoSetRepository} with table and column names that contain upper and lower case
+ * characters against MySql.
  *
- * @author Mark Paluch
- * @author Zsombor Gegesy
+ * @author Jens Schauder
  */
 @ExtendWith(SpringExtension.class)
 @ContextConfiguration

src/test/java/org/springframework/data/r2dbc/repository/OracleR2dbcRepositoryWithMixedCaseNamesIntegrationTests.java

@@ -23,6 +23,7 @@ import javax.sql.DataSource;
 
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.RegisterExtension;
+
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.Configuration;
@@ -31,7 +32,7 @@ import org.springframework.data.r2dbc.config.AbstractR2dbcConfiguration;
 import org.springframework.data.r2dbc.convert.R2dbcCustomConversions;
 import org.springframework.data.r2dbc.mapping.R2dbcMappingContext;
 import org.springframework.data.r2dbc.repository.config.EnableR2dbcRepositories;
-import org.springframework.data.r2dbc.repository.support.R2dbcRepositoryFactory;
+import org.springframework.data.r2dbc.testing.EnabledOnClass;
 import org.springframework.data.r2dbc.testing.ExternalDatabase;
 import org.springframework.data.r2dbc.testing.OracleTestSupport;
 import org.springframework.data.relational.core.mapping.NamingStrategy;
@@ -39,13 +40,14 @@ import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit.jupiter.SpringExtension;
 
 /**
- * Integration tests for {@link LegoSetRepository}  with table and column names that contain
- *  * upper and lower case characters against Oracle.
+ * Integration tests for {@link LegoSetRepository} with table and column names that contain upper and lower case
+ * characters against Oracle.
  *
  * @author Jens Schauder
  */
 @ExtendWith(SpringExtension.class)
 @ContextConfiguration
+@EnabledOnClass("oracle.r2dbc.impl.OracleConnectionFactoryProviderImpl")
 public class OracleR2dbcRepositoryWithMixedCaseNamesIntegrationTests
 		extends AbstractR2dbcRepositoryWithMixedCaseNamesIntegrationTests {
 

src/test/java/org/springframework/data/r2dbc/repository/PostgresR2dbcRepositoryWithMixedCaseNamesIntegrationTests.java

@@ -23,15 +23,15 @@ import javax.sql.DataSource;
 
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.RegisterExtension;
+
 import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.FilterType;
-import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.data.r2dbc.config.AbstractR2dbcConfiguration;
 import org.springframework.data.r2dbc.convert.R2dbcCustomConversions;
 import org.springframework.data.r2dbc.mapping.R2dbcMappingContext;
 import org.springframework.data.r2dbc.repository.config.EnableR2dbcRepositories;
-import org.springframework.data.r2dbc.repository.support.R2dbcRepositoryFactory;
 import org.springframework.data.r2dbc.testing.ExternalDatabase;
 import org.springframework.data.r2dbc.testing.PostgresTestSupport;
 import org.springframework.data.relational.core.mapping.NamingStrategy;
@@ -39,8 +39,8 @@ import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit.jupiter.SpringExtension;
 
 /**
- * Integration tests for {@link LegoSetRepository} with table and column names that contain
- *  * upper and lower case characters against Postgres.
+ * Integration tests for {@link LegoSetRepository} with table and column names that contain upper and lower case
+ * characters against Postgres.
  *
  * @author Jens Schauder
  */

src/test/java/org/springframework/data/r2dbc/repository/SqlServerR2dbcRepositoryWithMixedCaseNamesIntegrationTests.java

@@ -23,6 +23,7 @@ import javax.sql.DataSource;
 
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.RegisterExtension;
+
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.Configuration;
@@ -31,7 +32,6 @@ import org.springframework.data.r2dbc.config.AbstractR2dbcConfiguration;
 import org.springframework.data.r2dbc.convert.R2dbcCustomConversions;
 import org.springframework.data.r2dbc.mapping.R2dbcMappingContext;
 import org.springframework.data.r2dbc.repository.config.EnableR2dbcRepositories;
-import org.springframework.data.r2dbc.repository.support.R2dbcRepositoryFactory;
 import org.springframework.data.r2dbc.testing.ExternalDatabase;
 import org.springframework.data.r2dbc.testing.SqlServerTestSupport;
 import org.springframework.data.relational.core.mapping.NamingStrategy;
@@ -39,8 +39,8 @@ import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit.jupiter.SpringExtension;
 
 /**
- * Integration tests for {@link LegoSetRepository} with table and column names that contain
- *  * upper and lower case characters against SQL-Server.
+ * Integration tests for {@link LegoSetRepository} with table and column names that contain upper and lower case
+ * characters against SQL-Server.
  *
  * @author Jens Schauder
  */

src/test/java/org/springframework/data/r2dbc/testing/ExternalDatabase.java

@@ -222,7 +222,7 @@ public abstract class ExternalDatabase implements BeforeAllCallback {
 		 */
 		@Override
 		public String getHostname() {
-			return "unknown";
+			throw new UnsupportedOperationException(getClass().getSimpleName());
 		}
 
 		/* (non-Javadoc)
@@ -230,7 +230,7 @@ public abstract class ExternalDatabase implements BeforeAllCallback {
 		 */
 		@Override
 		public int getPort() {
-			return -99999;
+			throw new UnsupportedOperationException(getClass().getSimpleName());
 		}
 
 		/* (non-Javadoc)