Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
Reorder methods. Move rewriteConfig directly implemented on connection to DefaultedRedisConnection respective DefaultedRedisClusterConnection.

Add overload to run config rewrite on individual cluster nodes. Add tests. Add since tags and update Javadoc.

See #1992
Original pull request: #2012.
This commit is contained in:
Mark Paluch
2021-03-29 11:39:39 +02:00
parent 2d56eaf3c6
commit 0f6a152295
13 changed files with 134 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/test/java/org/springframework/data/redis/connection/jedis/JedisClusterConnectionUnitTests.java
View File

@@ -333,6 +333,27 @@ class JedisClusterConnectionUnitTests {
verify(con3Mock, never()).configResetStat();
}
@Test // GH-1992
void rewriteConfigShouldBeExecutedOnAllNodes() {
connection.rewriteConfig();
verify(con1Mock, times(1)).configRewrite();
verify(con2Mock, times(1)).configRewrite();
verify(con3Mock, times(1)).configRewrite();
}
@Test // GH-1992
void rewriteConfigShouldBeExecutedOnSingleNodeCorrectly() {
connection.rewriteConfig(CLUSTER_NODE_2);
verify(con2Mock, times(1)).configRewrite();
verify(con2Mock, atLeast(1)).close();
verify(con1Mock, never()).configRewrite();
verify(con3Mock, never()).configRewrite();
}
@Test // DATAREDIS-315
void clusterTopologyProviderShouldCollectErrorsWhenLoadingNodes() {

20
src/test/java/org/springframework/data/redis/connection/lettuce/LettuceClusterConnectionUnitTests.java
View File

@@ -357,6 +357,26 @@ class LettuceClusterConnectionUnitTests {
verify(clusterConnection1Mock, never()).configResetstat();
}
@Test // GH-1992
void rewriteConfigShouldBeExecutedOnAllNodes() {
connection.rewriteConfig();
verify(clusterConnection1Mock, times(1)).configRewrite();
verify(clusterConnection2Mock, times(1)).configRewrite();
verify(clusterConnection3Mock, times(1)).configRewrite();
}
@Test // GH-1992
void rewriteConfigShouldBeExecutedOnSingleNodeCorrectly() {
connection.rewriteConfig(CLUSTER_NODE_2);
verify(clusterConnection2Mock, times(1)).configRewrite();
verify(clusterConnection1Mock, never()).configRewrite();
verify(clusterConnection1Mock, never()).configRewrite();
}
@Test // DATAREDIS-731, DATAREDIS-545
void shouldExecuteOnSharedConnection() {