Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREDIS-728 - Fix unnecessary initial caches map creation in RedisCacheManagerBuilder.

Browse Source 
We now reuse the initially created map and add or replace initial configurations in place instead of creating each time a new map.

Original pull request: #293.
This commit is contained in:
Kezhu Wang
2017-11-08 00:35:24 +08:00
committed by Mark Paluch
parent d129e6550d
commit 1504c76c2e
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/org/springframework/data/redis/cache/RedisCacheManager.java vendored
View File

@@ -221,7 +221,7 @@ public class RedisCacheManager extends AbstractTransactionSupportingCacheManager
private final RedisCacheWriter cacheWriter;
private RedisCacheConfiguration defaultCacheConfiguration = RedisCacheConfiguration.defaultCacheConfig();
private Map<String, RedisCacheConfiguration> intialCaches = new LinkedHashMap<>();
private final Map<String, RedisCacheConfiguration> intialCaches = new LinkedHashMap<>();
private boolean enableTransactions;
private RedisCacheManagerBuilder(RedisCacheWriter cacheWriter) {
@@ -312,10 +312,7 @@ public class RedisCacheManager extends AbstractTransactionSupportingCacheManager
cacheConfigurations.forEach((cacheName, configuration) -> Assert.notNull(configuration,
String.format("RedisCacheConfiguration for cache %s must not be null!", cacheName)));
Map<String, RedisCacheConfiguration> cacheConfigMap = new LinkedHashMap<>(intialCaches);
cacheConfigMap.putAll(cacheConfigurations);
this.intialCaches = cacheConfigMap;
this.intialCaches.putAll(cacheConfigurations);
return this;
}