Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add support for BitFieldSubCommands that generate multiple bit operations using non-chaining methods.

Browse Source 
Original pull request: #2060.
Closes #2055
This commit is contained in:
yanam
2021-05-07 21:51:44 +08:00
committed by Mark Paluch
parent 7cd0669e86
commit 1750b2a2d4
2 changed files with 105 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/test/java/org/springframework/data/redis/connection/BitFieldSubCommandsUnitTests.java
View File

@@ -22,10 +22,14 @@ import static org.assertj.core.api.Assertions.*;
import org.springframework.data.redis.connection.BitFieldSubCommands.BitFieldType;
import java.util.ArrayList;
import java.util.List;
/**
* Unit tests for {@link BitFieldSubCommands}.
*
* @author Mark Paluch
* @author Yanam
*/
class BitFieldSubCommandsUnitTests {
@@ -46,4 +50,34 @@ class BitFieldSubCommandsUnitTests {
assertThat(type.isSigned()).isFalse();
assertThat(type.getBits()).isEqualTo(10);
}
@Test //ISSUES #2055
void shouldCreateBitCommandsWithChainingMethod(){
BitFieldType type = BitFieldType.unsigned(1);
BitFieldSubCommands bitFieldSubCommands = BitFieldSubCommands.create()
.get(type).valueAt(BitFieldSubCommands.Offset.offset(1))
.get(type).valueAt(BitFieldSubCommands.Offset.offset(2))
.set(type).valueAt(BitFieldSubCommands.Offset.offset(3)).to(1)
.set(type).valueAt(BitFieldSubCommands.Offset.offset(4)).to(1)
.incr(type).valueAt(BitFieldSubCommands.Offset.offset(5)).by(1);
assertThat(bitFieldSubCommands.getSubCommands().size()).isEqualTo(5);
}
@Test //ISSUES #2055
void shouldCreateBitCommandsWithNonChainingMethod(){
BitFieldType type = BitFieldType.unsigned(1);
BitFieldSubCommands.Offset offset = BitFieldSubCommands.Offset.offset(1);
BitFieldSubCommands.BitFieldSubCommand subGetCommand = BitFieldSubCommands.BitFieldGet.create(type,offset);
BitFieldSubCommands.BitFieldSubCommand subSetCommand = BitFieldSubCommands.BitFieldSet.create(type,offset,1);
BitFieldSubCommands.BitFieldSubCommand subIncrByCommand = BitFieldSubCommands.BitFieldIncrBy.create(type,offset,1);
BitFieldSubCommands.BitFieldSubCommand subIncrByCommand2 = BitFieldSubCommands.BitFieldIncrBy.create(type,offset,1,BitFieldSubCommands.BitFieldIncrBy.Overflow.FAIL);
BitFieldSubCommands bitFieldSubCommands = BitFieldSubCommands.create(subGetCommand,subSetCommand,subIncrByCommand,subIncrByCommand2);
assertThat(bitFieldSubCommands.getSubCommands().size()).isEqualTo(4);
}
}