diff --git a/src/main/kotlin/org/springframework/data/redis/core/ReactiveZSetOperationsExtensions.kt b/src/main/kotlin/org/springframework/data/redis/core/ReactiveZSetOperationsExtensions.kt index b7c55e149..68fc68b84 100644 --- a/src/main/kotlin/org/springframework/data/redis/core/ReactiveZSetOperationsExtensions.kt +++ b/src/main/kotlin/org/springframework/data/redis/core/ReactiveZSetOperationsExtensions.kt @@ -102,8 +102,8 @@ fun ReactiveZSetOperations.rangeWithScoresAsFlow(key: K * @author Sebastien Deleuze * @since 2.2 */ -fun ReactiveZSetOperations.rangeByScoreAsFlow(key: K, range: Range, limit: Limit? = null): Flow = - (if (limit == null) rangeByScore(key, range) else rangeByScore(key, range, limit)).asFlow() +fun ReactiveZSetOperations.rangeByScoreAsFlow(key: K, range: Range, limit: Limit = Limit.unlimited()): Flow = + rangeByScore(key, range, limit).asFlow() /** * Coroutines variant of [ReactiveZSetOperations.rangeByScoreWithScores]. @@ -111,8 +111,8 @@ fun ReactiveZSetOperations.rangeByScoreAsFlow(key: K, r * @author Sebastien Deleuze * @since 2.2 */ -fun ReactiveZSetOperations.rangeByScoreWithScoresAsFlow(key: K, range: Range, limit: Limit? = null): Flow> = - (if (limit == null) rangeByScoreWithScores(key, range) else rangeByScoreWithScores(key, range, limit)).asFlow() +fun ReactiveZSetOperations.rangeByScoreWithScoresAsFlow(key: K, range: Range, limit: Limit = Limit.unlimited()): Flow> = + rangeByScoreWithScores(key, range, limit).asFlow() /** * Coroutines variant of [ReactiveZSetOperations.reverseRange]. @@ -138,8 +138,8 @@ fun ReactiveZSetOperations.reverseRangeWithScoresAsFlow * @author Sebastien Deleuze * @since 2.2 */ -fun ReactiveZSetOperations.reverseRangeByScoreAsFlow(key: K, range: Range, limit: Limit? = null): Flow = - (if (limit == null) reverseRangeByScore(key, range) else reverseRangeByScore(key, range, limit)).asFlow() +fun ReactiveZSetOperations.reverseRangeByScoreAsFlow(key: K, range: Range, limit: Limit = Limit.unlimited()): Flow = + reverseRangeByScore(key, range, limit).asFlow() /** * Coroutines variant of [ReactiveZSetOperations.reverseRangeByScoreWithScores]. @@ -147,8 +147,8 @@ fun ReactiveZSetOperations.reverseRangeByScoreAsFlow(ke * @author Sebastien Deleuze * @since 2.2 */ -fun ReactiveZSetOperations.reverseRangeByScoreWithScoresAsFlow(key: K, range: Range, limit: Limit? = null): Flow> = - (if (limit == null) reverseRangeByScoreWithScores(key, range) else reverseRangeByScoreWithScores(key, range, limit)).asFlow() +fun ReactiveZSetOperations.reverseRangeByScoreWithScoresAsFlow(key: K, range: Range, limit: Limit = Limit.unlimited()): Flow> = + reverseRangeByScoreWithScores(key, range, limit).asFlow() /** * Coroutines variant of [ReactiveZSetOperations.count]. @@ -273,8 +273,8 @@ suspend fun ReactiveZSetOperations.intersectAndStoreAnd * @author Wonwoo Lee * @since 2.3 */ -fun ReactiveZSetOperations.rangeByLexAndAwait(key: K, range: Range, limit: Limit? = null): Flow = - (if (limit == null) rangeByLex(key, range) else rangeByLex(key, range, limit)).asFlow() +fun ReactiveZSetOperations.rangeByLexAndAwait(key: K, range: Range, limit: Limit = Limit.unlimited()): Flow = + rangeByLex(key, range, limit).asFlow() /** * Coroutines variant of [ReactiveZSetOperations.reverseRangeByLex]. @@ -282,8 +282,8 @@ fun ReactiveZSetOperations.rangeByLexAndAwait(key: K, r * @author Wonwoo Lee * @since 2.3 */ -fun ReactiveZSetOperations.reverseRangeByLexAndAwait(key: K, range: Range, limit: Limit? = null): Flow = - (if (limit == null) reverseRangeByLex(key, range) else reverseRangeByLex(key, range, limit)).asFlow() +fun ReactiveZSetOperations.reverseRangeByLexAndAwait(key: K, range: Range, limit: Limit = Limit.unlimited()): Flow = + reverseRangeByLex(key, range, limit).asFlow() /** * Coroutines variant of [ReactiveZSetOperations.delete]. diff --git a/src/test/kotlin/org/springframework/data/redis/core/ReactiveListOperationsExtensionsUnitTests.kt b/src/test/kotlin/org/springframework/data/redis/core/ReactiveListOperationsExtensionsUnitTests.kt index 1203a0cdc..f7414616b 100644 --- a/src/test/kotlin/org/springframework/data/redis/core/ReactiveListOperationsExtensionsUnitTests.kt +++ b/src/test/kotlin/org/springframework/data/redis/core/ReactiveListOperationsExtensionsUnitTests.kt @@ -31,6 +31,7 @@ import java.time.Duration * * @author Mark Paluch * @author Sebastien Deleuze + * @author Wonwoo Lee */ class ReactiveListOperationsExtensionsUnitTests { @@ -334,7 +335,7 @@ class ReactiveListOperationsExtensionsUnitTests { } } - @Test + @Test // DATAREDIS-1111 fun rightPopAndLeftPush() { val operations = mockk>() @@ -349,7 +350,7 @@ class ReactiveListOperationsExtensionsUnitTests { } } - @Test + @Test // DATAREDIS-1111 fun blockingRightPopAndLeftPush() { val operations = mockk>() diff --git a/src/test/kotlin/org/springframework/data/redis/core/ReactiveZSetOperationsExtensionsUnitTests.kt b/src/test/kotlin/org/springframework/data/redis/core/ReactiveZSetOperationsExtensionsUnitTests.kt index f33b21c10..80eacf676 100644 --- a/src/test/kotlin/org/springframework/data/redis/core/ReactiveZSetOperationsExtensionsUnitTests.kt +++ b/src/test/kotlin/org/springframework/data/redis/core/ReactiveZSetOperationsExtensionsUnitTests.kt @@ -23,6 +23,7 @@ import kotlinx.coroutines.runBlocking import org.assertj.core.api.Assertions.assertThat import org.junit.Test import org.springframework.data.domain.Range +import org.springframework.data.redis.connection.RedisZSetCommands import org.springframework.data.redis.connection.RedisZSetCommands.Aggregate import org.springframework.data.redis.connection.RedisZSetCommands.Weights import org.springframework.data.redis.core.ZSetOperations.* @@ -34,6 +35,7 @@ import reactor.core.publisher.Mono * * @author Mark Paluch * @author Christoph Strobl + * @author Wonwoo Lee */ class ReactiveZSetOperationsExtensionsUnitTests { @@ -195,14 +197,14 @@ class ReactiveZSetOperationsExtensionsUnitTests { val range = Range.unbounded() val operations = mockk>() - every { operations.rangeByScore(any(), any()) } returns Flux.just("bar") + every { operations.rangeByScore(any(), any(), any()) } returns Flux.just("bar") runBlocking { assertThat(operations.rangeByScoreAsFlow("foo", range).toList()).contains("bar") } verify { - operations.rangeByScore("foo", range) + operations.rangeByScore("foo", range, RedisZSetCommands.Limit.unlimited()) } } @@ -212,14 +214,14 @@ class ReactiveZSetOperationsExtensionsUnitTests { val tuple = mockk>(relaxed = true) val range = Range.unbounded() val operations = mockk>() - every { operations.rangeByScoreWithScores(any(), any()) } returns Flux.just(tuple) + every { operations.rangeByScoreWithScores(any(), any(), any()) } returns Flux.just(tuple) runBlocking { assertThat(operations.rangeByScoreWithScoresAsFlow("foo", range).toList()).contains(tuple) } verify { - operations.rangeByScoreWithScores("foo", range) + operations.rangeByScoreWithScores("foo", range, RedisZSetCommands.Limit.unlimited()) } } @@ -261,14 +263,14 @@ class ReactiveZSetOperationsExtensionsUnitTests { val range = Range.unbounded() val operations = mockk>() - every { operations.reverseRangeByScore(any(), any()) } returns Flux.just("bar") + every { operations.reverseRangeByScore(any(), any(), any()) } returns Flux.just("bar") runBlocking { assertThat(operations.reverseRangeByScoreAsFlow("foo", range).toList()).contains("bar") } verify { - operations.reverseRangeByScore("foo", range) + operations.reverseRangeByScore("foo", range, RedisZSetCommands.Limit.unlimited()) } } @@ -278,14 +280,14 @@ class ReactiveZSetOperationsExtensionsUnitTests { val tuple = mockk>(relaxed = true) val range = Range.unbounded() val operations = mockk>() - every { operations.reverseRangeByScoreWithScores(any(), any()) } returns Flux.just(tuple) + every { operations.reverseRangeByScoreWithScores(any(), any(), any()) } returns Flux.just(tuple) runBlocking { assertThat(operations.reverseRangeByScoreWithScoresAsFlow("foo", range).toList()).contains(tuple) } verify { - operations.reverseRangeByScoreWithScores("foo", range) + operations.reverseRangeByScoreWithScores("foo", range, RedisZSetCommands.Limit.unlimited()) } } @@ -304,7 +306,7 @@ class ReactiveZSetOperationsExtensionsUnitTests { } } - @Test + @Test // DATAREDIS-1111 fun size() { val operations = mockk>() @@ -499,37 +501,37 @@ class ReactiveZSetOperationsExtensionsUnitTests { } } - @Test + @Test // DATAREDIS-1111 fun rangeByLex() { val operations = mockk>() - every { operations.rangeByLex(any(), any()) } returns Flux.just("bar") + every { operations.rangeByLex(any(), any(), any()) } returns Flux.just("bar") runBlocking { assertThat(operations.rangeByLexAndAwait("foo", Range.just("bar")).toList()).contains("bar") } verify { - operations.rangeByLex("foo", Range.just("bar")) + operations.rangeByLex("foo", Range.just("bar"), RedisZSetCommands.Limit.unlimited()) } } - @Test + @Test // DATAREDIS-1111 fun reverseRangeByLexAndAwait() { val operations = mockk>() - every { operations.reverseRangeByLex(any(), any()) } returns Flux.just("bar") + every { operations.reverseRangeByLex(any(), any(), any()) } returns Flux.just("bar") runBlocking { assertThat(operations.reverseRangeByLexAndAwait("foo", Range.just("bar")).toList()).contains("bar") } verify { - operations.reverseRangeByLex("foo", Range.just("bar")) + operations.reverseRangeByLex("foo", Range.just("bar"), RedisZSetCommands.Limit.unlimited()) } } - @Test + @Test // DATAREDIS-1111 fun delete() { val operations = mockk>()