Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix for (hash) increment treats long values as int

Browse Source 
While the (hash) increment() method accepts a long argument (and Redis
HINCRBY/INCRBY/DECRBY treats arguments as 64 bits), it is cast to a
32bits signed int in the JedisConnection class.

 - Removed offensive (& unnecessary) casts

 - Extended integration tests with incrBy, decrBy and hIncrBy to
   demonstrate handling of large numbers

 - Fixed typos in test support
   (CollectionTestParams, AbstractConnectionIntegrationTests)

Issue: DATAREDIS-117
This commit is contained in:
Tijn Porcelijn
2013-02-21 17:13:31 +01:00
committed by Tijn Porcelijn
parent cc354f8552
commit 27a7ab0738
5 changed files with 42 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/main/java/org/springframework/data/redis/connection/jedis/JedisConnection.java
View File

@@ -1048,14 +1048,14 @@ public class JedisConnection implements RedisConnection {
public Long decrBy(byte[] key, long value) {
try {
if (isQueueing()) {
transaction.decrBy(key, (int) value);
transaction.decrBy(key, value);
return null;
}
if (isPipelined()) {
pipeline.decrBy(key, (int) value);
pipeline.decrBy(key, value);
return null;
}
return jedis.decrBy(key, (int) value);
return jedis.decrBy(key, value);
} catch (Exception ex) {
throw convertJedisAccessException(ex);
}
@@ -1082,14 +1082,14 @@ public class JedisConnection implements RedisConnection {
public Long incrBy(byte[] key, long value) {
try {
if (isQueueing()) {
transaction.incrBy(key, (int) value);
transaction.incrBy(key, value);
return null;
}
if (isPipelined()) {
pipeline.incrBy(key, (int) value);
pipeline.incrBy(key, value);
return null;
}
return jedis.incrBy(key, (int) value);
return jedis.incrBy(key, value);
} catch (Exception ex) {
throw convertJedisAccessException(ex);
}
@@ -2254,14 +2254,14 @@ public class JedisConnection implements RedisConnection {
public Long hIncrBy(byte[] key, byte[] field, long delta) {
try {
if (isQueueing()) {
transaction.hincrBy(key, field, (int) delta);
transaction.hincrBy(key, field, delta);
return null;
}
if (isPipelined()) {
pipeline.hincrBy(key, field, (int) delta);
pipeline.hincrBy(key, field, delta);
return null;
}
return jedis.hincrBy(key, field, (int) delta);
return jedis.hincrBy(key, field, delta);
} catch (Exception ex) {
throw convertJedisAccessException(ex);
}
@@ -2437,4 +2437,4 @@ public class JedisConnection implements RedisConnection {
throw new RedisSubscribedConnectionException("Cannot execute command - connection is subscribed");
}
}
}
}