Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREDIS-705 - Polishing.

Browse Source 
Change return type for mset from void to Boolean. Add missing Nullable annotations. Add Javadoc.

Disable flakey tests for now.

Related pull request: #279.
This commit is contained in:
Mark Paluch
2017-10-02 10:02:49 +02:00
parent d002445d98
commit 30e531dc6e
10 changed files with 69 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/java/org/springframework/data/redis/connection/RedisConnectionUnitTests.java
View File

@@ -480,8 +480,8 @@ public class RedisConnectionUnitTests {
delegate.openPipeline();
}
public void mSet(Map<byte[], byte[]> tuple) {
delegate.mSet(tuple);
public Boolean mSet(Map<byte[], byte[]> tuple) {
return delegate.mSet(tuple);
}
public byte[] lIndex(byte[] key, long index) {

3
src/test/java/org/springframework/data/redis/connection/lettuce/LettuceReactiveClusterServerCommandsTests.java
View File

@@ -19,6 +19,7 @@ import static org.assertj.core.api.Assertions.*;
import static org.springframework.data.redis.connection.ClusterTestVariables.*;
import static org.springframework.data.redis.connection.lettuce.LettuceReactiveCommandsTestsBase.*;
import org.junit.Ignore;
import reactor.test.StepVerifier;
import org.junit.Test;
@@ -40,11 +41,13 @@ public class LettuceReactiveClusterServerCommandsTests extends LettuceReactiveCl
}
@Test // DATAREDIS-659
@Ignore("DATAREDIS-708, Causes ERR Background append only file rewriting already")
public void bgReWriteAofShouldRespondCorrectly() {
StepVerifier.create(connection.serverCommands().bgReWriteAof(NODE1)).expectNextCount(1).verifyComplete();
}
@Test // DATAREDIS-659
@Ignore("DATAREDIS-708, Causes ERR Background append only file rewriting already")
public void bgSaveShouldRespondCorrectly() {
StepVerifier.create(connection.serverCommands().bgSave(NODE1)).expectNextCount(1).verifyComplete();
}

3
src/test/java/org/springframework/data/redis/connection/lettuce/LettuceReactiveServerCommandsTests.java
View File

@@ -18,6 +18,7 @@ package org.springframework.data.redis.connection.lettuce;
import static org.assertj.core.api.Assertions.*;
import static org.junit.Assume.*;
import org.junit.Ignore;
import reactor.test.StepVerifier;
import org.junit.Test;
@@ -34,11 +35,13 @@ public class LettuceReactiveServerCommandsTests extends LettuceReactiveCommandsT
}
@Test // DATAREDIS-659
@Ignore("DATAREDIS-708, Causes ERR Background append only file rewriting already")
public void bgReWriteAofShouldRespondCorrectly() {
StepVerifier.create(connection.serverCommands().bgReWriteAof()).expectNextCount(1).verifyComplete();
}
@Test // DATAREDIS-659, DATAREDIS-667
@Ignore("DATAREDIS-708, Causes ERR Background append only file rewriting already")
public void bgSaveShouldRespondCorrectly() {
assumeTrue(connectionProvider instanceof StandaloneConnectionProvider);