DATAREDIS-270 - Add support for 'CLIENT GETNAME'.
Support for getting client connection name has been added for 'jedis', 'jredis' and 'srp' drivers. Using 'jredis' will throw 'UnsupportedOperationException'. Original Pull Request: #51
This commit is contained in:
committed by
Thomas Darimont
parent
e280a23550
commit
4bf438f563
@@ -1720,6 +1720,16 @@ public class DefaultStringRedisConnectionTests {
|
||||
verify(nativeConnection, times(1)).setClientName(eq("foo".getBytes()));
|
||||
}
|
||||
|
||||
/**
|
||||
* @see DATAREDIS-270
|
||||
*/
|
||||
@Test
|
||||
public void testGetClientNameIsDelegatedCorrectlyToNativeConnection() {
|
||||
|
||||
actual.add(connection.getClientName());
|
||||
verify(nativeConnection, times(1)).getClientName();
|
||||
}
|
||||
|
||||
protected List<Object> getResults() {
|
||||
return actual;
|
||||
}
|
||||
|
||||
@@ -123,6 +123,17 @@ public class JedisConnectionUnitTestSuite {
|
||||
connection.killClient("127.0.0.1", 1001);
|
||||
verifyNativeConnectionInvocation().clientKill(eq("127.0.0.1:1001"));
|
||||
}
|
||||
|
||||
/**
|
||||
* @see DATAREDIS-270
|
||||
*/
|
||||
@Test
|
||||
public void getClientNameShouldSendRequestCorrectly() {
|
||||
|
||||
connection.getClientName();
|
||||
verifyNativeConnectionInvocation().clientGetname();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
public static class JedisConnectionPipelineUnitTests extends JedisConnectionUnitTests {
|
||||
@@ -151,10 +162,23 @@ public class JedisConnectionUnitTestSuite {
|
||||
super.shutdownSaveShouldBeSentCorrectlyUsingLuaScript();
|
||||
}
|
||||
|
||||
/**
|
||||
* @see DATAREDIS-267
|
||||
*/
|
||||
@Test(expected = UnsupportedOperationException.class)
|
||||
public void killClientShouldDelegateCallCorrectly() {
|
||||
super.killClientShouldDelegateCallCorrectly();
|
||||
}
|
||||
|
||||
/**
|
||||
* @see DATAREDIS-270
|
||||
*/
|
||||
@Override
|
||||
@Test(expected = UnsupportedOperationException.class)
|
||||
public void getClientNameShouldSendRequestCorrectly() {
|
||||
super.getClientNameShouldSendRequestCorrectly();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -56,4 +56,13 @@ public class JRedisConnectionUnitTests extends AbstractConnectionUnitTestBase<JR
|
||||
public void shutdownWithNullShouldThrowUnsupportedOperationException() {
|
||||
connection.shutdown(null);
|
||||
}
|
||||
|
||||
/**
|
||||
* @see DATAREDIS-270
|
||||
*/
|
||||
@Test(expected = UnsupportedOperationException.class)
|
||||
public void getClientNameShouldSendRequestCorrectly() {
|
||||
connection.getClientName();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -93,6 +93,16 @@ public class LettuceConnectionUnitTestSuite {
|
||||
verifyNativeConnectionInvocation().clientKill(eq(ipPort));
|
||||
}
|
||||
|
||||
/**
|
||||
* @see DATAREDIS-270
|
||||
*/
|
||||
@Test
|
||||
public void getClientNameShouldSendRequestCorrectly() {
|
||||
|
||||
connection.getClientName();
|
||||
verifyNativeConnectionInvocation().clientGetname();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
public static class LettucePipelineConnectionUnitTests extends LettuceConnectionUnitTests {
|
||||
|
||||
@@ -89,6 +89,16 @@ public class SrpConnectionUnitTestSuite {
|
||||
verifyNativeConnectionInvocation().client_kill(eq(ipPort));
|
||||
}
|
||||
|
||||
/**
|
||||
* @see DATAREDIS-270
|
||||
*/
|
||||
@Test
|
||||
public void getClientNameShouldSendRequestCorrectly() {
|
||||
|
||||
connection.getClientName();
|
||||
verifyNativeConnectionInvocation().client_getname();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
public static class SrpConnectionPiplineUnitTests extends AbstractConnectionUnitTestBase<Pipeline> {
|
||||
@@ -135,6 +145,16 @@ public class SrpConnectionUnitTestSuite {
|
||||
verifyNativeConnectionInvocation().shutdown("NOSAVE".getBytes(Charsets.UTF_8), null);
|
||||
}
|
||||
|
||||
/**
|
||||
* @see DATAREDIS-270
|
||||
*/
|
||||
@Test
|
||||
public void getClientNameShouldSendRequestCorrectly() {
|
||||
|
||||
connection.getClientName();
|
||||
verifyNativeConnectionInvocation().client_getname();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user