Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREDIS-1091 - Add configuration to disable storage of shadow copies for entities using TimeToLive.

Browse Source 
Original pull request: #517.
This commit is contained in:
Christoph Strobl
2020-03-19 14:33:18 +01:00
committed by Mark Paluch
parent 2f0a5600dc
commit 546ebda2f2
5 changed files with 136 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
src/test/java/org/springframework/data/redis/core/RedisKeyValueAdapterTests.java
View File

@@ -37,7 +37,6 @@ import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
import org.springframework.beans.factory.InitializingBean;
import org.springframework.data.annotation.Id;
import org.springframework.data.annotation.Reference;
@@ -50,6 +49,7 @@ import org.springframework.data.redis.connection.RedisConnectionFactory;
import org.springframework.data.redis.connection.lettuce.LettuceConnectionFactory;
import org.springframework.data.redis.connection.lettuce.LettuceTestClientResources;
import org.springframework.data.redis.core.RedisKeyValueAdapter.EnableKeyspaceEvents;
import org.springframework.data.redis.core.RedisKeyValueAdapter.ShadowCopy;
import org.springframework.data.redis.core.convert.KeyspaceConfiguration;
import org.springframework.data.redis.core.convert.MappingConfiguration;
import org.springframework.data.redis.core.index.GeoIndexed;
@@ -341,7 +341,6 @@ public class RedisKeyValueAdapterTests {
assertThat(template.hasKey("persons:firstname:rand")).isFalse();
assertThat(template.hasKey("persons:1:idx")).isFalse();
assertThat(template.opsForSet().members("persons")).doesNotContain("1");
;
}
@Test // DATAREDIS-744
@@ -687,6 +686,56 @@ public class RedisKeyValueAdapterTests {
assertThat(updatedLocation.getY()).isCloseTo(18D, offset(0.005));
}
@Test // DATAREDIS-1091
public void phantomKeyNotInsertedOnPutWhenShadowCopyIsTurnedOff() {
RedisMappingContext mappingContext = new RedisMappingContext(
new MappingConfiguration(new IndexConfiguration(), new KeyspaceConfiguration()));
mappingContext.afterPropertiesSet();
RedisKeyValueAdapter kvAdapter = new RedisKeyValueAdapter(template, mappingContext);
kvAdapter.setShadowCopy(ShadowCopy.OFF);
ExpiringPerson rand = new ExpiringPerson();
rand.age = 24;
rand.ttl = 3000L;
kvAdapter.put("1", rand, "persons");
assertThat(template.hasKey("persons:1:phantom")).isFalse();
}
@Test // DATAREDIS-1091
public void phantomKeyInsertedOnPutWhenShadowCopyIsTurnedOn() {
RedisMappingContext mappingContext = new RedisMappingContext(
new MappingConfiguration(new IndexConfiguration(), new KeyspaceConfiguration()));
mappingContext.afterPropertiesSet();
RedisKeyValueAdapter kvAdapter = new RedisKeyValueAdapter(template, mappingContext);
kvAdapter.setShadowCopy(ShadowCopy.ON);
ExpiringPerson rand = new ExpiringPerson();
rand.age = 24;
rand.ttl = 3000L;
kvAdapter.put("1", rand, "persons");
assertThat(template.hasKey("persons:1:phantom")).isTrue();
}
@Test // DATAREDIS-1091
public void phantomKeyInsertedOnPutWhenShadowCopyIsInDefaultAndKeyspaceNotificationEnabled() {
ExpiringPerson rand = new ExpiringPerson();
rand.age = 24;
rand.ttl = 3000L;
adapter.put("1", rand, "persons");
assertThat(template.hasKey("persons:1:phantom")).isTrue();
}
/**
* Wait up to 5 seconds until {@code key} is no longer available in Redis.
*
@@ -776,6 +825,11 @@ public class RedisKeyValueAdapterTests {
}
static class ExpiringPerson extends Person {
@TimeToLive Long ttl;
}
@KeySpace("locations")
static class Location {