DATAREDIS-881 - Polishing.

Add author tags. Reformat code. Javadoc, add tests.

Original pull request: #363.
This commit is contained in:
Mark Paluch
2018-10-16 15:00:25 +02:00
parent 8e8861cbcd
commit 6132799353
5 changed files with 22 additions and 4 deletions

View File

@@ -29,6 +29,7 @@ import org.springframework.lang.Nullable;
*
* @author Mark Paluch
* @author Christoph Strobl
* @author Yanming Zhou
* @since 2.0
*/
class DefaultLettuceClientConfiguration implements LettuceClientConfiguration {
@@ -46,9 +47,7 @@ class DefaultLettuceClientConfiguration implements LettuceClientConfiguration {
DefaultLettuceClientConfiguration(boolean useSsl, boolean verifyPeer, boolean startTls,
@Nullable ClientResources clientResources, @Nullable ClientOptions clientOptions, @Nullable String clientName,
@Nullable ReadFrom readFrom,
Duration timeout, Duration shutdownTimeout,
@Nullable Duration shutdownQuietPeriod) {
@Nullable ReadFrom readFrom, Duration timeout, Duration shutdownTimeout, @Nullable Duration shutdownQuietPeriod) {
this.useSsl = useSsl;
this.verifyPeer = verifyPeer;

View File

@@ -29,6 +29,7 @@ import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
*
* @author Mark Paluch
* @author Christoph Strobl
* @author Yanming Zhou
* @since 2.0
*/
class DefaultLettucePoolingClientConfiguration implements LettucePoolingClientConfiguration {

View File

@@ -42,10 +42,12 @@ import org.springframework.util.Assert;
* <li>Optional {@link ReadFrom}. Enables Master/Replica operations if configured.</li>
* <li>Client {@link Duration timeout}</li>
* <li>Shutdown {@link Duration timeout}</li>
* <li>Shutdown quiet {@link Duration period}</li>
* </ul>
*
* @author Mark Paluch
* @author Christoph Strobl
* @author Yanming Zhou
* @since 2.0
* @see org.springframework.data.redis.connection.RedisStandaloneConfiguration
* @see org.springframework.data.redis.connection.RedisSentinelConfiguration
@@ -141,6 +143,8 @@ public interface LettuceClientConfiguration {
* <dd>60 Seconds</dd>
* <dt>Shutdown Timeout</dt>
* <dd>100 Milliseconds</dd>
* <dt>Shutdown Quiet Period</dt>
* <dd>100 Milliseconds</dd>
* </dl>
*
* @return a {@link LettuceClientConfiguration} with defaults.
@@ -273,7 +277,7 @@ public interface LettuceClientConfiguration {
}
/**
* Configure a shutdown timeout.
* Configure the shutdown quiet period.
*
* @param shutdownQuietPeriod must not be {@literal null}.
* @return {@literal this} builder.

View File

@@ -29,6 +29,7 @@ import org.springframework.util.Assert;
*
* @author Mark Paluch
* @author Christoph Strobl
* @author Yanming Zhou
* @since 2.0
*/
public interface LettucePoolingClientConfiguration extends LettuceClientConfiguration {
@@ -65,6 +66,8 @@ public interface LettucePoolingClientConfiguration extends LettuceClientConfigur
* <dd>60 Seconds</dd>
* <dt>Shutdown Timeout</dt>
* <dd>100 Milliseconds</dd>
* <dt>Shutdown Quiet Period</dt>
* <dd>100 Milliseconds</dd>
* <dt>pool config</dt>
* <dd>default {@link GenericObjectPoolConfig}</dd>
* </dl>