Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREDIS-956 - Polishing.

Browse Source 
Add author tags. Provide override for clientName(…) in LettucePoolingClientConfigurationBuilder. Extend Javadoc. Add and simplify tests.

Original pull request: #446.
This commit is contained in:
Mark Paluch
2019-04-18 11:38:17 +02:00
parent e3b903ce36
commit 647cf25d2b
2 changed files with 34 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/test/java/org/springframework/data/redis/connection/lettuce/LettucePoolingClientConfigurationUnitTests.java
View File

@@ -32,6 +32,7 @@ import org.junit.Test;
*
* @author Mark Paluch
* @author Christoph Strobl
* @author Longlong Zhao
*/
public class LettucePoolingClientConfigurationUnitTests {
@@ -88,20 +89,28 @@ public class LettucePoolingClientConfigurationUnitTests {
@Test // DATAREDIS-956
public void shouldConfigureReadFrom() {
ClientOptions clientOptions = ClientOptions.create();
ClientResources sharedClientResources = LettuceTestClientResources.getSharedClientResources();
GenericObjectPoolConfig poolConfig = new GenericObjectPoolConfig();
LettucePoolingClientConfiguration configuration = LettucePoolingClientConfiguration.builder() //
.poolConfig(poolConfig) //
.clientOptions(clientOptions) //
.clientResources(sharedClientResources) //
.readFrom(ReadFrom.MASTER_PREFERRED) //
.build();
.poolConfig(poolConfig) //
.readFrom(ReadFrom.MASTER_PREFERRED) //
.build();
assertThat(configuration.getPoolConfig()).isEqualTo(poolConfig);
assertThat(configuration.getClientOptions()).contains(clientOptions);
assertThat(configuration.getClientResources()).contains(sharedClientResources);
assertThat(configuration.getReadFrom().orElse(ReadFrom.MASTER)).isEqualTo(ReadFrom.MASTER_PREFERRED);
}
@Test // DATAREDIS-956
public void shouldConfigureClientName() {
GenericObjectPoolConfig poolConfig = new GenericObjectPoolConfig();
LettucePoolingClientConfiguration configuration = LettucePoolingClientConfiguration.builder() //
.poolConfig(poolConfig) //
.clientName("clientName") //
.build();
assertThat(configuration.getPoolConfig()).isEqualTo(poolConfig);
assertThat(configuration.getClientName()).contains("clientName");
}
}